From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BBF4C54E4A for ; Fri, 8 Mar 2024 13:32:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jXhDbW4bVXvhHjEwmxlRlMD83AirWvxRK3H1PU2oOdo=; b=JbMidP+webKbUR 0fgv1phnVp/GpkgqafFPCO5P1jVl5CCddkMXBPvIbXoFbIlO8tJn63t/7+/wCCZ2lRMjkzKKJMl/o CALXdh8uUdaKOTl4kZOldcr5SCDGhcZ6X/JSTN+Pj3G8LMvWRDUX4jUsuZoDDey/1rGL6lKi4mQHC eMI+ieKOPMCzKftQSeuj0Dv/jD+nwONSJQO0F0iCRcSl+r+h0SluLEJ2XiTBXc2uFRND0p1pHEcxL RTsJG1zUcIs2fNwC7pZ4zqgTNXrc67SC81RIQALWwWw60/TACTRBf3jGpzYH2LcQpt9mWmpMHgk6t CsccoBYa0TZPfMZ2PACQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riaKT-00000009JJq-0bij; Fri, 08 Mar 2024 13:32:05 +0000 Received: from mgamail.intel.com ([192.198.163.17]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riaKP-00000009JJE-3rXl for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 13:32:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709904722; x=1741440722; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZaAWTlPgDjUoN2kouy32uLLLJsHht4DaN06qV24JYmM=; b=IezAzImdd6XQ6PlYV9AWta6i4oYXr/r1mwT02V0/f3iMIG9cWllSL0ei ebSqrad+3naD3Bd/2p8/feZpuPboWQKkVPjI5fV0CfAY+4ivUWSv9EJpH f89CSDgjaGCD6MCHR5XB+D29zRh05K2uj9JmtJC/vJzGRAIBxEUs7WfPX aOX/lX32Npn2CXSApDtlBV1lyPhKuIF29ZhQuMBlbtj+WQmAPDah2mCsH tLPxaoTp1QHNy6gp4hMeOczVrUtts1Lf23MhY9ps3lE42eQP/P7m6Uwyf MxY9xbdaXKQKolxSh6+Bm1zjj8lTgZXwhaN64Es8gsuP6gFzcYWVmGxWa Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="4492980" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="4492980" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 05:31:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="914246667" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="914246667" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 05:31:57 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1riaKJ-0000000AqmE-13GA; Fri, 08 Mar 2024 15:31:55 +0200 Date: Fri, 8 Mar 2024 15:31:55 +0200 From: Andy Shevchenko To: Michal Simek Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Re: [PATCH v1 3/3] spi: xilinx: Make num_chipselect 8-bit in the struct xspi_platform_data Message-ID: References: <20240307154510.3795380-1-andriy.shevchenko@linux.intel.com> <20240307154510.3795380-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_053202_002315_ED506506 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 08, 2024 at 09:20:23AM +0100, Michal Simek wrote: > On 3/7/24 16:43, Andy Shevchenko wrote: ... > > struct xspi_platform_data { > > - u16 num_chipselect; > > - u8 bits_per_word; > > - struct spi_board_info *devices; > > - u8 num_devices; > > bool force_irq; > > + u8 num_chipselect; > > + u8 bits_per_word; > > + u8 num_devices; > > all above have 32bits. It means on 64bit cpu you have 32bit gap here. > > + struct spi_board_info *devices; On all architectures? I mean do all 64-bit architecture ABIs _require_ the pointer to be aligned at 8-byte boundary? Even if so, the struct itself can be aligned on 4-byte boundary. > It means this should be like this and then there is no gap between on > 32bit/64bit systems. > > struct xspi_platform_data { > struct spi_board_info * devices; /* 0 8 */ > bool force_irq; /* 8 1 */ > u8 num_chipselect; /* 9 1 */ > u8 bits_per_word; /* 10 1 */ > u8 num_devices; /* 11 1 */ > > /* size: 16, cachelines: 1, members: 5 */ > /* padding: 4 */ > /* last cacheline: 16 bytes */ > }; -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel