From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v1 2/3] spi: xilinx: Add necessary inclusion and forward declaration
Date: Fri, 8 Mar 2024 15:56:57 +0200 [thread overview]
Message-ID: <ZesZKbdIo6z-AfIT@smile.fi.intel.com> (raw)
In-Reply-To: <a3aca544-dc6b-4812-b82e-dd1f9cc04871@amd.com>
On Fri, Mar 08, 2024 at 09:21:32AM +0100, Michal Simek wrote:
> On 3/7/24 16:43, Andy Shevchenko wrote:
> > xilinx_spi.h is mnissing inclusion and forward declaration, add them.
...
> > diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h
> > #define __LINUX_SPI_XILINX_SPI_H
> > +#include <linux/types.h>
> > +
> > +struct spi_board_info;
> > +
> > /**
> > * struct xspi_platform_data - Platform data of the Xilinx SPI driver
> > * @num_chipselect: Number of chip select by the IP.
>
> Likely correct but forget how to check it with tools.
I'm not sure which tools we have to check this.
The types.h is needed for uXX
The forward declaration for the pointer to the mentioned type.
All this has been derived from reading the file.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-08 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 15:43 [PATCH v1 0/3] spi: xilinx: Massage xilinx_spi.h Andy Shevchenko
2024-03-07 15:43 ` [PATCH v1 1/3] spi: xilinx: Fix kernel documentation in the xilinx_spi.h Andy Shevchenko
2024-03-08 8:22 ` Michal Simek
2024-03-07 15:43 ` [PATCH v1 2/3] spi: xilinx: Add necessary inclusion and forward declaration Andy Shevchenko
2024-03-08 8:21 ` Michal Simek
2024-03-08 13:56 ` Andy Shevchenko [this message]
2024-03-08 14:02 ` Michal Simek
2024-03-08 15:00 ` Andy Shevchenko
2024-03-08 15:27 ` Michal Simek
2024-03-07 15:43 ` [PATCH v1 3/3] spi: xilinx: Make num_chipselect 8-bit in the struct xspi_platform_data Andy Shevchenko
2024-03-08 8:20 ` Michal Simek
2024-03-08 13:31 ` Andy Shevchenko
2024-03-08 13:48 ` Michal Simek
2024-03-08 13:55 ` Andy Shevchenko
2024-03-08 14:00 ` Michal Simek
2024-03-08 15:01 ` Andy Shevchenko
2024-03-08 15:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZesZKbdIo6z-AfIT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).