From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26873C5475B for ; Fri, 8 Mar 2024 15:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xCKF3gKyGIaD+HzCEOGg3RGgQuCHeSWjCtc15TQghLo=; b=vtG/nlSngC9EtD C3NAKJD/4BDpYcg4shna735RDNwgrJYMa9vgU1ioi5VCEIh15Y6MttmnVUvHuiv4a5rZP4a3jeS1q a5wTsdDz4ZhUUnB9DGFo0ABGvCnxWF5S2GLI3gyhlvZu56ShUk6MJAojl4k0GLt1w56k/CnupTZ6n FzXq5svHp5w8CkL6KCe7rU+r2zjTwrCQIaCBO0Wq+H2QbgZlK9xLAeHxu7Nkeq9XDCubt2dHMU/L6 YkPlxSj6A8T40AjgOsBlYbJfVN/obFfgfZlJXr0/qvLoLQorQtEK49/ctDfN8t8j0WHUpRP0nVazR RXdcj7ViKYOkVVBQxBAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ribi1-00000009iiJ-0nKH; Fri, 08 Mar 2024 15:00:29 +0000 Received: from mgamail.intel.com ([192.198.163.17]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ribhy-00000009ihL-1rr8 for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 15:00:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709910026; x=1741446026; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BnUs1fzkqy1oP/qNZLXd9NhbFn0nErneJsbGwNTukCI=; b=Sq7xWIXXK5UFuMLJAqeJzdF6w65/FsQoUIQPZ4TaXQgeQzm8IRzY80EN f0fxMkhelRWUl27d6L9pGP+HJD94KIQQOvsUVFNms+P/083/RwQ1aOZXZ et2dDJka8by7TakZtnf2nOGvR6PU+Vf2KfdRr1i3+YDDCffhykiFLSuMv 7pUPwp7mR4MbL6LQCYwUXrSJc2V7eJDbjXJuMVgL+6y8Qgnum3oNdaPfm GeV/Ni6nSM6pnrLcNUv66Ouk7WzJddLghLyFZRhOnsoNcuCcHT9kk+MyX 209KxtNuOKQJlFKxP0NSVWoDIlr3emoqlPWaVOwC1i9sZlY4fAa6f7TI+ g==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="4500206" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="4500206" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 07:00:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="914248405" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="914248405" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 07:00:22 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1ribhs-0000000Arsw-057J; Fri, 08 Mar 2024 17:00:20 +0200 Date: Fri, 8 Mar 2024 17:00:19 +0200 From: Andy Shevchenko To: Michal Simek Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Re: [PATCH v1 2/3] spi: xilinx: Add necessary inclusion and forward declaration Message-ID: References: <20240307154510.3795380-1-andriy.shevchenko@linux.intel.com> <20240307154510.3795380-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_070026_525719_28EAD4FF X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 08, 2024 at 03:02:01PM +0100, Michal Simek wrote: > On 3/8/24 14:56, Andy Shevchenko wrote: > > On Fri, Mar 08, 2024 at 09:21:32AM +0100, Michal Simek wrote: > > > On 3/7/24 16:43, Andy Shevchenko wrote: > > > > xilinx_spi.h is mnissing inclusion and forward declaration, add them. ... > > > > diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h > > > > #define __LINUX_SPI_XILINX_SPI_H > > > > +#include > > > > + > > > > +struct spi_board_info; > > > > + > > > > /** > > > > * struct xspi_platform_data - Platform data of the Xilinx SPI driver > > > > * @num_chipselect: Number of chip select by the IP. > > > > > > Likely correct but forget how to check it with tools. > > > > I'm not sure which tools we have to check this. > > > > The types.h is needed for uXX > > The forward declaration for the pointer to the mentioned type. > > > > All this has been derived from reading the file. > > No issue with it. But I am quite sure there was a tool which was able to > find it out and report it. But forgot which one was it. You mean iwyu? If so, it needs a lot of tuning before being able to be used in Linux kernel. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel