From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38469C5475B for ; Fri, 8 Mar 2024 15:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3KspiVWs+7MfLAgIHmfh1BP8QIttlPLdoqgFvRVj5P4=; b=TNoa0/xarTEZrt PRIUwp/1YuEquwCWwjDt7BwRGXZyTvRu8GHak4MKyyzmEhP54N8iBW/FkvTwFy5+MsW8vMG7eWTDP GR/vVOch99kVGt54eieQgK6954cVHO3xB3xsV30VFj4Zjo2A8GxiI8ADGtalgW3k5G4lcb13fpqE8 8qJfMmIgCKxsHBix/Pa5w3IngjAuzxTXs+uv9+xSd8I1qFaia4d8qILnaD49ia2b1ZkFvXvKCFKUh T4+/5hMH76Rq5DuPX56IwYt7NyrtIYjGIgPPyoFhqbJBmHrMrQhZLOibuyQb6l0NQA/LzrpG28dEP pW4psZnKlA5kBE6bQ3IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ribiw-00000009j00-2fdZ; Fri, 08 Mar 2024 15:01:26 +0000 Received: from mgamail.intel.com ([192.198.163.17]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ribiu-00000009izH-0u0k for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 15:01:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709910084; x=1741446084; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5rIXEhWDQMbkuKjMq7leuyhnVkYnqFlg12KNyns3grg=; b=hK63DX3p0YIrf3onr9wSoHzytXYQ+cNU0WIyuuLsM6yc1OufIGTFCxPV 5IhzK1xa008cY39cQjtlt2ZkcaIaKkz+Bw/G67aJBwy0T5uglE/BJIDvQ xiPUbjIQMygvuDb+RzOwPE+oPMcSY5IP5tRHHtDk12LPtw0QGfHhy+kC2 PDqxcED4FH1EuNpXH8XKue+HdtIe+ucxrR8iS9NUM1AWL5WUhuAixDLrS vcVSIUs7zpl9MW7ZB3HmTfmYLbesT2xCqIPu157IlG3mb9RCOqFidT0Cy RymhNcDoIcrdRbn3mbUPwuLhYefMMx61CAmTm7f3DI3CbuinczNGoKmp6 g==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="4500349" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="4500349" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 07:01:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="914248433" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="914248433" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 07:01:22 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1ribiq-0000000Artm-0LUO; Fri, 08 Mar 2024 17:01:20 +0200 Date: Fri, 8 Mar 2024 17:01:19 +0200 From: Andy Shevchenko To: Michal Simek Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Re: [PATCH v1 3/3] spi: xilinx: Make num_chipselect 8-bit in the struct xspi_platform_data Message-ID: References: <20240307154510.3795380-1-andriy.shevchenko@linux.intel.com> <20240307154510.3795380-4-andriy.shevchenko@linux.intel.com> <1e35a288-0a11-4df6-b7c5-82e5cb6e1d3c@amd.com> <58dca460-d363-432d-9ea7-7f29ec9c4050@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <58dca460-d363-432d-9ea7-7f29ec9c4050@amd.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_070124_290460_83DC30D7 X-CRM114-Status: GOOD ( 22.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 08, 2024 at 03:00:55PM +0100, Michal Simek wrote: > On 3/8/24 14:55, Andy Shevchenko wrote: > > On Fri, Mar 08, 2024 at 02:48:04PM +0100, Michal Simek wrote: > > > On 3/8/24 14:31, Andy Shevchenko wrote: > > > > On Fri, Mar 08, 2024 at 09:20:23AM +0100, Michal Simek wrote: > > > > > On 3/7/24 16:43, Andy Shevchenko wrote: ... > > > > > > struct xspi_platform_data { > > > > > > - u16 num_chipselect; > > > > > > - u8 bits_per_word; > > > > > > - struct spi_board_info *devices; > > > > > > - u8 num_devices; > > > > > > bool force_irq; > > > > > > + u8 num_chipselect; > > > > > > + u8 bits_per_word; > > > > > > + u8 num_devices; > > > > > > > > > > all above have 32bits. It means on 64bit cpu you have 32bit gap here. > > > > > > > > > > + struct spi_board_info *devices; > > > > > > > > On all architectures? I mean do all 64-bit architecture ABIs _require_ > > > > the pointer to be aligned at 8-byte boundary? Even if so, the struct > > > > itself can be aligned on 4-byte boundary. > > > > > > I am not able to tell if toolchain enforce 8byte alignment by default/by > > > setup on all 64bit systems. > > > I am using pahole to check this which was recommended by Greg in past which > > > reports gap in the middle. > > > > I see, thanks for explanation. > > > > Yes, it's likely that in some cases it will be a gap on 64-bit platforms, but > > after this patch no gap on 32-bit. Do you still want me to reshuffle that as > > you suggested? > > Yes I would prefer to do that change when you are doing cleanup. Can you give your tag? Then I prepare a new version with addressed comments against last patch. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel