From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF91FC5475B for ; Fri, 8 Mar 2024 19:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GOmsSvSy2chVS3HIv0I4Xmh93MFDw14oIzu6oLWdj7E=; b=bqVHHYUYQDit3K OUSz4mAnygcUKtmdBWY+35Z8QQWjN5TIHyH3C2lP6fqxvOqZ29EhGmHuSr1vNDDNMV8qczHof8O/a vnBBl3OTfhUaR+rSvoCauTMa2/yDnZNLY+IX+dVM1tNTuYVo75ChzWk5+I77SLhtNQkFBze0NDH2Z SCf+Ka/262BRTS5pT3FKixsBzHOaqOj+3gSx+SafaQxOfAV+TNf70ixqvMIYqgIaCtrKiIQMnyLf0 QhMvG7nRO4P14KzsujQsn3kacBP6SZ0AU3khNJhk6/NQ2gP8xkaeeaxc28a9qrCS7p0R3Wgp4QL1z bZYxBLBDqBPqdbzs7Tuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rifrf-0000000B1h6-07ye; Fri, 08 Mar 2024 19:26:43 +0000 Received: from mail-db8eur05on20613.outbound.protection.outlook.com ([2a01:111:f400:7e1a::613] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rifra-0000000B1eZ-2KF9 for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 19:26:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ru3UUUGCmJIfxUpnzLCGchm7b/K4elzwSH/fXP+rsF5Atm/dWcIWpJOmkBoDFXTJkSXhjjiQk5CX7LCdLALkRqWm+dYVSA8PKA5Qcs87jeVXr4oU6tnlFYcYAA1URJoCr/PacusEbEs0ZfP6zKtBdv7BBuenPlk8uxbC8m0hLXsiZ4JVNzQCTaQIuEHUSA4O4BNYbDEDJKBlBtlHlJmJpUzBz4LUURkDStyKRIbqxMpRk6uA83IBXZDFd7AK6ja9AZOOjIrJ9/du2TUadTHFjkL7Vlmxmu+yWKQGFqJS8XXkNgYf9z0XRAqh/OCH68Cm+16iun6yNxEmi9mgEBYW1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H3SQm+oio7QZ/H8IsFVXqh1PxaZ9rUG4cNrYAOw9C1I=; b=OG55QVcjc+VGLXAuzEkI+gt2Nc4eKhNKyg12Od5QwrFFrO4J7dcjgoPpCi0WUeJ4FW01vp+W4VHOtz0Ay9cD+atcUeYAomu3LBEoyrULHBz4x+bfIDQYTWd7v/Jxv/8cnlFuDzZcjSKc0TF9Js3SEmy8I95zgkYUUW/3vUL4jiolRJvnCsC9gFZ/P7I9ZNsB2g8GCiUZl9AR7iECJ52WQMer6I6WEmZvjkdoCUUESKRT1qKq34y9/fCb6a4igZTXJdV56BGEnjkF10eHG+7BanivrihPi4Kc2C8u7KbmbCJS/c9P0pk+M9KV55RalN2ZOw7/Nv/wFxzo2kY4kyf6UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H3SQm+oio7QZ/H8IsFVXqh1PxaZ9rUG4cNrYAOw9C1I=; b=HLDfPsLcB7XRM+AU1La35GQbUwtGe9yoRTNHLpVVbwhBCFy7ucEvvbVXNLP+ZGMzNZu5tdb1PWBOTa8DLP3f1V16xPcs3ug5Gmgi8q4u6JDYvxvM59+ugBPUvDRMuw03pPbWEWpnKHg3jbikvqjcID9xxX8kLn55XXDxoDngxAY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM8PR04MB7762.eurprd04.prod.outlook.com (2603:10a6:20b:241::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27; Fri, 8 Mar 2024 19:26:29 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7362.024; Fri, 8 Mar 2024 19:26:29 +0000 Date: Fri, 8 Mar 2024 14:26:20 -0500 From: Frank Li To: Rob Herring Cc: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v6 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers Message-ID: References: <20240308-asrc_8qxp-v6-0-e08f6d030e09@nxp.com> <20240308-asrc_8qxp-v6-2-e08f6d030e09@nxp.com> <20240308181103.GA855753-robh@kernel.org> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SJ0PR13CA0054.namprd13.prod.outlook.com (2603:10b6:a03:2c2::29) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM8PR04MB7762:EE_ X-MS-Office365-Filtering-Correlation-Id: c099190a-456e-4825-e927-08dc3fa5a74b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8TCwR4ysC58xB9EPGRZ2oIIYVGlSS+FkIjrhOu36Hb5qBLGaObPSzKGK8TFwM3DOB87zlvZ2mljkPcuCHrcWvpf2VLsuR8UOIv9Lwq68crcwoE4og5t/IB5Vwys+4jd0ZojLa2IJirRuqVQ0paQzzZQpIm+O2orFEsVxhZnYmU+y6DSsVcK90QsjGibeVxVRtx6KfvGenPk3XytamWsdulxYNW04Mmqe5fZTPacKtRze5QZEU8GW4jxs9nRH0XRSXv7zaaOqo0cSqH3GJe0ZszxjHKaEfQvr9YEzg8puryX6PIXpGjWQZRI/v9p1jWo/xfz+BWpx0H1FPaD10/PaG5EykPGIhdmHwpAiHhENMdbwvvXDXYrzIraDDN4m+0Zx1fVanM7bJIXgtVWDzrLeD+6xfOaNpZbn4THkUl8h/e0TuVbpJJaOLMlosdPTe0vW0iYDu+CYU4mwyZNH8ohIToMPCRgzyCVWraWjOhmAXFj3to1hXXGe7OssE9NHnmhkbu0F4ulZ557a3ZPy/wYtykn4jQGm6mn+9AnQa/CJNkaSbCtDzkaTuA4T8lPbNjqCU00nCXlvj/E0HZsxgI2bMTXPMno2gwQS5I0l6jc8YNlKqWhNnWHBtkTe3p+v+uywCF+DVv9M2nRyDpgYD1ixHpKznVXfGH4sjCI8LdYjPfY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(52116005)(376005)(7416005)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/oO7P4oOvNo5jqWDzSp14zBAqvs8tTHK5yhSH3fZSI++AADjkwNxC4hERDd8?= =?us-ascii?Q?LdunAXnq1Y7O8DlZN0wFkGsnXl42s1a9W/dODMzkn6tMKkbRAINHL4m0b3GD?= =?us-ascii?Q?h7fImrH/I453rtE3r9vzMSHzeGNzUltXC+d02ml+O8NcEltysQl+hKsZf/qY?= =?us-ascii?Q?CKG+A/7Fc2bINvh1PeCajUfxbBp62tHfdJ/7luVEPfU8Xf52rioLqr46bllA?= =?us-ascii?Q?Al0OV9Is+rfxZkFCN5Y3ecmxl41ulzVfXs9ASz0Oi9bkn8+IBzSN9TCgTcDB?= =?us-ascii?Q?wDdp/odepj80tgKOWAshT0ZwQMbS8Wj930gdwO5NiBMueVGuS3z6G04lXGDD?= =?us-ascii?Q?sTt8Rs9CSrC7xEWp0afkH0roeyDwcBLbP4MO5zENnbp05B09fmes8MMqBgcJ?= =?us-ascii?Q?H7E0uDX6S9+J5GWHTX6lNcdcYwF1K0zMGVo/nMhqMSZtP6hzSVmddDlAT6/K?= =?us-ascii?Q?JUfBdoL1E0ZpeGEkE9atCdFeLChNzicDKpsoH/6W8f1k30WeKvYwV2VvkdaI?= =?us-ascii?Q?zmyKY68nnhFwT2latqYAIRjyN8criKU9u+jR7mopzp87lp4/Q+nXRp7g1i3j?= =?us-ascii?Q?Rc781gQ8VUlqyGs1WQH+mAG18m1F4LFJ2SQlYxFyO22cwVGl50dE3S+yHF3X?= =?us-ascii?Q?pmwBXRPJHdJ2agsEKjvL+5lNJ/4/FSFsp784aEnRrzCtHWIpG8wLHTcXto03?= =?us-ascii?Q?fA0Mbn5WIf2hLx4PCjf8bs3/QXlieEHUtoeHfMhhwyBc5lUm2tds/7wozz2D?= =?us-ascii?Q?jpaG9bPDh50dNCZuxNX00Q1uzmZf/SmNvW7Tdq/ATlfgugpTCPXlBS0wAgNW?= =?us-ascii?Q?Gn9BhDilBzVb66YIWgqQLEjQstxk3GhnJ/ifdS9v7+zlq6RKqoBM4hX4Midd?= =?us-ascii?Q?PlU//8R5XWjfNIM4OZ1wAxx9QRF65oxeqaUZIggwwBIQjexZ3wENUh2Gqrmx?= =?us-ascii?Q?xD5TNpfSC/6II026CEshqI2nUXMo6jg41LJNbw8phcr2QhyLkKx1KsPZKek3?= =?us-ascii?Q?yUbx/W1sSSFGhsLxZFDWz124XPovNBvrxkL9AhAnaVnm4OHj9GTx5fE5Z8iE?= =?us-ascii?Q?gjhtEcLn/CYI83SpojROlVKjfkVA3pVwEsWPmdnfWeGhgk4fnTAu80SIx9XO?= =?us-ascii?Q?BExOpx0+QufOmpvs+QXET2hMspEonEIIT3F9D7mworgW8xxs9hfuyuzObWD+?= =?us-ascii?Q?Bioa5o1PTqeisn7hbQpFHshbOVid1FPtFvLjPdUICheaz27jG+EFILX9lcYC?= =?us-ascii?Q?IpRROScs3H9kn4CSx4e9AUxTJUQ4qTkEh3xjcY/sbyG6bNsUyXif8mV0upvU?= =?us-ascii?Q?8Vw9BJ4sGGJ2lQAJzfJhyBwgN+JN6axR6pVUDuv6jpLR2FQeCyPFHrnyjNHr?= =?us-ascii?Q?K338sdoQhq+cF1XBWf1dwOoZIQYK0M/zlx/7dy9NBc1p3u7dvKhGTH62to9z?= =?us-ascii?Q?UV/ljzchcI02TBKKA0wUts2U+QeUi4WcKk5+hv9XJRlxAalp4BCleAxKw0XL?= =?us-ascii?Q?5SNxPq5N88aWLuyE3E/qINoxJMlY6ePDj4dJisOPfBS99BQL1MNea5gepVxb?= =?us-ascii?Q?rkVQZtuRKh3d/3QcWJOr55LhR5pFxbzYri3tdQbk?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c099190a-456e-4825-e927-08dc3fa5a74b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 19:26:28.9859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g2oI9LNHmVrEco4r/vASVO30uQM61hZTPWVMwoiZ0WLJSJW3gYUi//vqu9d7gyoS33MTdgeuXg4/+iFsjgIAmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7762 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_112638_628896_FB73DCCA X-CRM114-Status: GOOD ( 27.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 08, 2024 at 02:11:34PM -0500, Frank Li wrote: > On Fri, Mar 08, 2024 at 02:01:29PM -0500, Frank Li wrote: > > On Fri, Mar 08, 2024 at 12:11:03PM -0600, Rob Herring wrote: > > > On Fri, Mar 08, 2024 at 10:30:51AM -0500, Frank Li wrote: > > > > fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms > > > > have 1 interrupt. > > > > > > > > Increase max interrupt number to 2 and add restriction for platforms except > > > > i.MX8QXP and i.MX8QM. > > > > > > > > Acked-by: Conor Dooley > > > > Signed-off-by: Frank Li > > > > --- > > > > .../devicetree/bindings/sound/fsl,spdif.yaml | 21 ++++++++++++++++++++- > > > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml > > > > index 56f8c0c8afdea..a242f68f99f18 100644 > > > > --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml > > > > +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml > > > > @@ -31,7 +31,11 @@ properties: > > > > maxItems: 1 > > > > > > > > interrupts: > > > > - maxItems: 1 > > > > + minItems: 1 > > > > + maxItems: 2 > > > > + items: > > > > + - description: Combined or receive interrupt > > > > + - description: Transmit interrupt > > > > > > Test your patches please because this will have warnings. Or, you can > > > put in *exactly* what I provided because this is not it. > > > > > > If you continue to just toss crap at us at the rate you are, the DT > > > maintainers will either just start ignoring your patches or require some > > > trusted review by another NXP colleague first (offhand, not sure who > > > that would be which is part of the problem). > > > > Sorry, I run wrong command to check another dtb file. So have not catch > > this problem. > > Strange when I run second time, spdif warning disappeared. > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y freescale/imx8dxl-evk.dtb > DTC_CHK arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: /: fixedregulator@101: 'anyOf' conditional failed, one must be fixed: > 'reg' is a required property > 'ranges' is a required property > from schema $id: http://devicetree.org/schemas/root-node.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: bus@34000000: clock-cm40-ipg: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[132000000]], 'clock-output-names': ['cm40_ipg_clk'], 'phandle': [[15]]} should not be valid under {'type': 'object'} > from schema $id: http://devicetree.org/schemas/simple-bus.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: intmux@37400000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/interrupt-controller/fsl,intmux.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@591f0000: 'clocks' is a required property > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@591f0000: Unevaluated properties are not allowed ('power-domains' was unexpected) > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@599f0000: 'clocks' is a required property > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected) > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: serial@5a070000: Unevaluated properties are not allowed ('resets' was unexpected) > from schema $id: http://devicetree.org/schemas/serial/fsl-lpuart.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@5a1f0000: 'clocks' is a required property > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@5a1f0000: Unevaluated properties are not allowed ('power-domains' was unexpected) > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@5a9f0000: 'clocks' is a required property > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@5a9f0000: Unevaluated properties are not allowed ('power-domains' was unexpected) > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: bus@5b000000: clock-conn-bch: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[400000000]], 'clock-output-names': ['conn_bch_clk']} should not be valid under {'type': 'object'} > from schema $id: http://devicetree.org/schemas/simple-bus.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-apbh@5b810000: $nodename:0: 'dma-apbh@5b810000' does not match '^dma-controller(@.*)?$' > from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml# > /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-apbh@5b810000: 'clock-names', 'interrupt-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml# > I figured out what's happen. CHECK_DTB will check binding doc except example part. So I skip run dt_binding_check when I have not touch example part in dt-binding doc. The problem is step 1. run make CHECK_DTB=y freescale/imx8ulp-evk.dtb Then I get some sai error, I found use wrong 8ulp-evk.dtb step 2. run make CHECK_DTBS=y freescale/imx8dxl-evk.dtb Then tools not check dt_binding file again even there are warning. Do you have option let CHECK_DTBS to force check binding doc every time. Frank > > > > > > Frank > > > > > > > > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel