From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E248C54E71 for ; Fri, 22 Mar 2024 17:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y+SWe56LXK6EM3gEp7I1DucbE+R6jEZinGPgho8zJWI=; b=QKIzhAzGDv/Mpw FY+/gwc8iLR5uqxytmTljmevNRtrxIaKI/UE9sMHPhH+g/PVCICO5l3fsV3NVQZ/Pwv0zgOeM8ZD3 VmwY1fsnjFpDR9V6Cp/u5xvUniQm9GTAOWz3ZN5yXJWEfg67RYjctrJ9fbqiUEmNCnJKLHJTgfQ1t l4TnMWp1m8eZWH6EQ0RXyR/jsU9IaiN/CFFGVG/5xNWa3Am1hvt34O7v8WLVAIqidJ/xUiA9XH2IV rsKTF86RqPctSaiYTyt5sHHJUwUFRKXjaqwU2E5pgAMiTf3G9DQ97dBKvFVbB9ifdSRl5jxAnU3fL CuN9zix0j2b1SBbyxmOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rniNm-0000000866x-0fRY; Fri, 22 Mar 2024 17:08:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rniNj-0000000865h-3C9B for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 17:08:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D7CD7FEC; Fri, 22 Mar 2024 10:09:12 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C69BE3F67D; Fri, 22 Mar 2024 10:08:35 -0700 (PDT) Date: Fri, 22 Mar 2024 17:08:33 +0000 From: Sudeep Holla To: David Woodhouse Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Paolo Bonzini , Sudeep Holla , Jonathan Corbet , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Mostafa Saleh , Jean-Philippe Brucker , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-pm@vger.kernel.org Subject: Re: [RFC PATCH v3 5/5] arm64: Use SYSTEM_OFF2 PSCI call to power off for hibernate Message-ID: References: <20240319130957.1050637-1-dwmw2@infradead.org> <20240319130957.1050637-6-dwmw2@infradead.org> <86jzluz24b.wl-maz@kernel.org> <9efb39597fa7b36b6c4202ab73fae6610194e45e.camel@infradead.org> <86edc2z0hs.wl-maz@kernel.org> <12bc0c787fc20e1a3f5dc2588a2712d996ac6d38.camel@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <12bc0c787fc20e1a3f5dc2588a2712d996ac6d38.camel@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_100839_875588_73C1E59B X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 22, 2024 at 04:55:04PM +0000, David Woodhouse wrote: > On Fri, 2024-03-22 at 16:37 +0000, Marc Zyngier wrote: > > > > I agree that nothing really breaks, but I also hold the view that > > broken firmware implementations should be given the finger, specially > > given that you have done this work *ahead* of the spec. I would really > > like this to fail immediately on these and not even try to suspend. > > > > With that in mind, if doesn't really matter whether HIBERNATE_OFF is > > mandatory or not. We really should check for it and pretend it doesn't > > exist if the correct flag isn't set. > > Ack. > > I'll rename that variable to 'psci_system_off2_hibernate_supported' then. > > static void __init psci_init_system_off2(void) > { > int ret; > > ret = psci_features(PSCI_FN_NATIVE(1_3, SYSTEM_OFF2)); > if (ret < 0) > return; > > if (ret & (1 << PSCI_1_3_HIBERNATE_TYPE_OFF)) > psci_system_off2_hibernate_supported = true; > Ah OK, you have already agreed to do this, please ignore my response then. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel