From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25A9CC47DD9 for ; Fri, 22 Mar 2024 17:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QJW6UU3p5z09Z93o+PLG6RpQDDPZ2Y/I/tEdtslvYT4=; b=fYvSMmknmAeA9P 0/kPZ7b+pnotC/C0wghzbhGc+SbGjXjVIA6xQ4rvEiwXgvvCB6nRXrpHx5vFqL+aQ6UOUd7tW6I5R G9BzS0MP3l+tXboRemkJ7cD2A30T5ScVFNZDd3lxUwllE0WyKebZBjsAlKQBVjgMQnHm5wZ5pnqqg oJXb9DOdItL7vhX/oEYohA4jlAAMapG+JsCD+WSC7+Y6IZAj4JTLcqg7O4NFFDyusakiS1+oI+yAw iFa5UtmZgUwq9RrrKY41nGD/eQDKEs19Mmv6g6jBpB4IoQY3st1e6tRLv6VpeEm37fWh8737I1w66 SXLOond+wJQoqQG/PbxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnj2v-00000008E5w-08Mf; Fri, 22 Mar 2024 17:51:13 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnj2r-00000008E5N-3TBQ for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 17:51:11 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-41428b378b9so7125e9.1 for ; Fri, 22 Mar 2024 10:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711129868; x=1711734668; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TD8wow2OS08EXkll41wG+2OWJgdRcKgoxTd9QmAS51w=; b=iAlMDks3b56c0WAR2neTYJAneVP63r541RHmr14SV0onyIktlNXoIF2JILITwftgN4 YAt9leAoR15S9d4fEkVq4hZVMbowQ/s39VYIAS35A4P+l0xS0sYE0nUDw+J6h7Ov7aVp hfPqv7zx9UzoCPulZAVOvXmtbzNnlhw98LDznbw4Qrx9e5mbOgi1AviOxExscuITRXPb ZcnIxTjI6d03df3GIV4M7TFoaG5P09RyYoiVRfmHJTabWZv8vmF3lvq3d7eMGDljLmTK T3VaaNH1/MgcOPoncd6hIFBi4UlX7spOHArpgqbeNz3pqD/wBsCovOf5zW0HgFmUFgbN 13mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711129868; x=1711734668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TD8wow2OS08EXkll41wG+2OWJgdRcKgoxTd9QmAS51w=; b=ccMSrM3t3LL5+eKEbrwQxqvS2j6l+uF2bRl8hF4Vtg1Ff7ra0M7qEfwN1aynSa3RCC soMgoAB84CGB21uOLio0CDcl3GWoKhmgmvow8yGbx3Xrwx715Co4pw1aBEpuldbUakll Emb2d8TVZH9ezc47HA/2GxQJfHb/mls8qA2APFBI5Y4bU+z64WnbCSkjIcOE/O2VrsVM aNTWfZl4lRAlPyRibPMQbRHP0MVxssdrtpbXVcdGHyjIAbqfhvfMbsw2qf3rIafu0Wak UatAm1KHDXGciHdo/bpJgCjgiadAP6ZJ11DPQu7wp3ecUllb4t/NYALk+rsQAaWQyqAk +n5w== X-Forwarded-Encrypted: i=1; AJvYcCWUkl1lD93AT5lwCeTW36boX9y76BLTPtm5VCOfv086mSS7I8P12EU5dN6+I61vZ7ChGwDSbs2i4dmhYcA/1QY9FzMkB5Iqb+byl/Aw4T28DVQ572A= X-Gm-Message-State: AOJu0Ywc6ZJdw6uVdeLp/CfcShxXika8yQHKQ/RDJN5AD9rZliOhuAtP CaQ/40W2qhoPFnWg+zWbwGkC1NO22ipHSlsOc55aVg/ijG98R/fYvOE/eF9AZw== X-Google-Smtp-Source: AGHT+IF+yj96IjCX1EMz/Pt0bDbPQTk6WDPsn7ok0J8RLbHozW2+cvsxJL8Ng4N/Lk7Z45oOH64boQ== X-Received: by 2002:a05:600c:4856:b0:414:1400:a776 with SMTP id j22-20020a05600c485600b004141400a776mr499710wmo.5.1711129867768; Fri, 22 Mar 2024 10:51:07 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id a13-20020a056000050d00b0033e239040d8sm2527556wrf.84.2024.03.22.10.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 10:51:07 -0700 (PDT) Date: Fri, 22 Mar 2024 17:51:03 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v5 02/27] iommu/arm-smmu-v3: Do not ATC invalidate the entire domain Message-ID: References: <0-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> <2-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2-v5-9a37e0c884ce+31e3-smmuv3_newapi_p2_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_105109_961320_D35D210E X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jason, On Mon, Mar 04, 2024 at 07:43:50PM -0400, Jason Gunthorpe wrote: > At this point we know which master we are going to change the PCI config > on, this is the only device we need to invalidate. Switch > arm_smmu_atc_inv_domain() for arm_smmu_atc_inv_master(). > > Tested-by: Nicolin Chen > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index d1bc151a5dff8c..9e9233331c4636 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -2447,7 +2447,10 @@ static void arm_smmu_enable_ats(struct arm_smmu_master *master, > pdev = to_pci_dev(master->dev); > > atomic_inc(&smmu_domain->nr_ats_masters); > - arm_smmu_atc_inv_domain(smmu_domain, IOMMU_NO_PASID, 0, 0); > + /* > + * ATC invalidation of PASID 0 causes the entire ATC to be flushed. > + */ > + arm_smmu_atc_inv_master(master); > if (pci_enable_ats(pdev, stu)) > dev_err(master->dev, "Failed to enable ATS (STU %zu)\n", stu); > } > -- > 2.43.2 Reviewed-by: Mostafa Saleh Thanks, Mostafa _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel