From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A6F6C47DD9 for ; Sat, 23 Mar 2024 02:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+8liAWf2/309um0cScxDxHNl7RSpgLLZLq3dA1hKbOM=; b=Pfns0b1KlWVrq/ P9+TCunMB+1DOZFQXgl4VNB/FjH48WN1vaoxn8zRRCA9JtlclC9T73AbGXRJ5EWzEgf52K8AFJvcA fUr2KphCINBFpCjO/NHGFff9iB1nP7aaJvWiC069j1wZQatCW10ZtN98DSoWfLEhTWDBdHEes5gVg /ist4RCB7GFXQ01VI22alNbWPymUzdSR5j5ti4i3mfis2B7WyAz7gv7jxLHP/dJvLx9eY6zJJobtz 8Vu2J/zXFGpzUuNw7X7SCYA0lY3vMVPrk1bMweB0CoupzDPG1uFaV9qeNi2H5//nDkJZFoKSsw6md vR8eqtS0+9LKqlLhYuFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnqno-00000009Cod-2ben; Sat, 23 Mar 2024 02:08:08 +0000 Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnqnl-00000009ClC-243h for linux-arm-kernel@lists.infradead.org; Sat, 23 Mar 2024 02:08:07 +0000 Date: Fri, 22 Mar 2024 19:07:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711159681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5VkD5z9YkAdX6FArt2jg1nT/B62sh2p7lPRadskyhS4=; b=SDHpXhFdepH9Nj+WO/hIIjmvTRVCgXX6AKi+TQQXTYMd1JS/R4MWvwg2QeCz5Aza55n83d GkB2zofd2b4riHxCi3zhFaTsWoBg0QiEQG46JIHRc+WKtDgpogxfMXOXnsnveH9HCUaWhT pXFNjI9dkhah5sJIwmnK7NeD46SWwrs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sebastian Ene Cc: catalin.marinas@arm.com, james.morse@arm.com, jean-philippe@linaro.org, maz@kernel.org, qperret@google.com, qwandor@google.com, suzuki.poulose@arm.com, tabba@google.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 2/2] KVM: arm64: Allow only the specified FF-A calls to be forwarded to TZ Message-ID: References: <20240322124303.309423-1-sebastianene@google.com> <20240322124303.309423-2-sebastianene@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240322124303.309423-2-sebastianene@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_190805_732249_D8D515FE X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 22, 2024 at 12:43:03PM +0000, Sebastian Ene wrote: > The previous logic used a deny list to filter the FF-A calls. Because of > this, some of the calls escaped the check and they were forwarded by > default to Trustzone. (eg. FFA_MSG_SEND_DIRECT_REQ was denied but the 64 > bit version of the call was not). > Modify the logic to use an allowlist and allow only the calls specified in > the filter function to be proxied to TZ from the hypervisor. I had discussed this with Will back when the feature was upstreamed and he said there's a lot of off-label calls that necessitate a denylist implementation. Has anything changed to give us confidence that we can be restrictive, at least on the FF-A range? -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel