From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C87BC54E58 for ; Tue, 12 Mar 2024 20:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lohia+kv940anQ48TpkWUkXJaz/+6kbkwLWaoe1NYd8=; b=j+egqU4+AyzGyT 92a3JkxkhkVGim0018tscbE4TUMPB3LDRPKvgsJTMBXiQQsyMhvqjUPJ/RfjWQYcqFjiGrVfKgfi+ ceIvZI95jKcGNZ+kKMqF5MVs9+6TGHlriNR667xaY2m05IaoCOYLbXE+EyD1UhQicmjsGCTTWWJWZ +6hvj0HojeOWGiLpcJOjtSJBC9yLocO7+pe5KA2pJVt646//yYG90I5/SHc/toPeRmk3hyZdluWgq 3vqb63Deldcnc6W6/S+VefMPJrqD5LW91j0Zcg0t2Z8oWh+KMoDZ37GlNVfCTzlyktUnFgM6TZmsB QvIxTQU0y3mZDYWuIkTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk8JU-00000007OBY-3lbR; Tue, 12 Mar 2024 20:01:28 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk8JQ-00000007O9U-1jsW for linux-arm-kernel@lists.infradead.org; Tue, 12 Mar 2024 20:01:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710273682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sq8Q7APw4DcVkqWc+oejv1fuFkz+jT1GPn/e6E4W0Yk=; b=ZKQ3snpri8r+3q9plO5BJ7tIv5PnKEWn3i3GPhYPbD1Yezz1guiDCuECvT/2aeu6l1Cq/T lRek4cHQVG7OZb3kGzf/Laa8z+EYkjyvJ3MtT6zB5v2JYZc945iz532YRsbS1IqHabq1cw nSNUtG2aW+Cehope1/h1EuE9mPvAS8s= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-clfv8Ne5M1Kz_ZxOhIPvSg-1; Tue, 12 Mar 2024 16:01:18 -0400 X-MC-Unique: clfv8Ne5M1Kz_ZxOhIPvSg-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-42ef59a624fso4362811cf.0 for ; Tue, 12 Mar 2024 13:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710273677; x=1710878477; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sq8Q7APw4DcVkqWc+oejv1fuFkz+jT1GPn/e6E4W0Yk=; b=U9eUrCBwALJUZkliMKOteY4emAhSHZHIVgPUYj/tlqHaeiOX80mTZrJNjRHXhlgFjy QmDE+mCxQLGyESOZhdx8bJ1Wj6zcoJVD3IKkHKm+lfoaNBqP97MDoGb3yKLwkBrIG5VH q0GJm1T2be7z+2OgRRp0KDulCfES3l/zy4cjqXESyHGTG513K3RcpM0ho4ImjPa4+U1Q KxUjn31oUPIdpCJM806OnPlTM5ygEIIBMmPOCaPDZGsojedr5QeWmMyac4Nn8I2j4gCF zSW/lStmUQDtJ/KtE+svADupOvMxt5ViX9ahRofLa0deV9Yqrum13AyoLMN633s71gqA voLA== X-Forwarded-Encrypted: i=1; AJvYcCWQIJSDtqpyOm/lurd+TO2r5QENrTK6nE6VfENkttJtC+lW2yStlBJwwaaC4dicof6vT/vSx5ArCvKTuNXabn87P5PF3JQodDa+OYKhKHkpx+AdhIo= X-Gm-Message-State: AOJu0YyRreCv84s2ShyCEOIXRTuhOXO9utVlyH4YeIjl31Z8LM7VV6tH AVyWQE6k5ggm9BlGSd5MviOfaUeFkGaNjmYDTsJ4tKWXNVVQelPhduRBk5S2F9oghmhGI1exUr8 /zvSQhnxf6AdJfPZgqTqOf2LoncWucUnqCUkeEYW3M83Mu59htras5GmF9odsZLOPCcyBYPgC X-Received: by 2002:a05:620a:2715:b0:788:79d3:402e with SMTP id b21-20020a05620a271500b0078879d3402emr3492042qkp.7.1710273677507; Tue, 12 Mar 2024 13:01:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFci8LJ7emFKeNaMhqM4be32i5qK2b8ngNE0xIpit/UyC+7KzN+KAk6ieS3wmiUOL3/zXkrQ== X-Received: by 2002:a05:620a:2715:b0:788:79d3:402e with SMTP id b21-20020a05620a271500b0078879d3402emr3492030qkp.7.1710273677131; Tue, 12 Mar 2024 13:01:17 -0700 (PDT) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id f18-20020a05620a12f200b007882915ca34sm3977850qkl.40.2024.03.12.13.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 13:01:16 -0700 (PDT) Date: Tue, 12 Mar 2024 16:01:14 -0400 From: Peter Xu To: Christophe Leroy Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Andrew Morton , Muchun Song , Jason Gunthorpe , Matthew Wilcox , Mike Rapoport , "x86@kernel.org" , "sparclinux@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH RFC 00/13] mm/treewide: Remove pXd_huge() API Message-ID: References: <20240306104147.193052-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240312_130124_789345_66A20135 X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Christophe, On Mon, Mar 11, 2024 at 09:58:47AM +0000, Christophe Leroy wrote: > Hi Peter, and nice job you are doing in cleaning up things around _huge > stuff. Thanks. I appreciate your help along the way on Power. > > One thing that might be worth looking at also at some point is the mess > around pmd_clear_huge() and pud_clear_huge(). > > I tried to clean things up with commit c742199a014d ("mm/pgtable: add > stubs for {pmd/pub}_{set/clear}_huge") but it was reverted because of > arm64 by commit d8a719059b9d ("Revert "mm/pgtable: add stubs for > {pmd/pub}_{set/clear}_huge"") > > So now powerpc/8xx has to implement pmd_clear_huge() and > pud_clear_huge() allthough 8xx page hierarchy only has 2 levels. Those are so far out of my radar, as my focus right now is still more on hugetlbfs relevant side of things, while kernel mappings are not yet directly involved in hugetlbfs, even though they're still huge mappings. It's a pity to know that broke arm and got reverted, as that looks like a good thing to clean it up if ever possible. I tend to agree with you that it seems for 3lvl we should define pgd_huge*() instead of pud_huge*(), so that it looks like the only way to provide such a treewide clean API is to properly define those APIs for aarch64, and define different pud helpers for either 3/4 levels. But I confess I don't think I fully digested all the bits. Thanks, -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel