From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CABDBC54791 for ; Wed, 13 Mar 2024 16:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/pOnCQg0elhqWhw2mKZM7bQFMdKMKXJ3eGAGGW8ujzY=; b=Cl+ddwMdr6oUEj gH5KYvUXm1JXkOoepX4pR5S0jRsfoNIdRx+UJhspGACqWEM8hscTc0IXPbhwXZHEnk7Yk+9vRkTCi /pPIRoSa9hEPtRNQs2pH5ZrQQPnA4pqWKmEzReLCxqDSqejuy0nrtlMdA9rzdJvFq7QUmTB2CEFzM FsAaMzxoYDPKFsdyAFs56quoZQFybQQ1H/1gqh478RwKl5y47+tC8LANWAnMMH+0vBn32jeAU7F3d XLziktN5AhLePQUJnUKVegio+n6UGoYvvSPBMHeLmbZu68lbo2RvvDDkU8LzyndLKUP8CbdVD0qn4 oUxHqveZwLLpQbVOvS1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkRne-0000000ArPj-36N3; Wed, 13 Mar 2024 16:49:54 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkRna-0000000ArN0-2duP for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 16:49:52 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a466a1f9ea0so6384366b.1 for ; Wed, 13 Mar 2024 09:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1710348589; x=1710953389; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=QPkIANYlnqpJGOaQz5GtJSLehMlH+HibJAm6EUdPbkE=; b=WRrP4I8gtEkpsbPLPu5mmhDuxO6QRZqVihUCtIPagplQ1LSqFnXfIY01XxwjLWCSMn P/NYscWM6BsXmICVlHqOvoPIXGQYhbb7qX4nZYMnDeOvpl0JnHl+8SS/9/wLfWnqQHhd mrhHXtNucj5LeyF6o9dMUiAb3kB0xOS9xkkQBQi3Tw35qW6I16PkdWQcBO0073/F+82d HlBLL+pOZgZTZ1DO/y1qolDZaUHnqJJm83Nwn/jnSKwG4m/g8kUoU201UDV84ugcBIU0 7hv1/h8qPgHZ/Z1MY1hYISQE0c+Sqq859uXKP4G+7wawVYpYOaiyZiqHY8kZIwL3Eru5 0GwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710348589; x=1710953389; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QPkIANYlnqpJGOaQz5GtJSLehMlH+HibJAm6EUdPbkE=; b=QOq434TCUD70g+Cf+i0nQ9Qx7y5tZbH+FrX5rMA7nKJiLgnIs1sZ/8D/cVHVSV18jK n8G/6qhK1rVNBTmEx6ZIGrywvYlBdFZR4MHk7L5EcJVuKIWTIkLZ7I0Sio5Eyy9WtCa2 DWIeH18+am2xPOnpXkEN9Iyy12TcSVLXPsaFOF9b5nUZ+IMy82Ql0wGT50pAS+Uj6oBd U6csEQq79EJhtdFNMW58CJ3gQ25OIMDJtaB0tmMPr8lghm8K5PbHprcCe9sDYJLEbONf NnjLyBHKFBPJUiM+GyJnVDszs7Ht0/LU9J+P+t9Sh/u2anyoUBJ/GrQeqHn6wUyXW/xb +KZQ== X-Forwarded-Encrypted: i=1; AJvYcCU35wsW2M0Yh5prSkLG3XpLXcdioPibHdX+5xIpyS4ihyHAJJ+PaOmHRBtLcIR6rNM/R6C7WsrtnIOc7J8cYbWLESYcX/GEAqULauARPrdGXyIghII= X-Gm-Message-State: AOJu0YzQAAHTwLF3oQExhBLVydGMrmQ317VspmkQCeIbu5xZiB4MgEfS z3CMz2s0UynJgRE0ZEw8OrjA1wJu/SJu/pknOwprpr6bhcdOrjoHa9Pgni00Kl8= X-Google-Smtp-Source: AGHT+IGqIboO89JDdz68otiTxC7R5thbY+dJhwJvuyQri1Y0mW+DslANVakowZJW0e4mX3PczuljcA== X-Received: by 2002:a17:907:a644:b0:a46:134c:ae8c with SMTP id vu4-20020a170907a64400b00a46134cae8cmr9631602ejc.50.1710348588653; Wed, 13 Mar 2024 09:49:48 -0700 (PDT) Received: from localhost (host-82-56-173-172.retail.telecomitalia.it. [82.56.173.172]) by smtp.gmail.com with ESMTPSA id bn23-20020a170906c0d700b00a462e4d7216sm2787595ejb.76.2024.03.13.09.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 09:49:48 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Wed, 13 Mar 2024 17:49:47 +0100 To: Florian Fainelli Cc: Andrea della Porta , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list , Saenz Julienne , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dave.stevenson@raspberrypi.com, Phil Elwell , Maxime Ripard , Stefan Wahren , Dom Cobley Subject: Re: [PATCH v2 01/15] dmaengine: bcm2835: Fix several spellos Message-ID: Mail-Followup-To: Florian Fainelli , Andrea della Porta , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list , Saenz Julienne , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dave.stevenson@raspberrypi.com, Phil Elwell , Maxime Ripard , Stefan Wahren , Dom Cobley References: <831fee14-387a-41d9-8dfc-e3ba09a140b1@broadcom.com> <886b0def-7884-4780-8b7f-e29bf3d9ce7d@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <886b0def-7884-4780-8b7f-e29bf3d9ce7d@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_094950_700494_149BFE96 X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09:38 Wed 13 Mar , Florian Fainelli wrote: > On 3/13/24 08:26, Andrea della Porta wrote: > > On 08:00 Wed 13 Mar , Florian Fainelli wrote: > > > > > > > > > On 3/13/2024 7:08 AM, Andrea della Porta wrote: > > > > Fixed Codespell reported warnings about spelling and coding convention > > > > violations, among which there are also a couple potential operator > > > > precedence issue in macroes. > > and s/macroes/macros/ right, sorry about that... > > > > > > > > > Signed-off-by: Andrea della Porta > > > > > > There are no spelling errors being fixed in this commit, this is purely > > > stylistic and conforming to the Linux coding style guidelines. > > > > - /* detect a size missmatch */ > > - if (buf_len && (d->size != buf_len)) > > + /* detect a size mismatch */ > > + if (buf_len && d->size != buf_len) > > > > Isn't 'missmatch' a spelling error? Maybe I can drop the word 'several', since it's > > indeed only one... > > Can we agree this was easy to miss when 99% of the changes are stylistic? > The summary is that the commit subject and the message are not describing > what this patch is about. > -- > Florian > I agree with you that I could've added '...and coding style fixes' to the subject (while also dropping 'several'). The comment seems fine enough though. Maybe you're suggesting to separate the patches into two, one dealing with spelling errors and the other with coding conventions? Many thanks, Andrea _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel