From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Duanqiang Wen <duanqiangwen@net-swift.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH clk v2] clk: clkdev: add error messages for name exceeding maximum length
Date: Thu, 14 Mar 2024 08:42:27 +0000 [thread overview]
Message-ID: <ZfK4c/wZX9RmBHXj@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240314023909.871105-1-duanqiangwen@net-swift.com>
On Thu, Mar 14, 2024 at 10:39:09AM +0800, Duanqiang Wen wrote:
> if one device register clkdev with dev_id or con_id
> greater than maximum length, clkdev_create functions
> will not return err, but clk_find functions will not
> match the device, it's difficult to identify issues
> for developers.So add error messages for dev_id greater
> than 20 characters and con_id greater than 16 characters.
>
> eg. clkdev_create(clk, NULL, "i2c_designware.16796")
> it will create clk_lookup with dev_id "i2c_designware.1679",
> because clk_name exceeds dev_id maximum, but clkdev_create not
> return err. when driver call clk_find functions, use "i2c_desig
> nware.16796" to find clk, it will return failed,but I don't know
> where the problem is. It took a long time to find the problem.
>
> Signed-off-by: Duanqiang Wen <duanqiangwen@net-swift.com>
This looks like v1 just reposted with a v2 tag. I don't see any obvious
changes in the patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-03-14 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 2:39 [PATCH clk v2] clk: clkdev: add error messages for name exceeding maximum length Duanqiang Wen
2024-03-14 8:42 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfK4c/wZX9RmBHXj@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=duanqiangwen@net-swift.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).