Re: [PATCH v2 5/5] remoteproc: arm64: corstone1000: Add the External Systems driver

Abdellatif El Khlifi
2024-09-18T15:41:39Z

Hi Mathieu,

> Introduce remoteproc support for Corstone-1000 external systems
>
> The Corstone-1000 IoT Reference Design Platform supports up to two
> external systems processors. These processors can be switched on or off
> using their reset registers.
>
> For more details, please see the SSE-710 External System Remote
> Processor binding [1] and the SSE-710 Host Base System Control binding [2].
>
> The reset registers are MMIO mapped registers accessed using regmap.
>
> [1]: Documentation/devicetree/bindings/remoteproc/arm,sse710-extsys.yaml
> [2]: Documentation/devicetree/bindings/arm/arm,sse710-host-base-sysctrl.yaml
>
> Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> ---
> drivers/remoteproc/Kconfig | 14 +
> drivers/remoteproc/Makefile | 1 +
> drivers/remoteproc/corstone1000_rproc.c | 350 ++++++++++++++++++++++++
> 3 files changed, 365 insertions(+)

A gentle reminder about reviewing the driver please.

I'll be addressing the comments made for the bindings.

Thank you in advance.

Cheers,
Abdellatif