Re: [PATCH v2 1/5] dt-bindings: remoteproc: sse710: Add the External Systems remote processors

Abdellatif El Khlifi
2024-09-19T09:36:56Z

Hi Krzysztof,

> > Add devicetree binding schema for the External Systems remote processors
> >
> > The External Systems remote processors are provided on the Corstone-1000
> > IoT Reference Design Platform via the SSE-710 subsystem.
> >
> > For more details about the External Systems, please see Corstone SSE-710
> > subsystem features [1].
> >
>
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets.
>
> > [1]: https://developer.arm.com/documentation/102360/0000/Overview-of-Corstone-1000/Corstone-SSE-710-subsystem-features
> >
> > Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> > ---
> > .../remoteproc/arm,sse710-extsys.yaml | 90 +++++++++++++++++++
> > 1 file changed, 90 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/remoteproc/arm,sse710-extsys.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/arm,sse710-extsys.yaml b/Documentation/devicetree/bindings/remoteproc/arm,sse710-extsys.yaml
> > new file mode 100644
> > index 000000000000..827ba8d962f1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/remoteproc/arm,sse710-extsys.yaml
> > @@ -0,0 +1,90 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/remoteproc/arm,sse710-extsys.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: SSE-710 External System Remote Processor
> > +
> > +maintainers:
> > + - Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> > + - Hugues Kamba Mpiana <hugues.kambampiana@arm.com>
> > +
> > +description: |
>
> dt-preserve-formatting

Do you mean I should remove the '|' please ? (I didn't find examples of use of
dt-preserve-formatting in Documentation/devicetree/bindings/)

>
> > + SSE-710 is an heterogeneous subsystem supporting up to two remote
> > + processors aka the External Systems.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - arm,sse710-extsys
> > +
> > + firmware-name:
> > + description:
> > + The default name of the firmware to load to the remote processor.
> > +
> > + '#extsys-id':
>
> '#' is not correct for sure, that's not a cell specifier.
>
> But anyway, we do not accept in general instance IDs.

I'm happy to replace the instance ID with another solution.
In our case the remoteproc instance does not have a base address
to use. So, we can't put remoteproc@address

What do you recommend in this case please ?

Kind regards,
Abdellatif