From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CA19C54E67 for ; Fri, 15 Mar 2024 18:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fNMhfu/7LxVzEahQMHErfPb5CQn8LrG0PtkNY0cBuJY=; b=zw1SVUWs1QS6xq aMNtmN6SmTDgKTzpYKWEneeJ5EUHU/mYxaOZopISi4dZ5kOjSnJ1cTA9hdv18ADuVGLuynKI6V86N urmJqr5xfIag7TvTSNq/c4aoxbV3jM1u6+ORXMHQlC7MlHhp3UopVgYLGnOKaUBzTefFPTLqvje55 QnFfVYA+CD82HGwh0P2rWzu0pir1gdcZBh60TJoRop0Bg+3alTT8Ae7J6Pulwj6tmUgFd+B1/KA4R K/ffx8XjM9Aq+ZyJEEmbSme6WuQYxNteNenFy2jS9edkHeJMuLTgdwF96AiBldpKclmKv7EqnGMXG m1dN358cmfXGsADBN9cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlCeO-00000001EBy-38Sv; Fri, 15 Mar 2024 18:51:28 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlCeL-00000001E97-2o1W for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2024 18:51:27 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1dc75972f25so18004935ad.1 for ; Fri, 15 Mar 2024 11:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710528683; x=1711133483; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qQtwelcSgwGFeTnZLVof0pwhxwav0Nmdkno2Inz3sLw=; b=YaFq6i+AEKmoIv3B8fvmCNgi3CRU98EVcgmSyEafDEAYsuiOPo2KWvv8Vc8k0pHCrI gcQWGtJqP4lYSvaAOAul0FKE24qHgoG+6OlG7JSKwzG/ZvvS0CJbAViE6D2N/+RfOTV0 USetHZQvUmWUnyTisWSLYxsCLDMIlh+Fyp1H5vSrZJByDbzfyO5Igomy/93htluHXHw8 v3FPQI30VcEF1N5KkP4z/1oo8+OhFBWScoPeql+EfTjfs3KW3N1to8wO0Apiw32tAE31 TN2RTbK8ajVVjyzMJO5ad1xlq+SggA5y80DlNbtpFd4vifCibsRYUfoKEJlCgYWv44xp vLpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710528683; x=1711133483; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qQtwelcSgwGFeTnZLVof0pwhxwav0Nmdkno2Inz3sLw=; b=VHH+rJoEApaQKJSyjLhnLdUyXowl1xIDcijLjm2IqUyxO0KScwLhvNHGHHyIiESrmM bl2u9Ygy5aOjJSdFfklWVro6nIwx8l/H0a6i7jjkBSByCVfroVFpvqaUii2hNGPCKX/4 jCqUeIdw2ynb1RiJZj5H78sYlnMDy6EVUX/JHkO5cUJW/tsWOIawSVz6JGlxIZ+Upj2I ljXA/GhcJDj/WkM02Rq++GpTtZLiaKAsvKJb8kkDtJsIgy7F0TPywP0av3ISnxSMZuvx eR5N89xywweyUHIK7Cuo34rf/u4tgPy7kwYe1BNcPagDeo8yk5IkYWtQ87G6dPWfvEnc DgWg== X-Forwarded-Encrypted: i=1; AJvYcCU0df9ESoIdeRK/1I/Xeb8mTqpA1sBRpYJs9jhj3C0j/TQohS5bq2AN0rXiT5fDqnF2hjwq5CghVa8+yJ/k3mSRylRxPyN3uEHzO3dzESN+4Fytubs= X-Gm-Message-State: AOJu0YyTGgj5SeNh5HVxM/DRjb4JsTL1PSSAJwu5dBQHVBzLwDiHB67J FDA6TufddlaG1fSt6OCnDUf4iHoWYp4kMZaFAD5DUSOnaejUO56Nov22qs+J X-Google-Smtp-Source: AGHT+IF2HQskcpCyIR3dSZHfWz5hEStmH0IR/3eWOj+Efeu9g7w0OAdVU5R7xHfBDlK1SDx09ySDHA== X-Received: by 2002:a17:903:11c3:b0:1dd:7d6a:d6c8 with SMTP id q3-20020a17090311c300b001dd7d6ad6c8mr6727294plh.14.1710528682446; Fri, 15 Mar 2024 11:51:22 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:c446:74f0:5cd2:d078]) by smtp.gmail.com with ESMTPSA id u2-20020a170902e80200b001defbc29a05sm820862plg.40.2024.03.15.11.51.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 11:51:21 -0700 (PDT) Date: Fri, 15 Mar 2024 11:51:19 -0700 From: Dmitry Torokhov To: Stefan Eichenberger Subject: Re: [PATCH RESEND v3 2/2] Input: atmel_mxt_ts - support poweroff in suspend Message-ID: References: <20240209105012.22470-1-eichest@gmail.com> <20240209105012.22470-3-eichest@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240209105012.22470-3-eichest@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_115125_796854_90A45627 X-CRM114-Status: GOOD ( 33.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, nick@shmanahar.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, linux-input@vger.kernel.org, conor+dt@kernel.org, Stefan Eichenberger , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev, francesco.dolcini@toradex.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, On Fri, Feb 09, 2024 at 11:50:12AM +0100, Stefan Eichenberger wrote: > From: Stefan Eichenberger > > Add a new device tree property to indicate that the device should be > powered off in suspend mode. We have a shared regulator that powers the > display, a USB hub and some other peripherals. The maXTouch controller > doesn't normally disable the regulator in suspend mode, so our extra > peripherals stay powered on. This is not desirable as it consumes more > power. With this patch we add the option to disable the regulator in > suspend mode for the maXTouch and accept the longer initialisation time. > > Signed-off-by: Stefan Eichenberger > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 72 ++++++++++++++++++------ > 1 file changed, 55 insertions(+), 17 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 542a31448c8f..2d5655385702 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -317,6 +317,7 @@ struct mxt_data { > struct gpio_desc *reset_gpio; > struct gpio_desc *wake_gpio; > bool use_retrigen_workaround; > + bool poweroff_sleep; > > /* Cached parameters from object table */ > u16 T5_address; > @@ -2799,15 +2800,18 @@ static int mxt_configure_objects(struct mxt_data *data, > dev_warn(dev, "Error %d updating config\n", error); > } > > - if (data->multitouch) { > - error = mxt_initialize_input_device(data); > - if (error) > - return error; > - } else { > - dev_warn(dev, "No touch object detected\n"); > - } > + /* If input device is not already registered */ > + if (!data->input_dev) { > + if (data->multitouch) { > + error = mxt_initialize_input_device(data); > + if (error) > + return error; > + } else { > + dev_warn(dev, "No touch object detected\n"); > + } > > - mxt_debug_init(data); > + mxt_debug_init(data); > + } > > return 0; > } > @@ -3325,6 +3329,8 @@ static int mxt_probe(struct i2c_client *client) > msleep(MXT_RESET_INVALID_CHG); > } > > + data->poweroff_sleep = device_property_read_bool(&client->dev, > + "atmel,poweroff-sleep"); > /* > * Controllers like mXT1386 have a dedicated WAKE line that could be > * connected to a GPIO or to I2C SCL pin, or permanently asserted low. > @@ -3387,12 +3393,21 @@ static int mxt_suspend(struct device *dev) > if (!input_dev) > return 0; > > - mutex_lock(&input_dev->mutex); > + if (!device_may_wakeup(dev) && data->poweroff_sleep) { > + if (data->reset_gpio) > + gpiod_set_value(data->reset_gpio, 1); > > - if (input_device_enabled(input_dev)) > - mxt_stop(data); > + regulator_bulk_disable(ARRAY_SIZE(data->regulators), > + data->regulators); > + data->T44_address = 0; > + } else { > + mutex_lock(&input_dev->mutex); > + > + if (input_device_enabled(input_dev)) > + mxt_stop(data); > > - mutex_unlock(&input_dev->mutex); > + mutex_unlock(&input_dev->mutex); > + } This all should go into mxt_stop(), so that if device is closed, or inhibited, you power it down as well (if you can). > > disable_irq(data->irq); > > @@ -3408,14 +3423,37 @@ static int mxt_resume(struct device *dev) > if (!input_dev) > return 0; > > - enable_irq(data->irq); > + if (!device_may_wakeup(dev) && data->poweroff_sleep) { > + int ret; > > - mutex_lock(&input_dev->mutex); > + ret = regulator_bulk_enable(ARRAY_SIZE(data->regulators), > + data->regulators); > + if (ret) { > + dev_err(dev, "failed to enable regulators: %d\n", > + ret); > + return ret; > + } > + msleep(MXT_BACKUP_TIME); > > - if (input_device_enabled(input_dev)) > - mxt_start(data); > + if (data->reset_gpio) { > + /* Wait a while and then de-assert the RESET GPIO line */ > + msleep(MXT_RESET_GPIO_TIME); > + gpiod_set_value(data->reset_gpio, 0); > + msleep(MXT_RESET_INVALID_CHG); > + } > > - mutex_unlock(&input_dev->mutex); > + /* This also enables the irq again */ > + mxt_initialize(data); And this needs to go into mxt_start(). Also, we should make sure that once resume operation completes the device is fully operational. That means you should not request the firmware asynchronously in mxt_initialize() in case you are in the resume path. I think you should also unwind mxt_initialize() and mxt_configure_objects() to make it clear what is the part of initial initialization and what is part of re-initializing during resume. The configuration that is exposed to userspace (resolution, number of objects, other properties) should stay the same, the configuration of the chip itself (power mode, etc) should be restored. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel