From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3C2CC54E67 for ; Fri, 15 Mar 2024 19:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=11eMkzbgTjlv7cud1Ad9g12FTx7Pw4QQNgXHB6zQL9Q=; b=rAF6BEq5/xkmu9 1DoYCCgflrsxq9M6w3seLWOFrrB9A0ebhHWIr61D+/+L1hotOIvE5DLVY02HT5FuWB+m+hn8TEykS 5c89RGVLfPe6Fby5fleWV0iIy2FfZEdoTwKhX+xb1JgaUY20as3EybEjjbLPzDz0p4vZ4OK0t/Pls pNkzJW7XEledxVJc91FntesiSoeRw1/Kwop7wAMyW7/QVB0QP9E4ubiersYH+WKcioWQmCojkllpQ upl6TiX9dxNImfvRSgmEWe+GxqN+RVN39kPcn5Ru7ReC5QWxK7PcT00bU09c8DR5IdkuEhLGQB0ln w7AMGqz1bhXgBDb5UfDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlDQk-00000001Kn5-2GFB; Fri, 15 Mar 2024 19:41:26 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlDQe-00000001KkY-3dGD for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2024 19:41:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vMOcpYICmwo4NpAZCDNBpaBc/6gPeBk9CzUAQqBpilA=; b=HCT3565WV5UxuJ3TBs/5syfKBE V4P9LDnldEV0tQWyqel0o8jOh+aKI8AlpYnEbVxA7zJBobmemldHUiWr0ejxKyJAYlZwnazE3HrzF SvNajAtxCYWSpwQT1q74WfBLYSzZv+Bn8ylGD75grqz7+ShKh70Zq+CppW6zOK6vWS7QJ+JB6yzUN 9xulcBZzWxk9I2FHGmk+RnY24ugj/5WUYifvv/kYEV4O4XxTIOjgXoB/eAF2TvlabFTsNB3BukIKU 2p3EiIYFFdAwfIj9kEku9Y3b3jC1kcNfi3MhoW+57jSkjJDDyp9+pmOCxgplf3WdWbBNZwUnVyP1G qcEkNW0Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36238) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rlDQI-0001va-2k; Fri, 15 Mar 2024 19:40:58 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rlDQG-0006dz-Ut; Fri, 15 Mar 2024 19:40:56 +0000 Date: Fri, 15 Mar 2024 19:40:56 +0000 From: "Russell King (Oracle)" To: Ayush Singh Cc: linux-kernel@vger.kernel.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Vaishnav M A , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Jiri Slaby , Johan Hovold , Alex Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [PATCH v3 2/8] w1: Add w1_find_master_device Message-ID: References: <20240315184908.500352-1-ayushdevel1325@gmail.com> <20240315184908.500352-3-ayushdevel1325@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240315184908.500352-3-ayushdevel1325@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_124120_926160_77931789 X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 16, 2024 at 12:19:00AM +0530, Ayush Singh wrote: > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index afb1cc4606c5..ce8a3f93f2ef 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -673,9 +673,9 @@ static int __w1_attach_slave_device(struct w1_slave *sl) > sl->dev.of_node = of_find_matching_node(sl->master->dev.of_node, > sl->family->of_match_table); > > - dev_set_name(&sl->dev, "%02x-%012llx", > - (unsigned int) sl->reg_num.family, > - (unsigned long long) sl->reg_num.id); > + dev_set_name(&sl->dev, "%s-%02x-%012llx", sl->master->name, > + (unsigned int)sl->reg_num.family, > + (unsigned long long)sl->reg_num.id); This is a user visible change likely to cause breakage. I know that I've written programmes for reading the DS18B20 temperature probes that depend on the sysfs device name remaining stable. The same is likely true of other program authors. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel