From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Joy Zou <joy.zou@nxp.com>,
ping.bai@nxp.com, lgirdwood@gmail.com, broonie@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v5 3/3] arm64: dts: imx93-11x11-evk: add pca9451a support
Date: Mon, 18 Mar 2024 16:02:36 -0400 [thread overview]
Message-ID: <Zfid3D7JW5HGIZVc@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <7f601f5e-98af-4a78-a3eb-04d814669973@linaro.org>
On Mon, Mar 18, 2024 at 07:50:51PM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2024 10:56, Joy Zou wrote:
> > Support pca9451a on imx93-11x11-evk.
> >
> > Signed-off-by: Joy Zou <joy.zou@nxp.com>
> > ---
> > Changes in v5:
> > 1.adjust gpio@22 to the front of pmic@25.
> >
> > Changes in v4:
> > 1. modify the comment for uSDHC but not i2c.
> >
> > Changes in v3:
> > 1. modify the voltages constraints according to the imx93 datasheet.
> > ---
> > .../boot/dts/freescale/imx93-11x11-evk.dts | 111 ++++++++++++++++++
> > 1 file changed, 111 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 9921ea13ab48..478a134d4416 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -183,6 +183,104 @@ &wdog3 {
> > status = "okay";
> > };
> >
> > +&lpi2c2 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clock-frequency = <400000>;
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&pinctrl_lpi2c2>;
> > + pinctrl-1 = <&pinctrl_lpi2c2>;
> > + status = "okay";
> > +
> > + pcal6524: gpio@22 {
> > + compatible = "nxp,pcal6524";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_pcal6524>;
> > + reg = <0x22>;
>
> reg is the second property. Please do not introduce some other coding style.
Yes, Do you know if there are any tools to check it? If no, which tools
should be good to add such check. I may add it if have free time.
Frank Li
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-18 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 9:56 [PATCH v5 0/3] add pmic pca9451a support Joy Zou
2024-03-18 9:56 ` [PATCH v5 1/3] regulator: dt-bindings: pca9450: add " Joy Zou
2024-03-18 9:56 ` [PATCH v5 2/3] regulator: " Joy Zou
2024-03-18 9:56 ` [PATCH v5 3/3] arm64: dts: imx93-11x11-evk: " Joy Zou
2024-03-18 18:35 ` Frank Li
2024-03-18 18:50 ` Krzysztof Kozlowski
2024-03-18 20:02 ` Frank Li [this message]
2024-03-19 3:20 ` [EXT] " Joy Zou
2024-03-25 17:44 ` (subset) [PATCH v5 0/3] add pmic " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfid3D7JW5HGIZVc@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).