From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6877BC54E58 for ; Wed, 20 Mar 2024 11:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ty4xK7+oAI6g8a/kV7SVoWa/CJcA4+6dKdr6wEc7cCs=; b=jR6SXVYoAirLhQ 72UiOP6oLXNguhHKc7YhyJIRvm2vLdhrklgDaXoWEEygKI7Dwu8zESX5ASkKyYl9MqALGKn0cn/YU J5DfJkYdL1MOY41UW1s0+lpih8PE/EkIq7yyP28Vu+26KnkxFK4hKTy8X/wbmZ2+avb9rCX+bpFbu 1KEcFeaIvxBvqXnHSkgR5tOZDHzZ1A/iO/AiupZ/HT0N4LLYEGmwOqjgNyFlA+2dHY6w2R85AGvWY 7Gg2mS7FuVRHcYhiAhh6kGEFOnJg3sf9t2+vajuMsVCl54JDJLy3SZcCQJq6zTobKsUZbLJrkczFf xco+vlm7798GvwlQAEDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmuCi-0000000Gz5z-0FRL; Wed, 20 Mar 2024 11:33:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmuCf-0000000Gz4x-0ANm for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2024 11:33:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 84D951007; Wed, 20 Mar 2024 04:34:26 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E002A3F762; Wed, 20 Mar 2024 04:33:50 -0700 (PDT) Date: Wed, 20 Mar 2024 11:33:48 +0000 From: Sudeep Holla To: "Peng Fan (OSS)" Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH] firmware: arm_scmi: perf: print domain name in error path Message-ID: References: <20240320074213.1615888-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240320074213.1615888-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240320_043353_140884_44C32560 X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2024 at 03:42:13PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > It would be easier to locate the problem if domain name is printed out. > And including a coding style update. > > Signed-off-by: Peng Fan > --- > drivers/firmware/arm_scmi/perf.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index 345fff167b52..e98ca6d15b0c 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -79,7 +79,7 @@ struct scmi_msg_resp_perf_domain_attributes { > __le32 rate_limit_us; > __le32 sustained_freq_khz; > __le32 sustained_perf_level; > - u8 name[SCMI_SHORT_NAME_MAX_SIZE]; > + u8 name[SCMI_SHORT_NAME_MAX_SIZE]; Spurious change ? > }; > > struct scmi_msg_perf_describe_levels { > @@ -387,8 +387,8 @@ process_response_opp(struct device *dev, struct perf_dom_info *dom, > > ret = xa_insert(&dom->opps_by_lvl, opp->perf, opp, GFP_KERNEL); > if (ret) > - dev_warn(dev, "Failed to add opps_by_lvl at %d - ret:%d\n", > - opp->perf, ret); > + dev_warn(dev, "Failed to add opps_by_lvl at %d for %s- ret:%d\n", > + opp->perf, dom->info.name, ret); > } > > static inline void > @@ -405,8 +405,8 @@ process_response_opp_v4(struct device *dev, struct perf_dom_info *dom, > > ret = xa_insert(&dom->opps_by_lvl, opp->perf, opp, GFP_KERNEL); > if (ret) > - dev_warn(dev, "Failed to add opps_by_lvl at %d - ret:%d\n", > - opp->perf, ret); > + dev_warn(dev, "Failed to add opps_by_lvl at %d for %s - ret:%d\n", > + opp->perf, dom->info.name, ret); > Are you really hitting these issues ? Or is it just code observation/improvements ? It looks good otherwise. You can also add the below change when you respin. -- Regards, Sudeep diff --git i/drivers/firmware/arm_scmi/perf.c w/drivers/firmware/arm_scmi/perf.c index 211e8e0aef2c..ef1c27a65552 100644 --- i/drivers/firmware/arm_scmi/perf.c +++ w/drivers/firmware/arm_scmi/perf.c @@ -830,7 +830,8 @@ static int scmi_dvfs_device_opps_add(const struct scmi_protocol_handle *ph, ret = dev_pm_opp_add_dynamic(dev, &data); if (ret) { - dev_warn(dev, "failed to add opp %luHz\n", freq); + dev_warn(dev, "[%d][%s]: Failed to add OPP[%d] %lu\n", + domain, dom->info.name, idx, freq); dev_pm_opp_remove_all_dynamic(dev); return ret; } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel