From: Jiri Pirko <jiri@resnulli.us>
To: Simon Horman <horms@kernel.org>
Cc: Claus Hansen Ries <chr@terma.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"michal.simek@amd.com" <michal.simek@amd.com>,
"wei.fang@nxp.com" <wei.fang@nxp.com>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"robh@kernel.org" <robh@kernel.org>,
"harini.katakam@amd.com" <harini.katakam@amd.com>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"wanghai38@huawei.com" <wanghai38@huawei.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] net: ll_temac: platform_get_resource replaced by wrong function
Date: Wed, 20 Mar 2024 17:06:16 +0100 [thread overview]
Message-ID: <ZfsJeGf0uRgKxj-W@nanopsycho> (raw)
In-Reply-To: <20240320152246.GU185808@kernel.org>
Wed, Mar 20, 2024 at 04:22:46PM CET, horms@kernel.org wrote:
>On Wed, Mar 20, 2024 at 02:19:15PM +0000, Claus Hansen Ries wrote:
>> From: Claus Hansen Ries <chr@terma.com>
>>
>> Hope I am resubmitting this correctly, I've fixed the issues in
>> the original submission.
>
>For future reference, the text above probably belongs
>below the scissors ("---"). But I don't think there
>is a need to resubmit just because of that.
Well, otherwise this will be in the git history forever :)
>
>>
>> platform_get_resource was replaced with devm_platform_ioremap_resource_byname
>> and is called using 0 as name. This eventually ends up in platform_get_resource_byname
>> in the call stack, where it causes a null pointer in strcmp.
>>
>> if (type == resource_type(r) && !strcmp(r->name, name))
>>
>> It should have been replaced with devm_platform_ioremap_resource.
>>
>> Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()")
>> Signed-off-by: Claus Hansen Ries <chr@terma.com>
>> Cc: stable@vger.kernel.org
>> ---
>> v2:
>> - fix accidently converting tabs to spaces and wording in commit message
>> v1: https://marc.info/?l=linux-netdev&m=171087828129633&w=2
>
>Thanks,
>
>Reviewed-by: Simon Horman <horms@kernel.org>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-20 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 14:19 [PATCH net v2] net: ll_temac: platform_get_resource replaced by wrong function Claus Hansen Ries
2024-03-20 15:22 ` Simon Horman
2024-03-20 16:06 ` Jiri Pirko [this message]
2024-03-21 12:51 ` Paolo Abeni
2024-03-21 13:08 ` [PATCH net v3] " Claus Hansen Ries
2024-03-26 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfsJeGf0uRgKxj-W@nanopsycho \
--to=jiri@resnulli.us \
--cc=chr@terma.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=harini.katakam@amd.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wanghai38@huawei.com \
--cc=wei.fang@nxp.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).