From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7F3FC54E58 for ; Wed, 20 Mar 2024 16:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K0FSUpXRj1rqqIoNcl4SoIhloSuQN7XkZgrJDbr4uCU=; b=VStqoY+JlR7K8W uarUoOhIM1sLMCAMoviq/3KXXOdMl7ArEmbXh85OQdT4cN0Gq9yEemCbTkZS3M5vXIhyc+PzUa0Lz hQFuLakrqSnN/wSRtwfhtbzXVXjOhmau98sNy064Oo+cg1xkytZ6yyX6TqDLH/HIjF/sv9LvlWVgR 3w9si8tRCEj205O1cLXoMwOddJOhDEPKWBU829KF0JiN+G97mcpRFefyHP8c+Bwc9R9gwqCP9YooU 9+TyZmI1LJKQuGFyghSbfWWAESEqXmXY6CqdPx2vUOj/PKEXGUcKU0vbdqEnj1SP/34FU8Gwyyw4M PA2qVB9rbHHTJp8vVW+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmySP-00000000DwY-2c9X; Wed, 20 Mar 2024 16:06:25 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmySL-00000000DvE-2Nrw for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2024 16:06:23 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-33e1d327595so4610082f8f.2 for ; Wed, 20 Mar 2024 09:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1710950778; x=1711555578; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v8jmgWz3VAY8ZzreiulUbSiKLh7pUnFJyujK1sVIPS0=; b=iOLDB1c5uosZpDRYooUAjMRd8KPIQ791A20wjzAmbwClR/clMLm82KrAEogZrhXHSo 4EwyCA0v/dhVC3xSaVCxKEbiljH3hz9s12+y/5jIUJbBpiCEDiRgRbe8s8QxXrALS3in DpQt+cxHe+Q1B4mbnua23fqfWqehLCmahbU0ZXjnX7X8Xc1wG7Vtgh1dIj9CdH+cGWUJ DA7iE1RqrMcollzkixcnT5VA+nB8b7lYWU+elXZGCEgcAFm/N2h9p31jB6gjnQfAQ5XB a6lZANZAkm5P7ulF/DFU6nVa2a3YwNtRg7XaXAA6CYvpc2rTHIWIDaADWXD4VVJ2ro0+ zthA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710950778; x=1711555578; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v8jmgWz3VAY8ZzreiulUbSiKLh7pUnFJyujK1sVIPS0=; b=lLE36OCkTs0xEVJ3o5b+gYbPfbu8MFhEfTSQ+f/2R9aXVSNYF/bhJDsj0RLpJv5EJF mpWoDhOi9Hw3ZTE8AWeZtV8SbpQBGhKRBV/eC1tH099pz4L1/p5Pyte3BgmlYvaW5b61 cP1OiUWGpNjgA/sc/We3x6m49GF8UKHGIeptoEbA3wffpidLeKunL2U1Fax2wqVewvqi u3cW4Rny43wsnx7rwqTvksuoWsBPkBFyljwiyTkMxKw7NIJQRmsem3WwFdj5W4c4ZTHG wRHY/21HEA+/YVxp7vZZb6UedOYNGw4QIPldKtPXmWrziw9fHLbRyCbnsuJzLJ6AVJu0 iDBg== X-Forwarded-Encrypted: i=1; AJvYcCWMAKV3YaIKOhVmsVkZV9w9+mCKDQCkqfcsfmw1ODOgtbJBN/r1jwYkQ3a0rlcvYJR9slIDHDHHv7qnmNSg3gYtPzfVGWRgrwe+6E+FoNw7wXYEX4E= X-Gm-Message-State: AOJu0YwKSTARR8s+NlSMbTVHa4ieX2+UGu/eU0OY5cZkMcT2ew+RrE1E TaHminYMkySQm7fkqL/2XQDBgEKJzUFpfr1n4Pm5SRdp/6Wzge4hkeKlqEYtYXI= X-Google-Smtp-Source: AGHT+IETNVMK8m1jhOjqYEXAI9aTcnCW2E/0idMKApIbeQQjKSCih1HznLYl7yI8UjVpUVh5TwQcZQ== X-Received: by 2002:a05:6000:ad2:b0:33e:c7e2:2b64 with SMTP id di18-20020a0560000ad200b0033ec7e22b64mr11376760wrb.42.1710950778011; Wed, 20 Mar 2024 09:06:18 -0700 (PDT) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id o9-20020adfe809000000b0033ec6ebf878sm14939300wrm.93.2024.03.20.09.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 09:06:17 -0700 (PDT) Date: Wed, 20 Mar 2024 17:06:16 +0100 From: Jiri Pirko To: Simon Horman Cc: Claus Hansen Ries , "netdev@vger.kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "michal.simek@amd.com" , "wei.fang@nxp.com" , "yangyingliang@huawei.com" , "robh@kernel.org" , "harini.katakam@amd.com" , "dan.carpenter@linaro.org" , "u.kleine-koenig@pengutronix.de" , "wanghai38@huawei.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net v2] net: ll_temac: platform_get_resource replaced by wrong function Message-ID: References: <20240320152246.GU185808@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240320152246.GU185808@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240320_090621_657641_C0F767F9 X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wed, Mar 20, 2024 at 04:22:46PM CET, horms@kernel.org wrote: >On Wed, Mar 20, 2024 at 02:19:15PM +0000, Claus Hansen Ries wrote: >> From: Claus Hansen Ries >> >> Hope I am resubmitting this correctly, I've fixed the issues in >> the original submission. > >For future reference, the text above probably belongs >below the scissors ("---"). But I don't think there >is a need to resubmit just because of that. Well, otherwise this will be in the git history forever :) > >> >> platform_get_resource was replaced with devm_platform_ioremap_resource_byname >> and is called using 0 as name. This eventually ends up in platform_get_resource_byname >> in the call stack, where it causes a null pointer in strcmp. >> >> if (type == resource_type(r) && !strcmp(r->name, name)) >> >> It should have been replaced with devm_platform_ioremap_resource. >> >> Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()") >> Signed-off-by: Claus Hansen Ries >> Cc: stable@vger.kernel.org >> --- >> v2: >> - fix accidently converting tabs to spaces and wording in commit message >> v1: https://marc.info/?l=linux-netdev&m=171087828129633&w=2 > >Thanks, > >Reviewed-by: Simon Horman > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel