From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EB9FC54E58 for ; Thu, 21 Mar 2024 13:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2AuC4H820bXr5mZcxVd2YJohjV6XZpD03LuI5PTF8rs=; b=HtHt11xs3EBzQO wPGbk9A3TGJX0ytHcvg/3cBmqfw9ROp23IiOzCMs+Hj0NpX6VqR5wKst9vJzpRPgsQ3UrLcOWRWd2 h/fIpdlT9ZvtCgi93xndCKd88oL7qoL4q1ITGlOc0ko7mqQiMIQzI7TU1ezrwrNHI8uhtwhaL7jtm 205yhy0nRtSwKGt9MytoUUoeVPK05ZFULIS137Z7klL/Wg5cx47Nr/6b/4g+2lfhJFfO/z0UMmZL8 8WdEiNXuKs70huLstP6S8HaJEbtTlFLQo0ZEfYxJgPmjiRBvEU5dArU9FLZbhlBOaUh/zKmdaKwbJ KmGuF0SCRVmfsrlapmaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnIA8-0000000345T-2NZT; Thu, 21 Mar 2024 13:08:52 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnIA6-0000000342v-0B29 for linux-arm-kernel@lists.infradead.org; Thu, 21 Mar 2024 13:08:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PeWMjzv2TCP5O1EIfymN2AlFHQvzJcY+97La6mMNs54=; b=bq3le8SHCA9RGKtRjoQT80Yt+r GAIPSfvVky9RjIb3Jj6jCkxsr54sQBXpDnitSmwOcVhkDXEcZK7iXBPmTzELNxCtRU3Vna8xkgRzH VzC9PZx2c0580S3Ilj4czYH2iklxaE1QrI3ge/k08tld8peE+ZQy1PAa5ggPZ7Rv1NEnUXK9bNxX/ ZpkNxepK5BDc6i0hD5OnbzzCwQn3UMPFIYJR2uNhCtYtNOhPACtZPiKqzywCz5Fp75hED7U6OkODN v3+FJbVe6G2ys8Z01T/dpSdLUaBrzBeQhu33cane2Z8qXzEP/ak8sBIFxtiPwDsTdilrD6PVtwRC9 C1LYOZhg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42380) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rnI9R-0007a9-10; Thu, 21 Mar 2024 13:08:09 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rnI9K-0003fA-VJ; Thu, 21 Mar 2024 13:08:03 +0000 Date: Thu, 21 Mar 2024 13:08:02 +0000 From: "Russell King (Oracle)" To: David Laight Cc: Ard Biesheuvel , 'Jiangfeng Xiao' , "arnd@arndb.de" , "keescook@chromium.org" , "haibo.li@mediatek.com" , "angelogioacchino.delregno@collabora.com" , "amergnat@baylibre.com" , "akpm@linux-foundation.org" , "dave.hansen@linux.intel.com" , "douzhaolei@huawei.com" , "gustavoars@kernel.org" , "jpoimboe@kernel.org" , "kepler.chenxin@huawei.com" , "kirill.shutemov@linux.intel.com" , "linux-hardening@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , "nixiaoming@huawei.com" , "peterz@infradead.org" , "wangbing6@huawei.com" , "wangfangpeng1@huawei.com" , "jannh@google.com" , "willy@infradead.org" Subject: Re: [PATCH v2] ARM: unwind: improve unwinders for noreturn case Message-ID: References: <1710906278-23851-1-git-send-email-xiaojiangfeng@huawei.com> <84a57ca8-8963-ca24-8bd1-ddc5c33bf4da@huawei.com> <0fd55e156195440bb1d815dd8300894b@AcuMS.aculab.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0fd55e156195440bb1d815dd8300894b@AcuMS.aculab.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240321_060850_111530_29D04381 X-CRM114-Status: GOOD ( 24.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 21, 2024 at 12:57:07PM +0000, David Laight wrote: > From: Russell King > > Sent: 21 March 2024 12:23 > ... > > > That might mean you can get the BL in the middle of a function > > > but where the following instruction is for the 'no stack frame' > > > side of the branch. > > > That is very likely to break any stack offset calculations. > > > > No it can't. At any one point in the function, the stack has to be in > > a well defined state, so that access to local variables can work, and > > also the stack can be correctly unwound. If there exists a point in > > the function body which can be reached where the stack could be in two > > different states, then the stack can't be restored to the parent > > context. > > Actually you can get there with a function that has a lot of args. > So you can have: > if (...) { > push x > bl func > add %sp, #8 > } > code; > which is fine. No you can't.... and that isn't even Arm code. Arm doesn't use %sp. Moreover, that "bl" will stomp over the link register, meaning this function can not return. > But if 'func' is 'noreturn' then the 'add %sp, #8' can be discarded > and then the saved LR is that of 'code' - but the stack offset is wrong. If func is noreturn, then the remainder of that path isn't expected to be executed, so anything that happens after the "bl" is irrelevant. > A PC from LR will always be the next instruction. > It is only the PC from a fault frame that is the current one. That sentence makes no sense to me, as I don't think it's even proper English, so I can't parse it. > The unwinder probably need to be told which one it has. > (Or add 4 the fault frame PC so that the unwinder can subtract > 4 from it.) That's basically what I said. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel