From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6525ECD128A for ; Wed, 3 Apr 2024 10:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GuQD58WU8ALu0IspHXlwQM/o2Q0eoGgFbhcyEC9mS0c=; b=HWgx8u+6nvVCAt 8It5u9sg/r+O6efNLlTr6Xhj3bjL4MHszfsSXupazPpHiT+yZxq4OMC3xITOqmTbrGVO+a17yGeub MTN8/nWmlfzo9E9jBQMUrggoWkZkdyF1SNJfM9kzWrF//+J7wXfZLaN0Mw6DCMsTCdt7eVkTDaZQb zJO53+MO31Onvlg4k9lfEmx/3kQXIX8xhlakDQK2pybea02FXvTifkiqu4nLhvBUDlkp3V8qUJwZG 3sssf4AkJ33MpcHO0FxNVxSjWDuRLvjhon9yqa11T0U5xpMRf2uSo5cLJH41QatqZF+q8KczQjtWt bifMcyLICpxJsu4ECyDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrxTC-0000000FMra-2Uv7; Wed, 03 Apr 2024 10:03:50 +0000 Received: from mgamail.intel.com ([198.175.65.16]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrxT8-0000000FMop-0q6M for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 10:03:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712138626; x=1743674626; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fXRjjaGZV7ZIRS20aHDdphwu1uV0+rRzTuIeMRTW/fM=; b=OpjVm7li6v/6wyYNmxYLJh5qd+be/6grHPbssp9USiHpGq+muWTAEBL3 em2tnpK7s/qJfHWs7JySnEwSkmIZO7H1ah3qCTbUnJzcEKxJcoTKwjFl2 WK8t9DquG70ObDEQe5M9iZlPPAy927+1/8Z5W8Nu2g0ur05H731qCnHTR 68tL1K4aHdD64mumtTegmqqacM2ludC8xJ4Juihx9XBxZJBystZtZP++k zYCGC1Q0NHuEbbUVe5Bj/RydzlBjDHEJ1bhstka7xroxrCoU2t81meDxz TpRCrgz1GChn/9Mg/0nJGfmMaO720PXrJ2BevBl0tQMHp/Jqb7PKymmpz g==; X-CSE-ConnectionGUID: i/L5t2hQS+67Vh74XJOeMQ== X-CSE-MsgGUID: Hn7SNYP4Q2uywVD8tE3PSg== X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="7485424" X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="7485424" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 03:03:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="915177185" X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="915177185" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 03:03:41 -0700 Received: from andy by smile with local (Exim 4.97) (envelope-from ) id 1rrxT1-000000015GN-0Djh; Wed, 03 Apr 2024 13:03:39 +0300 Date: Wed, 3 Apr 2024 13:03:38 +0300 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/34] Input: stmpe-ts - mark OF related data as maybe unused Message-ID: References: <20240403080702.3509288-1-arnd@kernel.org> <20240403080702.3509288-8-arnd@kernel.org> <614fc80a-5d2a-43a1-b8d4-48bdb2cc7dc7@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <614fc80a-5d2a-43a1-b8d4-48bdb2cc7dc7@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_030346_444250_708B6D6F X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2024 at 11:52:12AM +0200, Krzysztof Kozlowski wrote: > On 03/04/2024 11:40, Andy Shevchenko wrote: > > On Wed, Apr 03, 2024 at 10:06:25AM +0200, Arnd Bergmann wrote: ... > >> -static const struct of_device_id stmpe_ts_ids[] = { > >> +static const struct of_device_id stmpe_ts_ids[] __maybe_unused = { > > > > __maybe_unused? > > > > Why not adding it into .driver as you have done in another patch in this series? > > Because there is no benefit in this. This is instantiated by MFD, so the > only thing you need is entry for module loading. Hmm... Seems to me rather a good candidate for MODULE_ALIAS in this case. No? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel