Re: [PATCH v2 00/10] perf: Avoid placing cpumask var on stack

Yury Norov
2024-04-03T16:39:21Z

On Thu, Apr 04, 2024 at 12:11:51AM +0800, Dawei Li wrote:
> Hi Mark,
>
> On Wed, Apr 03, 2024 at 03:41:07PM +0100, Mark Rutland wrote:
> > On Wed, Apr 03, 2024 at 08:50:59PM +0800, Dawei Li wrote:
> > > Hi all,
> >
> > Hi,
> >
> > > This is v2 of [1] and [2] which basically eliminate cpumask var allocation
> > > on stack for perf subsystem.
> > >
> > > Change since v1:
> > > - Change from dynamic allocation to a temporary var free helper:
> > > cpumask_any_and_but(). [Mark]
> > >
> > > - Some minor coding style improvements, reverse chrismas tree e.g.
> > >
> > > - For cpumask_any_and_but() itself:
> > > - Moved to cpumask.h, just like other helpers.
> > > - Return value converted to unsigned int.
> > > - Remove EXPORT_SYMBOL, for obvious reason.
> >
> > Thanks for this!
> >
> > The logic all looks good; if you can spin a v3 with the updated commit messages
> > I reckon we can queue this up shortly.
>
> Thanks for review.
>
> v3 respinned:
> https://lore.kernel.org/lkml/20240403155950.2068109-1-dawei.li@shingroup.cn/
>
> If it's going through perf tree, do we need Acked-by from bitmap
> maintainers for patch[1]?

There's only one bitmap-related patch, so I agree - the series should
go through Mark's tree. I acked 1st patch in v3. Please go ahead.

Thanks,
Yury