From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35D45CD128A for ; Wed, 3 Apr 2024 14:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xugFFVuHNooHKZcyCCKzygRqEnF/TZuoye4gTAFZcp0=; b=Hg83DwPvJ0tbWF 1F7RolNXhvAO+xlMS08iXaPg2LS1JPRLErULpxEgKrEVxBI8a5teCFXvalT+T9IZQwIlzkbuwA1Ja peZgf081iiyKtr49Hp1FgJ14FfFlXIaPORVxsI9Dh1JMFGVkOujTtEsW+1Yr+aPe/Ipgxhe29y47a VtvIPX5SS3aVnatHyGMXoOC9Y+w1stbR+0O5/ggGctbCDIcgPkjFEDvHn2f1nCHmGnPqsvhEogIME xqMXEB9hJwHTKrTZ0Gebwn3XrJtoCuirlob9jNIeWV8adGabtWJ81sv61SGaZlx1lZrp3uOcuy8pD 1G9HqESM9yiTHX03sNFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs1nj-0000000GWmQ-1kn0; Wed, 03 Apr 2024 14:41:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs1ng-0000000GWlm-3962 for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 14:41:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66D171007; Wed, 3 Apr 2024 07:41:43 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.16.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C8713F7B4; Wed, 3 Apr 2024 07:41:10 -0700 (PDT) Date: Wed, 3 Apr 2024 15:41:07 +0100 From: Mark Rutland To: Dawei Li Cc: will@kernel.org, yury.norov@gmail.com, linux@rasmusvillemoes.dk, xueshuai@linux.alibaba.com, renyu.zj@linux.alibaba.com, yangyicong@hisilicon.com, jonathan.cameron@huawei.com, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 00/10] perf: Avoid placing cpumask var on stack Message-ID: References: <20240403125109.2054881-1-dawei.li@shingroup.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403125109.2054881-1-dawei.li@shingroup.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_074116_966774_DD1830DC X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2024 at 08:50:59PM +0800, Dawei Li wrote: > Hi all, Hi, > This is v2 of [1] and [2] which basically eliminate cpumask var allocation > on stack for perf subsystem. > > Change since v1: > - Change from dynamic allocation to a temporary var free helper: > cpumask_any_and_but(). [Mark] > > - Some minor coding style improvements, reverse chrismas tree e.g. > > - For cpumask_any_and_but() itself: > - Moved to cpumask.h, just like other helpers. > - Return value converted to unsigned int. > - Remove EXPORT_SYMBOL, for obvious reason. Thanks for this! The logic all looks good; if you can spin a v3 with the updated commit messages I reckon we can queue this up shortly. Mark. > > [1]: > https://lore.kernel.org/lkml/20240402105610.1695644-1-dawei.li@shingroup.cn/ > > [2]: > https://lore.kernel.org/lkml/1486381132-5610-1-git-send-email-mark.rutland@arm.com/ > > Dawei Li (9): > perf/alibaba_uncore_drw: Avoid placing cpumask var on stack > perf/arm-cmn: Avoid placing cpumask var on stack > perf/arm_cspmu: Avoid placing cpumask var on stack > perf/arm_dsu: Avoid placing cpumask var on stack > perf/dwc_pcie: Avoid placing cpumask var on stack > perf/hisi_pcie: Avoid placing cpumask var on stack > perf/hisi_uncore: Avoid placing cpumask var on stack > perf/qcom_l2: Avoid placing cpumask var on stack > perf/thunderx2: Avoid placing cpumask var on stack > > Mark Rutland (1): > cpumask: add cpumask_any_and_but() > > drivers/perf/alibaba_uncore_drw_pmu.c | 10 +++------- > drivers/perf/arm-cmn.c | 10 +++++----- > drivers/perf/arm_cspmu/arm_cspmu.c | 8 +++----- > drivers/perf/arm_dsu_pmu.c | 19 ++++++------------- > drivers/perf/dwc_pcie_pmu.c | 10 ++++------ > drivers/perf/hisilicon/hisi_pcie_pmu.c | 9 ++++----- > drivers/perf/hisilicon/hisi_uncore_pmu.c | 6 ++---- > drivers/perf/qcom_l2_pmu.c | 8 +++----- > drivers/perf/thunderx2_pmu.c | 10 +++------- > include/linux/cpumask.h | 23 +++++++++++++++++++++++ > 10 files changed, 56 insertions(+), 57 deletions(-) > > Thanks, > > Dawei > > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel