From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F8C4CD128A for ; Wed, 3 Apr 2024 16:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VvRlME2grMBLufe91c6kJKAhuFBD/Rc/U79O8wtc/Mo=; b=h6DusupSGhdxUY dyzlB/Gql2Hg/73MLf/sIhem0gKUAJKNZnfakEIeWPys+Grx4Rg+lT5gLyVZPK7phGA6e4zQkqwg5 TcO09OriU+xJTW2bI9zl3r/ef2fhuJZkDzhMLV7SLFuj9rJgv8Brbc+FaqrT3KjM+hypOFOFI5lPq Eg4ImNP27TjwMm97S2MJmcHtVnoNIrmXYEJgZFEND3HN+QIpXBXPgCGNaYWx2ni8gMUFu9Z09zhnD JVwYb4WiRyXMFl3Gp0nC+BTulpgmZqQrQN6BvhESjl6OV50EDyvU8HDdgyaFoFPqtbNUBgYcQmSJS pl8Cqk1e9F4te5QoqGUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs3R1-0000000Gxds-3Vuc; Wed, 03 Apr 2024 16:25:59 +0000 Received: from mgamail.intel.com ([192.198.163.12]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs3Qy-0000000GxcJ-28d9 for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 16:25:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712161556; x=1743697556; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JMCBB+N9+FM9hPmjmm5AAROCcok9dIVw6il7pADCYVc=; b=GPY9OJwcuDboXThs+GDaIJn5aHA/vw0CWvnSidAgfAU6FMxzNfSWCmsy ZgwpqSBnatVs6ppa4FLV1nYchXgiMnIurDOVKJwApQp47uGDXnm9XIR+7 tmNXvT5C8z5cSlos1QFUcnRuyj1Bp8Z/Chf26+wekBcaaPFBphoVHyl03 9txJLe89YwrTfJTjl3m8HEhMscw+cgTbyzsyNPI2rhLq1U36jC1IeKDHQ VhlRzD+6KiwnrT0WD2XPDbnw4gdY3vKe+cqknC52qz9i3/KE8VJXVp2kQ bJ4aCypsJZnl6BT/U5PbMIWoGCE4YJ3v97rgRRrXMfG0TMEZWsZV40Pjv A==; X-CSE-ConnectionGUID: Yr7E4XlIRTaZjaEIR2Ox4A== X-CSE-MsgGUID: r7kws1fwTJ+sUnebMyX6Zw== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="11184809" X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="11184809" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 09:25:49 -0700 X-CSE-ConnectionGUID: 86lZB59dQ9SiXD5HsxZ5yw== X-CSE-MsgGUID: 8XLS/jgPQ++ZeivpXNauUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="18468376" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 09:25:45 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 96D8611F811; Wed, 3 Apr 2024 19:25:41 +0300 (EEST) Date: Wed, 3 Apr 2024 16:25:41 +0000 From: Sakari Ailus To: git@luigi311.com Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Ondrej Jirman Subject: Re: [PATCH v3 23/25] drivers: media: i2c: imx258: Add support for powerdown gpio Message-ID: References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-24-git@luigi311.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403150355.189229-24-git@luigi311.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_092556_608539_68C96BA5 X-CRM114-Status: GOOD ( 20.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Luis, Ondrej, On Wed, Apr 03, 2024 at 09:03:52AM -0600, git@luigi311.com wrote: > From: Luis Garcia > > On some boards powerdown signal needs to be deasserted for this > sensor to be enabled. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Luis Garcia > --- > drivers/media/i2c/imx258.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c > index 30352c33f63c..163f04f6f954 100644 > --- a/drivers/media/i2c/imx258.c > +++ b/drivers/media/i2c/imx258.c > @@ -679,6 +679,8 @@ struct imx258 { > unsigned int lane_mode_idx; > unsigned int csi2_flags; > > + struct gpio_desc *powerdown_gpio; > + > /* > * Mutex for serialized access: > * Protect sensor module set pad format and start/stop streaming safely. > @@ -1213,6 +1215,8 @@ static int imx258_power_on(struct device *dev) > struct imx258 *imx258 = to_imx258(sd); > int ret; > > + gpiod_set_value_cansleep(imx258->powerdown_gpio, 0); What does the spec say? Should this really happen before switching on the supplies below? > + > ret = regulator_bulk_enable(IMX258_NUM_SUPPLIES, > imx258->supplies); > if (ret) { > @@ -1224,6 +1228,7 @@ static int imx258_power_on(struct device *dev) > ret = clk_prepare_enable(imx258->clk); > if (ret) { > dev_err(dev, "failed to enable clock\n"); > + gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); > regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); > } > > @@ -1238,6 +1243,8 @@ static int imx258_power_off(struct device *dev) > clk_disable_unprepare(imx258->clk); > regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); > > + gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); > + > return 0; > } > > @@ -1541,6 +1548,12 @@ static int imx258_probe(struct i2c_client *client) > if (!imx258->variant_cfg) > imx258->variant_cfg = &imx258_cfg; > > + /* request optional power down pin */ > + imx258->powerdown_gpio = devm_gpiod_get_optional(&client->dev, "powerdown", > + GPIOD_OUT_HIGH); > + if (IS_ERR(imx258->powerdown_gpio)) > + return PTR_ERR(imx258->powerdown_gpio); > + > /* Initialize subdev */ > v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops); > -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel