From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA293CD1288 for ; Wed, 3 Apr 2024 16:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WA+k1LAm+LdMD1H61oaraOLwWe+akzPE15fAQFM4GrI=; b=2YQ2mOKuDAadOA UxDl/uf58+nbDcc+rDYo4uudVWEOQYyRUTD/dGaVqzGZCtNumtPu/xc9Xx7JQa2SFKuWoCDAdLTF4 v03gaBVr53m41BSKf1ry3sqe9Ascd6JdHpwRBgq8j/31IrAdiOOFWx2A1DxhDgRJy+9fe1KRVMYzh Xv16LbBonGuuXHATMu37xkdudf2WLa+NESdNgI6ygtwS0Vq9eQgFpk1a6GT5z5lVjpnFsRRNrlinx pQYtqz24YNn4kGDqEYHWBZie2DAuabVy6IJ2PEI9l7Pkg3tHIs3kwz6G/9zv7SLX2SOgoS1yF1zSF IPtnDclspkRB/50kIsCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs3U7-0000000GyJH-0w5C; Wed, 03 Apr 2024 16:29:11 +0000 Received: from mgamail.intel.com ([192.198.163.8]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs3U2-0000000GyG8-3Y39 for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 16:29:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712161746; x=1743697746; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mhuKbmAv0FK32oWKE8zDOqzcjDgwcdmOI00I9TTS6DI=; b=nB6WncOCdoRIuSwbsy6I5dC1iHkLY/Rcj7WO522/HZZ3J+e1IM3wE6Z0 Pveikps4kDrMhQGcvH3dKtPfJ37K/YNz74b0STf80jAQ85Sdv2VLyELGq GowYFtnGIlObGf/ORoAOqxelRR12lathtxfXG5tTHDSvb20bPk3JkDBO7 5tBg3JOU3aZ4WWN+pC/h0p55TyL5yjMieenGLhle/ORv/VzGOL6kNfdrS SA/4yWbRcG1JDutu5znIW9d+yOvDLMAZzpPYAYnQu8yNnFDkGYZOR+8s6 d3PKzDpVixmfknO3wB/SD7HLhHQsp5jMAVcFygvAn40kncSRbfbfMINPi Q==; X-CSE-ConnectionGUID: QhCX0VsVR6G/KSg4XP74vQ== X-CSE-MsgGUID: Zaa09bC1STyex4TIanBx3g== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="24912192" X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="24912192" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 09:29:05 -0700 X-CSE-ConnectionGUID: m6ew5ttxTs6sDcZnFGoCRQ== X-CSE-MsgGUID: lf/Y9co2QV+RE2aMxcSKCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="18419481" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 09:29:02 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 7BCC311F811; Wed, 3 Apr 2024 19:28:59 +0300 (EEST) Date: Wed, 3 Apr 2024 16:28:59 +0000 From: Sakari Ailus To: git@luigi311.com Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Ondrej Jirman Subject: Re: [PATCH v3 24/25] drivers: media: i2c: imx258: Add support for reset gpio Message-ID: References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-25-git@luigi311.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403150355.189229-25-git@luigi311.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_092906_941773_581F0510 X-CRM114-Status: GOOD ( 21.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Luis, Could you unify the subject prefix for the driver patches, please? E.g. "media: imx258: " would be fine. On Wed, Apr 03, 2024 at 09:03:53AM -0600, git@luigi311.com wrote: > From: Luis Garcia > > It was documented in DT, but not implemented. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Luis Garcia > --- > drivers/media/i2c/imx258.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c > index 163f04f6f954..4c117c4829f1 100644 > --- a/drivers/media/i2c/imx258.c > +++ b/drivers/media/i2c/imx258.c > @@ -680,6 +680,7 @@ struct imx258 { > unsigned int csi2_flags; > > struct gpio_desc *powerdown_gpio; > + struct gpio_desc *reset_gpio; > > /* > * Mutex for serialized access: > @@ -1232,7 +1233,11 @@ static int imx258_power_on(struct device *dev) > regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); > } > > - return ret; > + gpiod_set_value_cansleep(imx258->reset_gpio, 0); > + > + usleep_range(400, 500); You could mention this at least in the commit message. > + > + return 0; > } > > static int imx258_power_off(struct device *dev) > @@ -1243,6 +1248,7 @@ static int imx258_power_off(struct device *dev) > clk_disable_unprepare(imx258->clk); > regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); > > + gpiod_set_value_cansleep(imx258->reset_gpio, 1); Same question than on the other GPIO: does this belong here? > gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); > > return 0; > @@ -1554,6 +1560,12 @@ static int imx258_probe(struct i2c_client *client) > if (IS_ERR(imx258->powerdown_gpio)) > return PTR_ERR(imx258->powerdown_gpio); > > + /* request optional reset pin */ > + imx258->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", > + GPIOD_OUT_HIGH); > + if (IS_ERR(imx258->reset_gpio)) > + return PTR_ERR(imx258->reset_gpio); > + > /* Initialize subdev */ > v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops); > -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel