From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62C6ECD1288 for ; Wed, 3 Apr 2024 16:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6w+5cBBE/7tIlCITDTBjYjtLhQfy+9RFIlloVV4BSRc=; b=rbDqLfIg5o5rSY cMJDgNYHemVyIwEUAKF3tfrG4N3Y7awOFkheUluRVCWQCzdNnK3oOOEtlN7ukzRsmZ3otXQl8JHMB cjYQrWdzURP9EFvWGPFP5Fnp4W1SNAIF3cL5iw60yHrTSoq/H+ji5rqI/yvopFoYv6a+5GFRx8aqU x4TdEokLKP4RWd9jCzEiSqgHoCGvkB8LZbB87kch84ajaHMfgMeRFS7G6/K6aYBcBeo3c3FyvrJNP z9nSNMnzKMOv2fpfLDYtgoxeC4S/vmUUcJL0MccNSAS/IDcpreYHT4quMvDWFUTYKt4aPfE/lFhXZ 41zNgyD50O0YutRTF0Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs3dn-0000000H0Dw-361T; Wed, 03 Apr 2024 16:39:11 +0000 Received: from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs3di-0000000H0DE-40r3 for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 16:39:09 +0000 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-61545a0280dso703477b3.0 for ; Wed, 03 Apr 2024 09:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712162344; x=1712767144; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xiQAnoqBtNMPeYbXhP6YbiPb7pzyLlVXR6yIGlyZoxw=; b=HuYr/jTk7/5dHmu/q4uX+bfFm4iT02FPewLf7OedSvrEexl9FixZnS/bUSTRtnQf7l m4OdRipCz9Qm0WB2UouxnPKQO9Ravc2DHLDGniB9xCyMCE0/zylEcUBiwn/WVTZ5uVVp +oYi1tB1i7QtTIsGmvNoZ2Q6GAFOtdj5K0ulWPHksv38ZbxAR39TrFVSufdAIfR8I7lK q71/rzO6vlvyy2XP7hVrkxDUSidTmtUYiTFgNRG2Ckh0QG1ka0wlNgy/qcE/uldsMeNj B4ywwRs3PUG/EXS2hwP12ncyIWTEkJk6MRSx21B0JURsrpoE0uAY4NU5D9Y7vnsW9WD6 F9jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712162344; x=1712767144; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xiQAnoqBtNMPeYbXhP6YbiPb7pzyLlVXR6yIGlyZoxw=; b=A4jHKjgFNptM5xhTPYQ4RQAAZQEQTd6zz43OqEP/kEEX4RXFJ0JxeuGMeGnyzLBBYj NRslat5Ycml++JSlWBuJE+9nJd/yOigdhcGnwhjdgwI9sa7EYuTk+1Bgrwz8ilVOX3RG 7CwKuKw6zqj3gcMjzVJ3FtRIHltdudzILR1GkWrXhq/VuYZkmrA4R75NMJmsW64jw9Hj n3e6JP3D9jAJEl0ncyV30RfqW2Z0iQ6YTyRXr1tJ4mKQVGAZXRQUT6WeVxhqGZNbQVdN +Zlxc0aUaMo61CslZuIl3lwHufUh5cqojoACP+iP/T/kslKO02WbOM4rTuwylnp61RC8 +3zg== X-Forwarded-Encrypted: i=1; AJvYcCUACw1+q0U/SbqZ4jV8vqniTpKPuW4HSwK9nM8Oz6ys9j1B7rxmV4a5iK3INHOJpm3r+zCpCNptIpUkTVOTs6yQ4XJjy6g/sxmV5nJpsiPNEB5gjK4= X-Gm-Message-State: AOJu0YxTYmmDXVlW/6ZdHKVyhM2St9MZtVfgjQ7IZF+LJulRgWPDPEMQ Sp/idSP0lW4iFIj8in323XhMy9YCk7uJDx66ltASYddmTdzQjNET X-Google-Smtp-Source: AGHT+IEayt2KU+YUNlfHvnp9fdUlFxEUvZ1E9Dnu+VFBi44KnDiK0FddM7x7AwhX2siDCFp/NXRJXw== X-Received: by 2002:a81:6054:0:b0:615:1860:551 with SMTP id u81-20020a816054000000b0061518600551mr3174145ywb.30.1712162344022; Wed, 03 Apr 2024 09:39:04 -0700 (PDT) Received: from localhost ([2601:344:8301:57f0:e71b:60d3:a7cd:425b]) by smtp.gmail.com with ESMTPSA id u68-20020a818447000000b006150c4478a5sm1227398ywf.102.2024.04.03.09.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 09:39:03 -0700 (PDT) Date: Wed, 3 Apr 2024 09:39:01 -0700 From: Yury Norov To: Dawei Li Cc: Mark Rutland , will@kernel.org, linux@rasmusvillemoes.dk, xueshuai@linux.alibaba.com, renyu.zj@linux.alibaba.com, yangyicong@hisilicon.com, jonathan.cameron@huawei.com, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 00/10] perf: Avoid placing cpumask var on stack Message-ID: References: <20240403125109.2054881-1-dawei.li@shingroup.cn> <5BCB924A8FA6320A+Zg1/xw9C493rZ868@centos8> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5BCB924A8FA6320A+Zg1/xw9C493rZ868@centos8> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_093907_102254_DBFB543B X-CRM114-Status: GOOD ( 20.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2024 at 12:11:51AM +0800, Dawei Li wrote: > Hi Mark, > > On Wed, Apr 03, 2024 at 03:41:07PM +0100, Mark Rutland wrote: > > On Wed, Apr 03, 2024 at 08:50:59PM +0800, Dawei Li wrote: > > > Hi all, > > > > Hi, > > > > > This is v2 of [1] and [2] which basically eliminate cpumask var allocation > > > on stack for perf subsystem. > > > > > > Change since v1: > > > - Change from dynamic allocation to a temporary var free helper: > > > cpumask_any_and_but(). [Mark] > > > > > > - Some minor coding style improvements, reverse chrismas tree e.g. > > > > > > - For cpumask_any_and_but() itself: > > > - Moved to cpumask.h, just like other helpers. > > > - Return value converted to unsigned int. > > > - Remove EXPORT_SYMBOL, for obvious reason. > > > > Thanks for this! > > > > The logic all looks good; if you can spin a v3 with the updated commit messages > > I reckon we can queue this up shortly. > > Thanks for review. > > v3 respinned: > https://lore.kernel.org/lkml/20240403155950.2068109-1-dawei.li@shingroup.cn/ > > If it's going through perf tree, do we need Acked-by from bitmap > maintainers for patch[1]? There's only one bitmap-related patch, so I agree - the series should go through Mark's tree. I acked 1st patch in v3. Please go ahead. Thanks, Yury _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel