From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D17C3CD1284 for ; Thu, 4 Apr 2024 08:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RJbX4k0CO/2KVE1q9gIBoVL0qAHAGwtlCf/iEvS8+Q8=; b=Ly4qJBDKk+Op1sQ2YQIA5bRCpX A5eufcwWjL1QBv4dICHIiFSRGeFGv7OJ5O3asN93DX7K7a034sZNtJcNVqTVVc7iGadWzaiyDYfWL pJCbT5jA6vp4CSvbrhAdXDNkT5uExTd7U58db5pmono4ciIw1MNGhWAMcrp6QwTHhOQUEI7pnlK/7 ijrcimZFu/kj/SndxiRS6N1yzoC6IZW9/jcoAHd4PW+f4nVUcMy09DgJsVp2aEOG563w8kE/QFqHB u2NgTpaB2Yhq+zB4DJ0zmyvZ0Ut2SKKiK5Fl8yKvfFa1v0NE7eYymS9iD/3BV8sVKWZn0O9+wmsqW 8QEYY7ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsIgu-00000001tCw-1KBV; Thu, 04 Apr 2024 08:43:24 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsIgp-00000001tCD-2b1g for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 08:43:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A017F6148B; Thu, 4 Apr 2024 08:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB383C433C7; Thu, 4 Apr 2024 08:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712220198; bh=K/2kqRefdjaSq6RSFSje8rLRMQvvvg2h/VDyWIAvNtM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rOmr+Kj/+Y5R96IOjw3hCuE+g6j0GF90jlc0BdbF1n7+Oc5UAcGbTjAd+g9j0HKAZ 6eqDz/KTWUTTXSHIOhjWqjxfQTs/unIJLfsf7wKWB4bXt9zoPoIADmnJ7mw3vKrCAt aYveqtVQ6wb9WyB8XKPxlQK6zNzY0arNXNE64k36iGk4Os3ML9LSI/tea5gv9s0jNg GRk+48LbFfqjfRbxrDmBap/f3dNNWi4qQdN92KmajCTG8SEZP4exj/T+hDsLbnKJZJ N1FznPbTSKe/EGE0Ssy5cvP4mXNpd/alB3QIYtoxQd9TR4C0/bl+lyX8pQZUU2NucQ RDECPr6NbnxVg== Date: Thu, 4 Apr 2024 10:43:14 +0200 From: Lorenzo Bianconi To: Krzysztof Kozlowski Cc: linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nbd@nbd.name, john@phrozen.org, devicetree@vger.kernel.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, lorenzo.bianconi83@gmail.com, angelogioacchino.delregno@collabora.com Subject: Re: [PATCH 1/4] dt-bindings: clock: airoha: add EN7581 binding Message-ID: References: <1988a4460ed327bea7841f6a0f3a756dd7cec4bb.1712160869.git.lorenzo@kernel.org> <65e7617a-9e7b-4dea-a98c-31502222543a@linaro.org> MIME-Version: 1.0 In-Reply-To: <65e7617a-9e7b-4dea-a98c-31502222543a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_014321_964562_71EA7D06 X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8122261297471889469==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8122261297471889469== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2+PFIIQN5kSAMM2T" Content-Disposition: inline --2+PFIIQN5kSAMM2T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On 03/04/2024 18:20, Lorenzo Bianconi wrote: > > Introduce Airoha EN7581 entry in Airoha EN7523 clock binding > >=20 > > Signed-off-by: Lorenzo Bianconi > > --- > > .../bindings/clock/airoha,en7523-scu.yaml | 26 +++++++++++++++++-- > > 1 file changed, 24 insertions(+), 2 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.= yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > index 79b0752faa91..cf893d4c74cd 100644 > > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > @@ -29,10 +29,13 @@ description: | > > properties: > > compatible: > > items: > > - - const: airoha,en7523-scu > > + - enum: > > + - airoha,en7523-scu > > + - airoha,en7581-scu > > =20 > > reg: > > - maxItems: 2 > > + minItems: 2 > > + maxItems: 3 > > =20 > > "#clock-cells": > > description: > > @@ -45,6 +48,25 @@ required: > > - reg > > - '#clock-cells' > > =20 > > +allOf: > > + - if: > > + properties: > > + compatible: > > + const: airoha,en7523-scu > > + then: > > + properties: > > + reg: > > + maxItems: 2 > > + > > + - if: > > + properties: > > + compatible: > > + const: airoha,en7581-scu > > + then: > > + properties: > > + reg: > > + maxItems: 3 >=20 > Original code had here issue - lack of description of the items. You are > now growing it. Please instead list the items (items: - description: foo > bar .....). ack, I will fix it. Regards, Lorenzo >=20 > Best regards, > Krzysztof >=20 --2+PFIIQN5kSAMM2T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZg5oIgAKCRA6cBh0uS2t rFCWAP0Z57M4LuN3Jsam2ES7Vvxp09GbLGM2x46HobQSrrze2gD/SHhAeW8vXIrH YV9OrMHbfXZjgqO1d3jnTBZkUpqMBw4= =DYYB -----END PGP SIGNATURE----- --2+PFIIQN5kSAMM2T-- --===============8122261297471889469== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8122261297471889469==--