From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EFE3CD1284 for ; Thu, 4 Apr 2024 08:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k84uJpnRx3sPefZcg8lG35I82jM7MaK6Rr1+RmtT2HI=; b=opJDvO1ldUjyeuXM/6RncGlHZa atSUR0P42earKpV8929h0rPaglhqWJWNWJA2OFfdqSn3VtoqLFJxLK/HvfJDpZJvu8ImLn/kOz+cu fQRrsccu8d8NW1BJVRWXydICFVrnaEBtuXGBvCi8Aq5qk6DbjX/SAw6uAs6LuNqvDJCzhi8lIMtwN K2kpL7XqtTvO8eaZaTfXTvSuP/ZINSEyn6y/ZcSPQUGAJIuTtpeZq3B9U35yOharIm2GST4sO9TPH 4LNPSJuB1JMONVhCq3IvJdUO0gfc5mtdMhYkSdsxjMB0sL3kKoTJSdBdc/XrJCWlpc4+/n7/XSUQS i7U4feXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsIuZ-00000001wEr-2YHy; Thu, 04 Apr 2024 08:57:31 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsIuX-00000001wEP-2Hny for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 08:57:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AEF46CE1FAA; Thu, 4 Apr 2024 08:57:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 696C3C433C7; Thu, 4 Apr 2024 08:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712221046; bh=p4+j6w82VtZsXD54otR28kqbdlSqj2lBQn5BULCsTuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OrSSdmPMU6cWGOIr9aIskTMnP8lznE37P4IduwDpwKp3RdRq6oxH6mocD8usInBAX i2A+iyNbl/SPYw5dIBuNlZq/bbGA7xIZiv9wXrh6gQ35UDdVkoiC0/3ZfJTATXOWEA tTa0HoCmv8io5VFKBeR4xw2WKAh0IAlvoj8lCoFxGvfUkpMM3VSTuFVTwHAuB3ZrU4 hQ5fjsPiYJrsQANelWYTuAOYilDzl1O/RrwmlZ30q+i6kwUkAyIVX/a0oDnTXGEj7L vouNyKqJNxdmg76aSfA6TdyWaITg8PxUcmixsyBN+ovqOU9OvWsxw8yfeH9sRqpuOD wsFfMzZRz9HUw== Date: Thu, 4 Apr 2024 10:57:23 +0200 From: Lorenzo Bianconi To: AngeloGioacchino Del Regno Cc: linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nbd@nbd.name, john@phrozen.org, devicetree@vger.kernel.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, lorenzo.bianconi83@gmail.com Subject: Re: [PATCH 2/4] arm64: dts: airoha: Add EN7581 clock node Message-ID: References: <8465b7562bcf53a0adfdd4ae01b3ed94d6d5bc54.1712160869.git.lorenzo@kernel.org> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_015729_786518_D7EFBCA8 X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8206193777407410692==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8206193777407410692== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oY2uhKuCtxC5QYl0" Content-Disposition: inline --oY2uhKuCtxC5QYl0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Il 03/04/24 18:20, Lorenzo Bianconi ha scritto: > > Introduce the Airoha EN7581 clock node in Airoha EN7581 dtsi > >=20 > > Tested-by: Zhengping Zhang > > Signed-off-by: Lorenzo Bianconi > > --- > > arch/arm64/boot/dts/airoha/en7581.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > >=20 > > diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/d= ts/airoha/en7581.dtsi > > index 55eb1762fb11..a1daaaef0de0 100644 > > --- a/arch/arm64/boot/dts/airoha/en7581.dtsi > > +++ b/arch/arm64/boot/dts/airoha/en7581.dtsi > > @@ -2,6 +2,7 @@ > > #include > > #include > > +#include > > / { > > interrupt-parent =3D <&gic>; > > @@ -150,5 +151,13 @@ uart1: serial@1fbf0000 { > > interrupts =3D ; > > clock-frequency =3D <1843200>; > > }; > > + > > + scu: system-controller@1fa20000 { >=20 > Uhm, why is this not a clock-controller but a system-controller? I used the same approach used for en7523.dtsi. I guess it is done that way because the registers come from scu (system control unit) regmap, but I guess we can use clock-controller instead. Regards, Lorenzo >=20 > Cheers, > Angelo >=20 > > + compatible =3D "airoha,en7581-scu"; > > + reg =3D <0x0 0x1fa20000 0x0 0x400>, > > + <0x0 0x1fb00000 0x0 0x1000>, > > + <0x0 0x1fbe3400 0x0 0xfc>; > > + #clock-cells =3D <1>; > > + }; > > }; > > }; >=20 >=20 >=20 --oY2uhKuCtxC5QYl0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZg5rcwAKCRA6cBh0uS2t rFDOAQCeK5rxO++40bOf8JtWRi4HTU3UB4MBOHkl4dxTc5ZIfgD+LLWOVZKidKCV njrOALciciq4vePFmNgL0YLRMfxxyQs= =k1+U -----END PGP SIGNATURE----- --oY2uhKuCtxC5QYl0-- --===============8206193777407410692== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8206193777407410692==--