From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF26CCD1284 for ; Thu, 4 Apr 2024 09:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eVNmBgttvZOMr1LqKdKN/lqsVfPXOu0whfLjgk29j6Y=; b=CEGdgIqrodtcGwDb8Er2E0AwKD IkvKACozeLFtfEoXR6jOYqIigbDDN2lJu9EuQzJD1ftYm8xAWue7NaDY7tlVQToLO27fI+hzj8Owv IjpxJVjzVFCnsgNsIEZmhvHwZeiz2BqfpLvlD6X1CnFJakQs1upw3Dc9yqXJsasu+cViKBRjMkxR7 ECkhMNobxBt9BbjU+5MuaWFtW7jY5J66b0HFsuStOQfHerUestJn/Xezza1c2wvsU6ib20psoCjMW 8aJXuUdx5t/9E371rDvRczhKToaQaIEeh/ebPSvY7U7KRUGelOSMp5QTmW71EnundCATqZJXxmeXB qabwl4rQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsJGg-00000001zXM-2aWH; Thu, 04 Apr 2024 09:20:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsJGe-00000001zX0-22DG for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 09:20:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 08E6C6152A; Thu, 4 Apr 2024 09:20:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 314BCC433F1; Thu, 4 Apr 2024 09:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712222418; bh=3VvVsO6yu8Js+kCS8QYj+IP7TOgCxwTVR9hj8VaYEq8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S0iJQkvtzyE0SogA9VZF/4Q9iuqOsvx/xUGh3I81X8MULzk65wJ2WvdbF2BO9f9rq z8Tjanw2OSNeluz5ov/z8qguxhK50TI8IEx9eLoOyEbZr9VJrvsniPEfWSV0IqkibW Fe/KBlTY+lYYmvi3PnMPVj6PYgq1MVWlqmAtzSBvUMyLxz6/H4PN2lYPzfLib9O2uJ 7pQXg5hRDETKMAdHyylL+tKJfHh/IC4M2eNymaoJzteV2G6J4cBKNCBuVgBUx2Autw 40p64c3LTYmi3XGoWz7tQ/ZVbnxejNa+E03J49XNySgGsrgr82i62lOPcR2oPnBpHM nurKxx5OaAYUg== Date: Thu, 4 Apr 2024 11:20:15 +0200 From: Lorenzo Bianconi To: AngeloGioacchino Del Regno Cc: linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nbd@nbd.name, john@phrozen.org, devicetree@vger.kernel.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, lorenzo.bianconi83@gmail.com Subject: Re: [PATCH 2/4] arm64: dts: airoha: Add EN7581 clock node Message-ID: References: <8465b7562bcf53a0adfdd4ae01b3ed94d6d5bc54.1712160869.git.lorenzo@kernel.org> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_022020_746413_22C5221A X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4573903600964503841==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4573903600964503841== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6lFgH9XwmgXcTAyW" Content-Disposition: inline --6lFgH9XwmgXcTAyW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Il 04/04/24 10:57, Lorenzo Bianconi ha scritto: > > > Il 03/04/24 18:20, Lorenzo Bianconi ha scritto: > > > > Introduce the Airoha EN7581 clock node in Airoha EN7581 dtsi > > > >=20 > > > > Tested-by: Zhengping Zhang > > > > Signed-off-by: Lorenzo Bianconi > > > > --- > > > > arch/arm64/boot/dts/airoha/en7581.dtsi | 9 +++++++++ > > > > 1 file changed, 9 insertions(+) > > > >=20 > > > > diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/bo= ot/dts/airoha/en7581.dtsi > > > > index 55eb1762fb11..a1daaaef0de0 100644 > > > > --- a/arch/arm64/boot/dts/airoha/en7581.dtsi > > > > +++ b/arch/arm64/boot/dts/airoha/en7581.dtsi > > > > @@ -2,6 +2,7 @@ > > > > #include > > > > #include > > > > +#include > > > > / { > > > > interrupt-parent =3D <&gic>; > > > > @@ -150,5 +151,13 @@ uart1: serial@1fbf0000 { > > > > interrupts =3D ; > > > > clock-frequency =3D <1843200>; > > > > }; > > > > + > > > > + scu: system-controller@1fa20000 { > > >=20 > > > Uhm, why is this not a clock-controller but a system-controller? > >=20 > > I used the same approach used for en7523.dtsi. I guess it is done > > that way because the registers come from scu (system control unit) > > regmap, but I guess we can use clock-controller instead. > >=20 >=20 > Yeah, comes from there but you're actually defining a node for a clock-co= ntroller, > not a system-controller... makes sense to define this as >=20 > scuclk: clock-controller@1fa20000 >=20 > ...or something along that line (for the phandle) so that, if another scu= related > node appears for whatever reason, we distinguish between scuxyz and scucl= k. ack, I agree. I will fix it. Regards, Lorenzo >=20 > Cheers >=20 > > Regards, > > Lorenzo > >=20 > > >=20 > > > Cheers, > > > Angelo > > >=20 > > > > + compatible =3D "airoha,en7581-scu"; > > > > + reg =3D <0x0 0x1fa20000 0x0 0x400>, > > > > + <0x0 0x1fb00000 0x0 0x1000>, > > > > + <0x0 0x1fbe3400 0x0 0xfc>; > > > > + #clock-cells =3D <1>; > > > > + }; > > > > }; > > > > }; > > >=20 > > >=20 > > >=20 >=20 >=20 --6lFgH9XwmgXcTAyW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZg5wzgAKCRA6cBh0uS2t rJbmAP9hlELfWN67HPAJMnk3DGj4VHkM5nUHI/IQ89F7a96Z5QD+MZF1pHE1chB7 +537vf6yF66KAhxtRjb+6GHIswwqQA0= =UC1f -----END PGP SIGNATURE----- --6lFgH9XwmgXcTAyW-- --===============4573903600964503841== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4573903600964503841==--