From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC9E8C54E64 for ; Mon, 25 Mar 2024 08:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Af+APzpE/EaLo5bBGEN0Q8giRob4dp8GXlOXeX/yQ9o=; b=oJBoUBPWMBX4/p xMzwIEQxjDcmWhU3VW9Faxseia6bBQEJTR6awKPDdNuRa6EYSUiQHxXjhCYmWAZx1nbzCYwzzHzIl McGlKu7jxIM84vYZJZFQtAE26VdbyD/emfr275gPLYvUGCtOIGUxJFHxavRhINxYKhFj2MWjSSMkK drVX532jGjE+KUYFcGBLP53Oj5acE9eHpMg3u+4JFbtp93YB+6b9rXOpaO8GqapVqwLCPpjB5bhFZ nf9ZNDTVywYH8iostVQks0IB9FRX66w9cT1T0/P5lsOGYWE9Rt8mz+qyT5OvehGftX5OvglOIUGti Rm0slZ0621Lb750Z9z/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rofkL-0000000GAqd-2mFZ; Mon, 25 Mar 2024 08:31:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rofkI-0000000GApd-1xP4 for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 08:31:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1DDE660E03; Mon, 25 Mar 2024 08:31:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAA13C433F1; Mon, 25 Mar 2024 08:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711355509; bh=VO7AN01rHdiWwam/sZMD7D9zeSM3KWBzcy0Oq/ITPjk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uE/qlgkn/5Kq3PRzCzI2HOOdIXEspU7f/S8yEEIOGNRuzPmtOTTsjrjEmyoQ2w7Jn dQnjwUNXrsKfZkj49+fqlqcmLPhYdOEg+L+D3I/eJEGd4TKABOOvpse3EUtZyCB5a8 uWTp8d5i+Kp0lJ6mTxEaEnlnrk1Wl3RjArSjtQU9fchHt08PfAOKTuUWuiZh4JCvmx ijy2iiDZblGJ3QVv8zyOmznJCqmEceyeAzgojUQ4BUv1b+GH2yyBhtxHAq4+orXIqj XNUXuPojfPZCU1kqAQ+HRe+WGcxCW6bln2mZTErY6LIKupqczCqFfgt1Kksa5UMqxg C6x7KBNcMaSaA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rofkJ-000000002xB-3WZA; Mon, 25 Mar 2024 09:31:55 +0100 Date: Mon, 25 Mar 2024 09:31:55 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ulf Hansson , Rob Clark , Abhinav Kumar , Dmitry Baryshkov Subject: Re: [PATCH v4 2/8] clk: qcom: gdsc: Enable supply reglator in GPU GX handler Message-ID: References: <20240125-sa8295p-gpu-v4-0-7011c2a63037@quicinc.com> <20240125-sa8295p-gpu-v4-2-7011c2a63037@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_013154_666252_E4C4F4E0 X-CRM114-Status: GOOD ( 27.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 22, 2024 at 06:00:58PM +0100, Johan Hovold wrote: > On Thu, Jan 25, 2024 at 01:05:08PM -0800, Bjorn Andersson wrote: > > The GX GDSC is modelled to aid the GMU in powering down the GPU in the > > event that the GPU crashes, so that it can be restarted again. But in > > the event that the power-domain is supplied through a dedicated > > regulator (in contrast to being a subdomin of another power-domain), > > something needs to turn that regulator on, both to make sure things are > > powered and to match the operation in gdsc_disable(). > > > > Reviewed-by: Konrad Dybcio > > Signed-off-by: Bjorn Andersson > > --- > > drivers/clk/qcom/gdsc.c | 12 ++++++++++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c > > index 5358e28122ab..e7a4068b9f39 100644 > > --- a/drivers/clk/qcom/gdsc.c > > +++ b/drivers/clk/qcom/gdsc.c > > @@ -557,7 +557,15 @@ void gdsc_unregister(struct gdsc_desc *desc) > > */ > > int gdsc_gx_do_nothing_enable(struct generic_pm_domain *domain) > > { > > - /* Do nothing but give genpd the impression that we were successful */ > > - return 0; > > + struct gdsc *sc = domain_to_gdsc(domain); > > + int ret = 0; > > + > > + /* Enable the parent supply, when controlled through the regulator framework. */ > > + if (sc->rsupply) > > + ret = regulator_enable(sc->rsupply); > > + > > + /* Do nothing with the GDSC itself */ > > + > > + return ret; > > } > > EXPORT_SYMBOL_GPL(gdsc_gx_do_nothing_enable); > > This patch (and series) is now in mainline as commit 9187ebb954ab ("clk: > qcom: gdsc: Enable supply reglator in GPU GX handler") and appears to be > involved in triggering the below lockdep splat on boot of the Lenovo > ThinkPad X13s. > > Adding Ulf and the MSM DRM devs as well in case I blamed the wrong > change here. I've now verified that applying this series on top of 6.8 also triggers the lockdep splat even if it is possible that it only exposed an existing issue. This is still a regression and also prevents using lockdep on these platforms, which can lead to further locking issues being introduced until this is fixed: #regzbot ^introduced: 9187ebb954ab Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel