From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67848C54E58 for ; Mon, 25 Mar 2024 09:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FuVY5zOQUWc5GBJES5Um/IPdLpA7L1KKnWs5unvUEjA=; b=BRlMFSeQFGRTXc LbTUWRw+hWPOB6UQ8DWpIJwOu1sTaBXAT4hOPcG0WDy65vm+cDPL5Iaa19YAwg13cMnOgBcAGt/DC CyIx3GmCYaRtlQxbmPjH03dggoOLE4EjJaNuCNuuOsNOiJ79I3skVkBe+rmQThMIRnq9nnbqG/DHG J9Q0rQLQAV2cGh/WK9mHms5OwtcF+iZ963ITXijD7dB3cm/l3YH6QGCClsmgGaVPaTZ8+MXS9qNS3 rbXKEWRB6dl7w5P69IkJXOAVBssTya3G9lUSVqa8rgfEPw2vkMq5krSgf8XzWeQfOeIDIVvEQhSWH ZYadivxHlCEc8W3Zpi7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rogmW-0000000GUdb-0kE6; Mon, 25 Mar 2024 09:38:16 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rogmT-0000000GUcx-1dGB for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 09:38:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B7197CE12D0; Mon, 25 Mar 2024 09:38:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C3BCC43399; Mon, 25 Mar 2024 09:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711359490; bh=LYP5Vsr+Zdn9vmu5oX47MSKUEjdDr89roznGdVIV8NQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fTN4Rt79eQEh52TaxQ9rjiVbMydp1wnV9526o8VNh1Ii+/xtIoPqzDnXQsfw0rxTL mvMKcIb0wVzFAgG8lCfBr8SoWJtnCPLE8J34W6f6ovMEy4bMtFfLrrS8e9hrdSv5D+ juoxqHH7QCQm1276XDdfOWC6P3ZoPn5B3WO7IhT4UR+neTTpQC6BSp6iaD7AbYeQ72 lW9HdUUMtGlLMuSbZhaFUs6a63NlPwxrVyMgH6wXJXgJk0qVCbNLk+ziK02qF5oNXC SSAFzzJA1sgWWU3vuXqF96QuvsDkrv6+3yziAo0edcIhLqB2s2JdDKTY84v0lZa+Jn 0FPiuR1GVs0fw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rogmW-000000006zS-1WeW; Mon, 25 Mar 2024 10:38:17 +0100 Date: Mon, 25 Mar 2024 10:38:16 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dmitry Baryshkov Subject: Re: [PATCH v4 3/8] clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc Message-ID: References: <20240125-sa8295p-gpu-v4-0-7011c2a63037@quicinc.com> <20240125-sa8295p-gpu-v4-3-7011c2a63037@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240125-sa8295p-gpu-v4-3-7011c2a63037@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_023813_706661_04EA72A3 X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 25, 2024 at 01:05:09PM -0800, Bjorn Andersson wrote: > On SA8295P and SA8540P the GFX rail is powered by a dedicated external > regulator, instead of the rpmh-controlled "gfx.lvl". > > Define the "vdd-gfx" as the supply regulator for the GDSC, to cause the > gdsc logic to look for, and control, this external power supply. > > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Konrad Dybcio > Signed-off-by: Bjorn Andersson > --- > drivers/clk/qcom/gpucc-sc8280xp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/gpucc-sc8280xp.c b/drivers/clk/qcom/gpucc-sc8280xp.c > index 8e147ee294ee..e2b3bc000c71 100644 > --- a/drivers/clk/qcom/gpucc-sc8280xp.c > +++ b/drivers/clk/qcom/gpucc-sc8280xp.c > @@ -399,6 +399,7 @@ static struct gdsc gx_gdsc = { > }, > .pwrsts = PWRSTS_OFF_ON, > .flags = CLAMP_IO | RETAIN_FF_ENABLE, > + .supply = "vdd-gfx", This change now triggers warnings on SC8280XP which does not have this supply: gpu_cc-sc8280xp 3d90000.clock-controller: supply vdd-gfx not found, using dummy regulator I've sent a change to start treating this optional supply as truly optional here (even if it has not shown up in lore yet): https://lore.kernel.org/r/20240325081957.10946-1-johan+linaro@kernel.org But why are we still using the same compatible string for sc8280xp and sa8540p and sa8295p if they differ in such a way? Shouldn't these structures be different for the two classes of SoCs, which would avoid such issues and which would allow us to continue to warn if the supply is missing on a sa8540p derivative platforms where it appears to be required. Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel