From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6101C54E64 for ; Mon, 25 Mar 2024 20:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gnRfJaXxTHk6lUQFZffquVTsVQEtP2T5ll/CV1FFxvY=; b=rqil4b4FAMXn4Z zaWKDZd6YX+dm9Eo7BZLIScbLfuSCoU1PxKv16aOhT+nPiVNJBzRIo2yHdRLpeqDLOC53h3MRf15V QokM/GNDeGOyOg54btjKNG+7PBthkGbTX7eK8g5QkYJ6Nd34wWz6P89ENOfAMiCRCKKqH3rAKk75F OJS4ekIM/hdZRZz8S+4sop6jrKFylsSyW+pSy3WSObK5ktUfzHitMUcgbWqNR3g/ZC1wK+gk49C9Q rEFdRPDIkHjBzpqyDiCkaIsd3qlUT9LUgvLHQpR2DpuoOGp1hKlIU56eXqqOK5uAcdPjbrqUcO0Ql 6vLs5m9KIbiifAaVG+Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1roqsc-00000001n53-1vpn; Mon, 25 Mar 2024 20:25:14 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1roqsZ-00000001n3w-3fIC for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 20:25:13 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a465ddc2c09so266168966b.2 for ; Mon, 25 Mar 2024 13:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711398307; x=1712003107; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JKap+w2F/mavcZpUAHIDLIPh2s+384u67vVZTtB6BQw=; b=jxGoG3Qwmj1Zo57iBgDLTEh090gNxlkoNToblF3o5L4sttq9cCteB8Uj42rSVLemNS cbNx4X4S63Uf427+3Fpd8siSfMrr8og69TzZPt6loTQUOtHO36FQt4DOlWdVImIiQkfW TYQsMhWWfWwE485vsJ8q7ojDL6mQn4Tr4ZfBtsKwSEduf16K3qqkYBR9Ch6A3XYfRUDj pGVbPGoxOxUJ2E/0Fg3VnUHbBHPVlAbuFohYJacEI0dAIyqMCTNIHG+q+W6RfEX7bLNr QLr5PUZbvV1aMB17IP0GwQMstIXlGwlGduAeq3hUWPfBpr3OHLp0oZcVrTZE1eeKya4q H/Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711398307; x=1712003107; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JKap+w2F/mavcZpUAHIDLIPh2s+384u67vVZTtB6BQw=; b=JVxevEQxfwenYeKNqyYcyqXiYjKK0H5DtaWi4HInpDCJaiU2A4Mj3/pgsN0rTnDBuj f+hGGCgDs159kynOMxqEQpGgcv3l2FSPxCZoovaEYmWDWWgeNBaoF4HRvWnfsjIdTNVP HsDaMN3Lrd0Mc91+kBht3Nn4RdIL1gWBnNYhBl8CjIK552E+OT5Ic15hW9m/fPhh9x+K vZZB96DaNpSDpulPYlQme7lKAyo6nXuSKTsR+BT8764wsH6HlLnEfxVbb1srs0dwswv0 N+awczawmAwAmd4ANHthSYEfjoIaL9nbf1v8dow9Zy1asgzzWX4lL57YDG+QoYsonmh6 NRMg== X-Forwarded-Encrypted: i=1; AJvYcCV+40X9I5E0Wub3Jjb1hPuCtwNS9DG8DZTO2hFPOb8wL/p8Y4GRI2bTGPprB8hDsKbnpKIFIvCoj8nlxortBYmXtxVsGEr/Ww0Rbvg2Q+t7tDKzoIs= X-Gm-Message-State: AOJu0YwWngmX1IOB77g+GXhihD+hM4iYUQEhuS0uiHiEK9//xBhw4hsq 8Pl6vDhBnAoexeMErWzFEsLRMnN0PXBsAX0sS73Ch4GOgtss+G0SfHH+vOGm X-Google-Smtp-Source: AGHT+IH3MYHwbMtQtubhWVjxi/2gtr5wMVHSj9eDzomJs3JTaxIPbZAKJDw+94DvZ7YPRH86G7VJGg== X-Received: by 2002:a50:d484:0:b0:568:c6a2:f411 with SMTP id s4-20020a50d484000000b00568c6a2f411mr5723974edi.32.1711398306520; Mon, 25 Mar 2024 13:25:06 -0700 (PDT) Received: from standask-GA-A55M-S2HP (lu-nat-113-247.ehs.sk. [188.123.113.247]) by smtp.gmail.com with ESMTPSA id c36-20020a509fa7000000b0056bdec673c3sm3456565edf.38.2024.03.25.13.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 13:25:06 -0700 (PDT) Date: Mon, 25 Mar 2024 21:25:04 +0100 From: Stanislav Jakubek To: Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013) Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_132511_939636_C2B05D32 X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2024 at 08:28:27PM +0100, Konrad Dybcio wrote: > On 24.03.2024 3:04 PM, Stanislav Jakubek wrote: > > Add a device tree for the Motorola Moto G (2013) smartphone based > > on the Qualcomm MSM8226 SoC. > > > > Initially supported features: > > - Buttons (Volume Down/Up, Power) > > - eMMC > > - Hall Effect Sensor > > - SimpleFB display > > - TMP108 temperature sensor > > - Vibrator > > > > Signed-off-by: Stanislav Jakubek > > --- > > [...] > > > + hob-ram@f500000 { > > + reg = <0x0f500000 0x40000>, > > + <0x0f540000 0x2000>; > > + no-map; > > + }; > > Any reason it's in two parts? Should it be one contiguous region, or > two separate nodes? > > lgtm otherwise Hi Konrad, I copied this from downstream as-is. According to the downstream docs [1]: HOB RAM MMAP Device provides ability for userspace to access the hand over block memory to read out modem related parameters. And the two regs are the "DHOB partition" and "SHOB partition". I suppose this is something Motorola (firmware?) specific (since the downstream compatible is mmi,hob_ram [2]). Should I split this into 2 nodes - dhob@f500000 and shob@f540000? Stanislav [1] https://github.com/LineageOS/android_kernel_motorola_msm8226/blob/cm-14.1/Documentation/devicetree/bindings/misc/hob_ram.txt [2] https://github.com/LineageOS/android_kernel_motorola_msm8226/blob/cm-14.1/arch/arm/boot/dts/msm8226-moto-common.dtsi#L258 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel