From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6027EC6FD1F for ; Tue, 26 Mar 2024 12:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wAj0DouFO6bvWJek0Ewtbe+e/C9Qtrj080DuDPiRnyk=; b=GnrW25Cvs814co 6bb4eUEWwSUzd6MCuz0Gkj0SEAiI5FVPyOrHhS/obRoQFP3UxN+V7ice4Wfu/zzvRLSa20we6o/6x 5sY3Nn3y4Lr+jORwwvRrU3hzbqDNILx+eOhw/8nyn+TWTeU9pi6HYPVLE2ZGX803rW/1QLVPcNTOC /8N2Q3R8CscqR5hjLPQzwgolHX+1lqt2fCKLfwAL9Yz/zjthon+KCMAz3PHmmLvowZa4K1w5cawT+ GNJHGemAOsxveVkJ+lxsRF0ytnWJMCqevobcU897uxpMJHUWwTQZDC8QRXL3v1Z0wTcfll8ONv8tK TrHL/v83JpJphctm3FNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp5ZL-00000004ORu-08GU; Tue, 26 Mar 2024 12:06:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp5ZG-00000004OQd-2VZ0 for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 12:06:16 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3E712F4; Tue, 26 Mar 2024 05:06:46 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DE3483F64C; Tue, 26 Mar 2024 05:06:12 -0700 (PDT) Date: Tue, 26 Mar 2024 12:06:10 +0000 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/5] firmware: arm_scmi: Add message dump traces for bad and unexpected replies Message-ID: References: <20240325204620.1437237-1-cristian.marussi@arm.com> <20240325204620.1437237-4-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_050614_829821_85DEE585 X-CRM114-Status: GOOD ( 24.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 11:57:23AM +0000, Cristian Marussi wrote: > On Tue, Mar 26, 2024 at 11:24:38AM +0000, Sudeep Holla wrote: > > On Mon, Mar 25, 2024 at 08:46:18PM +0000, Cristian Marussi wrote: > > > Trace also late-timed-out, out-of-order and unexpected/spurious messages. > > > > > > Signed-off-by: Cristian Marussi > > > --- > > > drivers/firmware/arm_scmi/driver.c | 10 ++++++++++ > > > drivers/firmware/arm_scmi/mailbox.c | 4 +++- > > > 2 files changed, 13 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > > > index 7fc1c5b1a2a4..207ed1a52d69 100644 > > > --- a/drivers/firmware/arm_scmi/driver.c > > > +++ b/drivers/firmware/arm_scmi/driver.c > > > @@ -861,6 +861,9 @@ scmi_xfer_command_acquire(struct scmi_chan_info *cinfo, u32 msg_hdr) > > > "Message for %d type %d is not expected!\n", > > > xfer_id, msg_type); > > > spin_unlock_irqrestore(&minfo->xfer_lock, flags); > > > + > > > + scmi_bad_message_trace(cinfo, msg_hdr, MSG_UNEXPECTED); > > > + > > > return xfer; > > > } > > > refcount_inc(&xfer->users); > > > @@ -885,6 +888,9 @@ scmi_xfer_command_acquire(struct scmi_chan_info *cinfo, u32 msg_hdr) > > > dev_err(cinfo->dev, > > > "Invalid message type:%d for %d - HDR:0x%X state:%d\n", > > > msg_type, xfer_id, msg_hdr, xfer->state); > > > + > > > + scmi_bad_message_trace(cinfo, msg_hdr, MSG_INVALID); > > > + > > > /* On error the refcount incremented above has to be dropped */ > > > __scmi_xfer_put(minfo, xfer); > > > xfer = ERR_PTR(-EINVAL); > > > @@ -921,6 +927,9 @@ static void scmi_handle_notification(struct scmi_chan_info *cinfo, > > > if (IS_ERR(xfer)) { > > > dev_err(dev, "failed to get free message slot (%ld)\n", > > > PTR_ERR(xfer)); > > > + > > > + scmi_bad_message_trace(cinfo, msg_hdr, MSG_NOMEM); > > > + > > > scmi_clear_channel(info, cinfo); > > > return; > > > } > > > @@ -1040,6 +1049,7 @@ void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr, void *priv) > > > break; > > > default: > > > WARN_ONCE(1, "received unknown msg_type:%d\n", msg_type); > > > + scmi_bad_message_trace(cinfo, msg_hdr, MSG_UNKNOWN); > > > break; > > > } > > > } > > > diff --git a/drivers/firmware/arm_scmi/mailbox.c b/drivers/firmware/arm_scmi/mailbox.c > > > index b8d470417e8f..fb0824af7180 100644 > > > --- a/drivers/firmware/arm_scmi/mailbox.c > > > +++ b/drivers/firmware/arm_scmi/mailbox.c > > > @@ -56,7 +56,9 @@ static void rx_callback(struct mbox_client *cl, void *m) > > > */ > > > if (cl->knows_txdone && !shmem_channel_free(smbox->shmem)) { > > > dev_warn(smbox->cinfo->dev, "Ignoring spurious A2P IRQ !\n"); > > > - return; > > > + return scmi_bad_message_trace(smbox->cinfo, > > > + shmem_read_header(smbox->shmem), > > > + MSG_MBOX_SPURIOUS); > > > > From previous patch, IIUC scmi_bad_message_trace is a void func and doesn't > > return anything. Did you not get any build error/warning for this ? > > > > No...I am building with W=1....but note that the caller itself here > rx_callback() is supposed to return a void... > > ...in V3 I may just split this into 2 lines and leave the return; alone on its > own line to avoid any confusion... Not need to respin unless I find something that needs reposting, can fix this myself. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel