From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F962CD11DF for ; Tue, 26 Mar 2024 09:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fi4rPFSQgwhgs3zUrv/AqomlO1hM3a7wG7KlwT95X1U=; b=rncIC2NlvWgMLC FBxd7y+L92hp1r/AX0BfHleyWhH8mQHZVFiCQ0XiYDrngDAPXKDCLB35zgaFlCBrjW5FLSf3E/evG I/dIB/lmsaY0eJGJF+B1c8zKrLsDSO7NFcXdpdTQ2gJYMiykbeIBBtC/9YeeKeDp1y/LJI7ONY5jU Mll3Yb+tO83kpmokwd2lT521UiMhQDi+Wau40QDn8ZioMzWseDRnumrIDKfcJY/hluaQUpxHBy/ps PIBSBWi1dt96i0qArNMUyqznm/G5w7Ym4ZPj0+HEw1MSXVDNEp6VVwHNZZyNwqned9CKc9Z0MiELu JsSwZVe9qGJ8eAp0sbEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp3RI-00000003tiB-1fAt; Tue, 26 Mar 2024 09:49:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp3RF-00000003th1-1gsW for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 09:49:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BBF42609FB; Tue, 26 Mar 2024 09:49:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06753C433F1; Tue, 26 Mar 2024 09:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711446588; bh=1TOSFjtroPOGfQTkxCHWFvG9NRdrsRwmbCHxxp90yfI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gRSkwRiDhQ1SejXmzHwiP3wHPaal0hQIpI1nHudod3/6gQNssiHnGyq2YJ20M4SXG P1L2M5Vv87t7J5SwAMmiR1nhD+o6sfqV91r2tWUKi5XAbp4frdj07Au2OdW8iH06WK RFCFbfhIjzYH9I1xQZDVHmAiSRjbHxK0KT8OO5VIH2rrlPEutKaB+IyUcgqOyIxnyh BvtCzqFNV7YfnGcmdypTi2Bdiblo2mvDDvEIV+gCHStAPWyjyfnZoqKU6UjzvbJyCV sBHcei4sKtm+waJSHh4cVtHlqIkOKqrewaweQCYym24Cia3ZXdMCO8tB6fefoCqS7R R2KPBCeXhFv5g== Date: Tue, 26 Mar 2024 10:49:42 +0100 From: Niklas Cassel To: Siddharth Vadapalli Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, manivannan.sadhasivam@linaro.org, fancer.lancer@gmail.com, u.kleine-koenig@pengutronix.de, dlemoal@kernel.org, yoshihiro.shimoda.uh@renesas.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH v4] PCI: keystone: Fix pci_ops for AM654x SoC Message-ID: References: <20240325053722.1955433-1-s-vadapalli@ti.com> <750df13b-ee2f-4067-a9e0-7fd1ace384cf@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <750df13b-ee2f-4067-a9e0-7fd1ace384cf@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_024949_508006_054C2278 X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 10:29:10AM +0530, Siddharth Vadapalli wrote: > On Mon, Mar 25, 2024 at 02:45:09PM +0100, Niklas Cassel wrote: > > > > In fact, if you move this code to ks_pcie_msi_host_init(), instead of > > ks_pcie_host_init(), you would not need a comment (or a if (!ks_pcie->is_am6)), > > since ks_pcie_msi_host_init() is only executed by !am654. > > This seems much better :) > > In the current code, the execution is as follows: > > ks_pcie_probe() > dw_pcie_host_init() > pci_host_probe() > ks_pcie_v3_65_add_bus() > > Moving the contents of ks_pcie_v3_65_add_bus() to ks_pcie_msi_host_init() > will result in: > > ks_pcie_probe() > dw_pcie_host_init() > if (pci_msi_enabled()) > if (pp->ops->msi_init) { > ret = pp->ops->msi_init(pp); > ks_pcie_msi_host_init() > pci_host_probe() > > I will update this patch based on your suggestion. If it's alright, may I > also add your "Suggested-by" tag for the v5 patch? Please let me know. Fine by me :) Kind regards, Niklas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel