From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA2BFC54E67 for ; Tue, 26 Mar 2024 16:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vFXakiKcSVdkDfO1dxDHxkEMvpEocxF3T2M/MMCF0vQ=; b=466FBWvSgxuCEk kAYpwwcPn5VOQ5P2SpV0+/UQaBm6mSqiOnwMWevzJdoha5hTLFryuQ2+0z5uiyskLtCT1MZtrT8CW n+puywPv8XD0PER1unIQSlERiYR+dL2Fq26VQObFQNYvnONxom0lKj2XWIQ2ciHQ5CR6cwXbpEVr4 JDhxGUcP8koyHOji7b9Wp9y94Ex6Mxd1/qNUUOl6dgLLXKMYqH6lcuzzaQwIOKGZJ9Vmme+SPJBvs wdxG/fNeE0vNCF2tKtxOPyU+sStJYoa5dzK6yMxV2sr7CS1z81Q+m4xpgCvNPXqIhsrSFjrIb/3gz FtssIfyJY/FIeJYCyipA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp9Rt-00000005PY3-2bRX; Tue, 26 Mar 2024 16:14:53 +0000 Received: from out-172.mta1.migadu.com ([2001:41d0:203:375::ac]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp9Rp-00000005PUt-4A2S for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 16:14:52 +0000 Date: Tue, 26 Mar 2024 09:14:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711469682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jgz8XF65rx2wCQTQJxyux8jph07RNruismoLWNzkc6M=; b=iWnrPWx3pYF6YI2TY3PLb9vcrVcxXjPA7Xp4lbj+tSngz7p/wYyMamSRzzmzTOemQ9rgfg VS70C08N6gNAKc9BWW2gNHenkx71ArDFgTAH1Ifbixwm0o6eMgN+R794ZHWXRlbNSuaQzr AlrDolUZQpHPf5Ejqk3uv8LIIxOSyoo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Will Deacon Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Gavin Shan , Marc Zyngier , Mostafa Saleh , Quentin Perret , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH 1/3] KVM: arm64: Don't defer TLB invalidation when zapping table entries Message-ID: References: <20240325185158.8565-1-will@kernel.org> <20240325185158.8565-2-will@kernel.org> <20240326161000.GA9723@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240326161000.GA9723@willie-the-truck> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_091450_601575_657CA53F X-CRM114-Status: GOOD ( 11.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 04:10:01PM +0000, Will Deacon wrote: > > @@ -1163,7 +1168,7 @@ static int stage2_unmap_walker(const struct kvm_pgtable_visit_ctx *ctx, > > kvm_granule_size(ctx->level)); > > > > if (childp) > > - mm_ops->put_page(childp); > > + mm_ops->free_unlinked_table(childp, ctx->level); > > Hmm, but doesn't the deferred TLBI still happen after the RCU critical > section? Right... We'd need to change that too :) Although I suppose table invalidations are relatively infrequent when compared to leaf invalidations. > I also think I found another bug, so I'll send a v2 with an extra patch... And I'm sure there's plenty more to be found too, heh. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel