From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6601FC6FD1F for ; Tue, 26 Mar 2024 18:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TdMgEdvbqhuLiHjENWtUihVup7IkWLMRruq8e42bQUg=; b=2FGIEQ0yS6jHOz obYQxZiM2M7IEQAkCTZFHjFDC+s9NizliqNGnV/vrZOXvNWuwb88Gnea5jzEe7FCLiMKbREnJ6we0 Js2XvegMvYdoHgCJ+HXTY8BF+13sGntNHTuEAgNsO0xJ9BfMm7ISsd9AVJmo79LOiYyb8AH0ryaZd fiuRbfO9sZ/tvOURo4GfDBjHZ/cNRpv0WtHnaY8XcjXvJXfiZXBXlvav69FbpG3JQrgYMYrcNnx2Q XZXsZpUno0tZ6QzpkEB6eZQo17/Te69NhfZvlxL9lxz8bkLDWyhZlP8nqzalTGc9SbWO1ddkaidxS ovkQ1Vij61ocu5jlig/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBsG-0000000606l-45vN; Tue, 26 Mar 2024 18:50:16 +0000 Received: from mgamail.intel.com ([198.175.65.10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBsA-0000000604j-2H4E for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 18:50:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711479010; x=1743015010; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=a1y1froYsk3QklXtDSfjEieKaCKHwIw1eSHeC1vU9wM=; b=ava8appSS8EwarT3hemjXraQnHiHQrsiw3kTwyj7fr/jND3dTPg+GYY2 BmOTZb1ahe/1Ve9NJJijpv00P5D7cyBHvS8G4DGvfHE0VgAwiK6N8E66+ xka88Wks11FP/aHrBkQdnRX/OjLZSdxMkmKkHvM3S0619WL9ufSb4HJkO goJO8G7iVdWcnj0HeD0/+YtWuo6yovHkmMTusVTvPRLVd+brPHikM7OJL sZl6Sz717kM//TrCtfDlxjRHFeHoYWkPo4SHg+wYSVvegEKDUrYjomIbM Qau+Z12Djo5TUMUb2NdBCShPIOWAwhzkbXPjwWpu5wm+BGzz/N3EsHVt/ A==; X-CSE-ConnectionGUID: qSSWFtuLQjK3R3NAX/ufxQ== X-CSE-MsgGUID: MFV0zlefSp657Y4tg6AXoA== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="23993144" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="23993144" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:50:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914887860" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="914887860" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 11:50:07 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rpBs4-0000000GQSL-3HAk; Tue, 26 Mar 2024 20:50:04 +0200 Date: Tue, 26 Mar 2024 20:50:04 +0200 From: Andy Shevchenko To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King Subject: Re: [PATCH v1 07/10] spi: pxa2xx: Provide num-cs for Sharp PDAs via device properties Message-ID: References: <20240326181027.1418989-1-andriy.shevchenko@linux.intel.com> <20240326181027.1418989-8-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_115010_872199_8A9E8713 X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 06:21:48PM +0000, Mark Brown wrote: > On Tue, Mar 26, 2024 at 08:07:57PM +0200, Andy Shevchenko wrote: > > > Since driver can parse num-cs device property, replace platform data > > with this new approach. > > But why? To be able to hide the header's contents from public. Should I update the commit message? ... > > +static const struct property_entry spitz_spi_properties[] = { > > + PROPERTY_ENTRY_U32("num-cs", 3), > > + { } > > +}; > > This is just platform data with less validation AFAICT. I'm not sure what validation you are expecting here. It should be done via DT schema ideally when the platform gets converted to DT. This change is an interim to that (at least it makes kernel side better). After the platform code may be gone completely or converted. If the latter happens, we got the validation back. In any case it's not worse than plain DT property handling in the kernel. The validation in that case is done elsewhere. Since the property is defined in board files the assumed validation is done during development/review stages. But OTOH for the legacy code we need not to touch the property provider more than once. We are _not_ expecting this to be spread. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel