From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E716C47DD9 for ; Wed, 27 Mar 2024 15:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EzrQYbv3p4rKMN/yuAQ/QRoPmjMca0mEbzrEiQeK4Mw=; b=4s34hgiqxrXElW PRes2Hffpqpwk7sX++aamY9/jB46PC7fVEDu8pUc67ZrKvp7j6YG5EA0UBVM1VbuIVHtSqlTlgzOu zSGPxikm46Auk3paeevEFAiUB9A+iPuzWEnvA0J5+FUvmGevEzejCYR69uYGIIDfWkfSd+v36F21u TtJnNihAwQwwJvPUQXEILR9z2HM/TlTjAnizE29mgTNuPvhRdO1EQoLICl9fUR0bIlv3J5u/lQ1q2 yglkv+IAMgvhPHBYLLtnREtNJSFE31t9vPK/nvitvlqxW7ocDH5omV+dbt0GZov3+XXEWSpvWsoCR zDgHmtgo8eLa5R4Wevsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpV6D-00000009kgA-0Vnx; Wed, 27 Mar 2024 15:21:57 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpV6A-00000009kec-2hFz for linux-arm-kernel@bombadil.infradead.org; Wed, 27 Mar 2024 15:21:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4RJOr7EzuI0DVaYxx+XjeXTwjAi2iT7d0lhMZ/VIsjg=; b=eC6Ws8u1Qbjujwr23XQ7MNl0yS YH7ttLGh1RLDvn+sVH29mDvDEPa2pw2k9pz3LSpn+ol8sgztPG1K8FxJE1RY0C4nnlZuDS4iKYP8Q /fpNEbpsdAXwvX8s4EuvxLJJcIFQ/cDYo/kx7VmlFYAsX4EcJJap2uTWpKr7pTqblxsz6UjcUHi+W +kNeWDQ/Upc/93F+Zv7/kLpShy1A+fDBPuYPQNcDNeIzpOD3RpQQixL2THvKhcRlxQBoSACHTPdjG T2OQoZA5L7ghF8tN6M6M9uzryMxa/lbSMo22x99gAHUutM386cOJbIxNfPfeSM7zNFMGO0x+iY62k 3iO1mMfQ==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpV65-00000000Ktf-3Dtu for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 15:21:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711552905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4RJOr7EzuI0DVaYxx+XjeXTwjAi2iT7d0lhMZ/VIsjg=; b=a8VDp2WDVgyboA8qBtWpRsUNHVKyVsc8ecB42vWPaCxi7L2I6aLlzUsd12wEni6Bz/IF9e 0DXN5FhKemqb74DMpAYYLlKJHsHzh215527tymhMbeAWXwr+MxbzPf1WY3DZBqtdywpvhG TRGFzUEXQPGmKnzuovOS49QyXr5qhPA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711552906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4RJOr7EzuI0DVaYxx+XjeXTwjAi2iT7d0lhMZ/VIsjg=; b=FfeBvTQ1YOCM6sVNyKpde99nQEnNF1bbiPegJ6LoRMJz4OLuzJ7Fw8hizVP/xUyE3pUtTI pg2pnt6R7jteuiaraKjG1pwwKNW7Pah3Zsuf+7wcy8fZNtwkEprZkD3msgiSMEzEZw4TX7 h/hxo47DbbYOVBC3z3m8yRRJ/luCImU= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-Bou75rw7OCCIp36b69WxYA-1; Wed, 27 Mar 2024 11:21:44 -0400 X-MC-Unique: Bou75rw7OCCIp36b69WxYA-1 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-6e4fe655c93so2425760a34.1 for ; Wed, 27 Mar 2024 08:21:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711552903; x=1712157703; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4RJOr7EzuI0DVaYxx+XjeXTwjAi2iT7d0lhMZ/VIsjg=; b=N2diLkbkFwlwGDRVbrkdvvFmSU6oatpGUWUj60qfTsMW+93HWF4v2jbA7jqYxm6J9E vI0kT6sOuTH6kJohTSLEpwaH2yBUqUP7avU6StO+W13Fk6Jn3ynybY2CaAv6vt08IbQm zeoNqNKRBYLMEIju3nnqnFTA785MzxzIeHA79BPz6uFgL5Ahll7O9tN4Zc0yzd6GcVEZ kwhHq48XdJUz3QKcCJ8oJcMvpaezolAidl/3TKlLXeTE/1+RWFFfGMgnUMkJRb98lJQz ANxqXDPEWozx5WEdZnz3+U/teAk59gfAUNE+lMkUKMWvhkZpYoQ384Lu62Keuwfx6ShL 8FKQ== X-Forwarded-Encrypted: i=1; AJvYcCX7WgcmHhs6vKEMWLnhxYeQ7c8fRczNVYAryuj1tBKC2W/uV4VSf4ERPD1ZA4s7xeMgUPnBvJEA+dud/LZifKXtSAzQ1n8JnE+qOwmnXdYLbfWajA4= X-Gm-Message-State: AOJu0Yx1KWVRCyUoNjHuuilUPJueFme5ofHSfxJSKBz2hVszD6GhRA+1 3cjJWgfriIp1fWcpxWzbzifed4cv/zVr+mctRn9bQgbaxu7QdYSyQ6X9w5ejXLBWT8a4rdl8xTG 9a/4y/Th99U/CpeVHAEtmcgo2IWrWQgY3jHLB0e6lWTwA//o0e0YE3XrloBc6Ukx0ooHshwTV X-Received: by 2002:a05:6808:128a:b0:3c3:d729:1d56 with SMTP id a10-20020a056808128a00b003c3d7291d56mr316752oiw.0.1711552903441; Wed, 27 Mar 2024 08:21:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxT5qAZWntttFMbBHTXwtvywmg90pV0zoL9F4zS7SQ4GsHwDy+Ru4KfcRdtRpsXZfeVg5bqg== X-Received: by 2002:a05:6808:128a:b0:3c3:d729:1d56 with SMTP id a10-20020a056808128a00b003c3d7291d56mr316719oiw.0.1711552902921; Wed, 27 Mar 2024 08:21:42 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id r15-20020a056214212f00b0069698528727sm2350243qvc.90.2024.03.27.08.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:21:42 -0700 (PDT) Date: Wed, 27 Mar 2024 11:21:40 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Andrew Morton , Mike Rapoport , Jason Gunthorpe , John Hubbard , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH RFC 0/3] mm/gup: consistently call it GUP-fast Message-ID: References: <20240327130538.680256-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240327130538.680256-1-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_152150_026581_E92E8D28 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2024 at 02:05:35PM +0100, David Hildenbrand wrote: > Some cleanups around function names, comments and the config option of > "GUP-fast" -- GUP without "lock" safety belts on. > > With this cleanup it's easy to judge which functions are GUP-fast specific. > We now consistently call it "GUP-fast", avoiding mixing it with "fast GUP", > "lockless", or simply "gup" (which I always considered confusing in the > ode). > > So the magic now happens in functions that contain "gup_fast", whereby > gup_fast() is the entry point into that magic. Comments consistently > reference either "GUP-fast" or "gup_fast()". > > Based on mm-unstable from today. I won't CC arch maintainers, but only > arch mailing lists, to reduce noise. > > Tested on x86_64, cross compiled on a bunch of archs, whereby some of them > don't properly even compile on mm-unstable anymore in my usual setup > (alpha, arc, parisc64, sh) ... maybe the cross compilers are outdated, > but there are no new ones around. Hm. I'm not sure what config you tried there; as I am doing some build tests recently, I found turning off CONFIG_SAMPLES + CONFIG_GCC_PLUGINS could avoid a lot of issues, I think it's due to libc missing. But maybe not the case there. The series makes sense to me, the naming is confusing. Btw, thanks for posting this as RFC. This definitely has a conflict with the other gup series that I had; I'll post v4 of that shortly. -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel