From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AF6DC6FD1F for ; Fri, 29 Mar 2024 12:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4+Qw4y9v9gY78z6UC9e1HjF+WsjovvHIjqoh12/Xyv4=; b=Z2eZqQoewe0+lG SlpyIYHJD0TbMK4kib+cfxhCtZQpd7c4+6lfCzin4jkRe0vUgfW4UY5ZyQ7KjNat2qJUbqmNmdmz8 ZWw7ni67Xm5VpA2mDPJwAsR5VNiwkb8qYSVv/rAzoYHQWdS3hWjvb7kgrJ/k6yKa60upxHf9M4HZC ijU+N//DYBt9ipNMnoORmpszHruDwEIHmSJXf+3c2CbcQ0cSIAqd08cAqpNMUwAnWHDJMQb7dHThF 2gMnFoSk/rNZxKVUCSwV+ZyGP0rb79zHahIsTmsngdPl74T+Y/H7dd7HL0w/DAlFumEs+araj1g0I BaxcOOnAPw+nrU5FvHIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqBSQ-00000000OWB-1wlD; Fri, 29 Mar 2024 12:35:42 +0000 Received: from mail-177131.yeah.net ([123.58.177.131]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqBQu-00000000Nb6-2ERI for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2024 12:34:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=wI/Amv+RPJQvoX1/bZKyPoE67fMI/bfxn2JETr9yooI=; b=GMnsHEV85i18nXqtnctK+aBOGvJSHHdh/Q6wqIWzMUjwo+PhL4Rzq3GeEWCVNk ULA1eifGYHc2ZvbvDDMUp36z67QOGv7OHDfb5fGBfjh2i3ZbIt4pPdbgP9LYzgGc h3eUp5/GqAzaCx7qYvkehX/e6tt1IqAR8RRFoUDyuQpkU= Received: from dragon (unknown [183.213.196.225]) by smtp1 (Coremail) with SMTP id ClUQrADHz0MRtQZmCxhkAQ--.16042S3; Fri, 29 Mar 2024 20:33:22 +0800 (CST) Date: Fri, 29 Mar 2024 20:33:21 +0800 From: Shawn Guo To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] dts: arm64: imx8dxl-evk: add lpuart1 and cm40 uart Message-ID: References: <20240305-m4_lpuart-v3-0-592463ef1d22@nxp.com> <20240305-m4_lpuart-v3-4-592463ef1d22@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240305-m4_lpuart-v3-4-592463ef1d22@nxp.com> X-CM-TRANSID: ClUQrADHz0MRtQZmCxhkAQ--.16042S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7CF1rCrW8tr4xZrykXFyDAwb_yoW8Kry5p3 Z3ZFZ5Wr1fJF17AasxGr1xKF45Wan5KayDurnrWrWrCrW5uasFqrsxKr1rGr1vqr13Xw4Y yF1DCr1293ZFg3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j7txhUUUUU= X-Originating-IP: [183.213.196.225] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiDxOwZVnxclwFagAAsg X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240329_053409_314551_F08B7B9E X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2024 at 10:54:58AM -0500, Frank Li wrote: > Add lpuart1 and cm40 uart. > > Signed-off-by: Frank Li > --- > arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 37 +++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > index 2123d431e0613..737bacacc2da1 100644 > --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > @@ -16,6 +16,8 @@ aliases { > mmc0 = &usdhc1; > mmc1 = &usdhc2; > serial0 = &lpuart0; > + serial1 = &lpuart1; > + serial6 = &cm40_lpuart; > }; > > chosen { > @@ -51,6 +53,16 @@ linux,cma { > }; > }; > > + m2_uart1_sel: fixedregulator-101 { Why do we not name the node regulator-xxx just like other fixed regulators? Also not sure what suffix -101 means. Can we name it like regulator-m2uart1sel or something? Shawn > + compatible = "regulator-fixed"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "m2_uart1_sel"; > + gpio = <&pca6416_1 6 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-always-on; > + }; > + > mux3_en: regulator-0 { > compatible = "regulator-fixed"; > regulator-min-microvolt = <3300000>; > @@ -340,6 +352,12 @@ &lpuart0 { > status = "okay"; > }; > > +&lpuart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lpuart1>; > + status = "okay"; > +}; > + > &flexcan2 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_flexcan2>; > @@ -354,6 +372,16 @@ &flexcan3 { > status = "okay"; > }; > > +&cm40_intmux { > + status = "disabled"; > +}; > + > +&cm40_lpuart { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_cm40_lpuart>; > + status = "disabled"; > +}; > + > &lsio_gpio4 { > status = "okay"; > }; > @@ -595,6 +623,15 @@ IMX8DXL_UART0_TX_ADMA_UART0_TX 0x06000020 > >; > }; > > + pinctrl_lpuart1: lpuart1grp { > + fsl,pins = < > + IMX8DXL_UART1_TX_ADMA_UART1_TX 0x06000020 > + IMX8DXL_UART1_RX_ADMA_UART1_RX 0x06000020 > + IMX8DXL_UART1_RTS_B_ADMA_UART1_RTS_B 0x06000020 > + IMX8DXL_UART1_CTS_B_ADMA_UART1_CTS_B 0x06000020 > + >; > + }; > + > pinctrl_usdhc1: usdhc1grp { > fsl,pins = < > IMX8DXL_EMMC0_CLK_CONN_EMMC0_CLK 0x06000041 > > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel