From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F3C5C6FD1F for ; Sat, 30 Mar 2024 15:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/l7G1Xu9Pkw8hoARlmfveyp+oL0d7EwDfpwcN9GqiNY=; b=pi2ULzOa+C6vRT ykdCVXrjw0duDfhXmZTwNJSxlo1KykFG9/594Nd9S9Hao4EN2vmUvRoDQ0ZbuvKxGb490cMvb6X1l KmTVFoKIEU98wv6sxAIR0pY0zh5oV92zVCOQSNpuFJ5Azhsu6qF3wNz98vFebrW4mNA/ohAwpLhR3 DE4l9QaUQ28WIqqD4XV8pDTjl+CE6WOLveNMmSuoDsomXzV3CanBz3llZWVs/VnyC7C9hCbMdWvA0 BzZfMjWr/MDrGPNJJmdz7srEN0lU30vGr4OdIjKM8N5fXhLvH5t6vpTb1J7NyCtdtBt6sQhaD+9yL z6Q3zMXx2GZqU1hRx6XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqaCA-00000003fBD-3pOG; Sat, 30 Mar 2024 15:00:34 +0000 Received: from mail-177132.yeah.net ([123.58.177.132]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqaC7-00000003f9p-1QcE for linux-arm-kernel@lists.infradead.org; Sat, 30 Mar 2024 15:00:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=RxaF8TkWhlnlwjvCnhKUHNDn2G5e8bYdQQRjBXH51b4=; b=bCb7qoaX1TiksdYOCBMLdtpivJtTEZUjgH/6t1P10j/QZn8Sux/X9hnm7cAuyL ww7e/gO2panbHn4YEWLFloIEDxhQOYQ+xnGlE0M0jD4H4dP0XTssOzeRaqTMQ7we eashzqvYmSSYyfSpFBGXRnf5+uVbyxKUgXes4v4aE3+N0= Received: from dragon (unknown [183.213.196.225]) by smtp2 (Coremail) with SMTP id C1UQrAD3X4TPKAhm88N4Ag--.46810S3; Sat, 30 Mar 2024 22:59:29 +0800 (CST) Date: Sat, 30 Mar 2024 22:59:27 +0800 From: Shawn Guo To: Robin Murphy Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Will Deacon , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-perf-users@vger.kernel.org, jialong.yang@shingroup.cn, Russell King , Shawn Guo , Sascha Hauer Subject: Re: [PATCH 10/10] ARM: Use common uncore PMU capabilities Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CM-TRANSID: C1UQrAD3X4TPKAhm88N4Ag--.46810S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxCFW8CF4xAw13ArykGr4fAFb_yoW5Xry3p3 4xAwnIyF10gw17Xas8AF4qv3WFvwnYgrWqqw15ua4Fvw10k3y3XF1UKw1rZw15JFW8Aw4I yw10vFWUZ34UZaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jwwIDUUUUU= X-Originating-IP: [183.213.196.225] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiFRGxZV6NnBG+IQAAsR X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240330_080032_007839_FA228DDB X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 12, 2024 at 05:34:12PM +0000, Robin Murphy wrote: > Switch the ARM system PMU drivers over to the new common capabilities, > allowing to remove all the checks that perf core now takes care of. > > CC: Russell King > CC: Shawn Guo > CC: Sascha Hauer > Signed-off-by: Robin Murphy > --- > arch/arm/mach-imx/mmdc.c | 16 +--------------- Acked-by: Shawn Guo > arch/arm/mm/cache-l2x0-pmu.c | 12 +----------- > 2 files changed, 2 insertions(+), 26 deletions(-) > > diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c > index 444a7eaa320c..806ab6675b37 100644 > --- a/arch/arm/mach-imx/mmdc.c > +++ b/arch/arm/mach-imx/mmdc.c > @@ -280,20 +280,6 @@ static int mmdc_pmu_event_init(struct perf_event *event) > struct mmdc_pmu *pmu_mmdc = to_mmdc_pmu(event->pmu); > int cfg = event->attr.config; > > - if (event->attr.type != event->pmu->type) > - return -ENOENT; > - > - if (is_sampling_event(event) || event->attach_state & PERF_ATTACH_TASK) > - return -EOPNOTSUPP; > - > - if (event->cpu < 0) { > - dev_warn(pmu_mmdc->dev, "Can't provide per-task data!\n"); > - return -EOPNOTSUPP; > - } > - > - if (event->attr.sample_period) > - return -EINVAL; > - > if (cfg < 0 || cfg >= MMDC_NUM_COUNTERS) > return -EINVAL; > > @@ -445,7 +431,7 @@ static int mmdc_pmu_init(struct mmdc_pmu *pmu_mmdc, > .start = mmdc_pmu_event_start, > .stop = mmdc_pmu_event_stop, > .read = mmdc_pmu_event_update, > - .capabilities = PERF_PMU_CAP_NO_EXCLUDE, > + .capabilities = PERF_PMU_UNCORE_CAPS, > }, > .mmdc_base = mmdc_base, > .dev = dev, > diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c > index 993fefdc167a..a2567d953fdb 100644 > --- a/arch/arm/mm/cache-l2x0-pmu.c > +++ b/arch/arm/mm/cache-l2x0-pmu.c > @@ -295,16 +295,6 @@ static int l2x0_pmu_event_init(struct perf_event *event) > { > struct hw_perf_event *hw = &event->hw; > > - if (event->attr.type != l2x0_pmu->type) > - return -ENOENT; > - > - if (is_sampling_event(event) || > - event->attach_state & PERF_ATTACH_TASK) > - return -EINVAL; > - > - if (event->cpu < 0) > - return -EINVAL; > - > if (event->attr.config & ~L2X0_EVENT_CNT_CFG_SRC_MASK) > return -EINVAL; > > @@ -524,7 +514,7 @@ static __init int l2x0_pmu_init(void) > .del = l2x0_pmu_event_del, > .event_init = l2x0_pmu_event_init, > .attr_groups = l2x0_pmu_attr_groups, > - .capabilities = PERF_PMU_CAP_NO_EXCLUDE, > + .capabilities = PERF_PMU_UNCORE_CAPS, > }; > > l2x0_pmu_reset(); > -- > 2.39.2.101.g768bb238c484.dirty > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel