From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97CBACD1284 for ; Tue, 2 Apr 2024 08:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=noiFJUxNaTIb7zreo3DnDZL5Reds4tlSHrAHKDpJYhQ=; b=FxC+is+HXNPUIN 5dBh9ECjbRf6sw0KQPhZ7gaTn2Yoy70BylaLa/PHWp39+dmDGzlygrDyilWdPQd+8AG5j4uJm+TmB Y4CNx/0yhcQ/y6Psi3SgRzgXLRq9CYatmKYfdQIBstreAdeCUKJ/3ifHsbTRO+yuMnW7OThY0MJ0W 5V7lz46BTC6Y4Nfnuho6ApLEryvnNdYqUb0Hd5Uk31oJZbpwY/vv1lyWlel6FKUTEyP7pfXczGbxt egKFuBdgSiF49Hdbl9e88OPYi34toTOgpXU0cs/q8cOxk640LqYUu1lPMgMVBxfzbwyZ+Kbo19K2i DBXUWqpqqplqjsVn700w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrZYP-0000000AF88-2Ghe; Tue, 02 Apr 2024 08:31:37 +0000 Received: from mail-177132.yeah.net ([123.58.177.132]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrZYL-0000000AF5o-1cMY for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 08:31:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=apDFZqziJ/YmD7Ot7Oe3WRkx6S7TtVnUEW5HigajFNQ=; b=MPya0UeM93328C53lUb1OqxrBn1MIbsPSHF2ROH7rduicC9q5sWhS3XxMlyaRg SYc71SweFvwm6blXbyMfulQq1QJqg3Vlly6w8VKH06Lq4WvbcR3Zi4M2sckJ7Vgn algtmVHN6I+ViYDjDlS8LcAQlGXAUR9MWLOA3KxUyg/6s= Received: from dragon (unknown [223.68.79.243]) by smtp2 (Coremail) with SMTP id C1UQrAAnjxhOwgtmy4WnAg--.42039S3; Tue, 02 Apr 2024 16:31:12 +0800 (CST) Date: Tue, 2 Apr 2024 16:31:10 +0800 From: Shawn Guo To: Xu Yang Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, peter.chen@kernel.org, jun.li@nxp.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 02/11] arm64: dts: imx8ulp: add usb nodes Message-ID: References: <20240321081439.541799-1-xu.yang_2@nxp.com> <20240321081439.541799-2-xu.yang_2@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240321081439.541799-2-xu.yang_2@nxp.com> X-CM-TRANSID: C1UQrAAnjxhOwgtmy4WnAg--.42039S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxGF1kArWrtFy8JFWfJr1kKrg_yoW5CF1rp3 4DGFZ5Wr48ur17KFWYvF1qkF95JayrCF95ZF1ay3y8tr9F934Ut340q3ZYgr15Zr4xZw4a qFn3WF1fKF1qvw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jrhL8UUUUU= X-Originating-IP: [223.68.79.243] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiFRG0ZV6NnBkz1gAAsm X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_013133_988797_20118F85 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 21, 2024 at 04:14:30PM +0800, Xu Yang wrote: > Add USB nodes on i.MX8ULP platform which has 2 USB controllers. > > Signed-off-by: Xu Yang > > --- > Changes in v2: > - no changes > Changes in v3: > - no changes > Changes in v4: > - no changes > Changes in v5: > - no changes > Changes in v6: > - drop usbphy aliases > Changes in v7: > - no changes > Changes in v8: > - no changes > Changes in v9: > - no changes > Changes in v10: > - no changes > --- > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > index c4a0082f30d3..7da9461a5745 100644 > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > @@ -472,6 +472,68 @@ usdhc2: mmc@298f0000 { > status = "disabled"; > }; > > + usbotg1: usb@29900000 { > + compatible = "fsl,imx8ulp-usb", "fsl,imx7ulp-usb", "fsl,imx6ul-usb"; > + reg = <0x29900000 0x200>; > + interrupts = ; > + clocks = <&pcc4 IMX8ULP_CLK_USB0>; > + power-domains = <&scmi_devpd IMX8ULP_PD_USB0>; > + phys = <&usbphy1>; > + fsl,usbmisc = <&usbmisc1 0>; > + ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x8>; > + rx-burst-size-dword = <0x8>; > + status = "disabled"; > + }; > + > + usbmisc1: usbmisc@29900200 { > + compatible = "fsl,imx8ulp-usbmisc", "fsl,imx7d-usbmisc", > + "fsl,imx6q-usbmisc"; > + #index-cells = <1>; > + reg = <0x29900200 0x200>; Could you move 'reg' above so that it's after compatible? > + status = "disabled"; > + }; > + > + usbphy1: usb-phy@29910000 { > + compatible = "fsl,imx8ulp-usbphy", "fsl,imx7ulp-usbphy"; > + reg = <0x29910000 0x10000>; > + interrupts = ; > + clocks = <&pcc4 IMX8ULP_CLK_USB0_PHY>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > + usbotg2: usb@29920000 { > + compatible = "fsl,imx8ulp-usb", "fsl,imx7ulp-usb", "fsl,imx6ul-usb"; > + reg = <0x29920000 0x200>; > + interrupts = ; > + clocks = <&pcc4 IMX8ULP_CLK_USB1>; > + power-domains = <&scmi_devpd IMX8ULP_PD_USDHC2_USB1>; > + phys = <&usbphy2>; > + fsl,usbmisc = <&usbmisc2 0>; > + ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x8>; > + rx-burst-size-dword = <0x8>; > + status = "disabled"; > + }; > + > + usbmisc2: usbmisc@29920200 { > + compatible = "fsl,imx8ulp-usbmisc", "fsl,imx7d-usbmisc", > + "fsl,imx6q-usbmisc"; > + #index-cells = <1>; > + reg = <0x29920200 0x200>; Ditto Shawn > + status = "disabled"; > + }; > + > + usbphy2: usb-phy@29930000 { > + compatible = "fsl,imx8ulp-usbphy", "fsl,imx7ulp-usbphy"; > + reg = <0x29930000 0x10000>; > + interrupts = ; > + clocks = <&pcc4 IMX8ULP_CLK_USB1_PHY>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > fec: ethernet@29950000 { > compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec", "fsl,imx6q-fec"; > reg = <0x29950000 0x10000>; > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel