From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E101EC6FD1F for ; Tue, 2 Apr 2024 08:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j1oee2KOMSRIYhcOmasqpwdpolcVefNP0Xe9l2AgiDM=; b=v/JdhZ+W9ea4fa Hm/f7Pg2Akak/DtGkylQw4GmqcT2pixE280S9bDpNW/Qu7w8BtFsR5mEUmowGl9kWl9iY7NAflP2U VJxD/ete+hwg9XuxhM2TFpzEXZi+V7zp/Xk0ybLFWRJZSj5nCrCoWf8eNcWBJ6jmtRwnh4nIUkgfM O+d1oG0mi6bC11EDjI0cVEa9Z0cHExJ8CQKRaXB6v76Q0EVK2T6MvoBGlAmFhi5UqTPb3QnIk892N aV0dD/Y6IL/4Ux8sBpkox3V+IA9GxxuyuL6XLH6ERTUTIITMHzRhqjDIlclH0sLrOxzluuWaJ4UcW xvqik+rjw6sY1o7tQ9GA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrZcN-0000000AGfe-0uHM; Tue, 02 Apr 2024 08:35:43 +0000 Received: from mail-177131.yeah.net ([123.58.177.131]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrZcJ-0000000AGdD-3Q3C for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 08:35:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=M3q2o7D5pZ85OztyvHOJ0Lrj1x7gKAWNHO9XsIQgyCI=; b=WY7ZjIS1JceGpx3YMaJsQUOcbU7LHMV+fdhIi/fMaWrsVj/fiPhLOunx6UDLSf SrX8WUN9X9uhFkcNlO4kuVlwUvI3uZkY70qlfT+uRmcgDI4gaNxELGkmSkWgdcBq 02hgY6gnV0xqhxnRJIKL8cehVJoHwlNkrY4zHZzfgB05A= Received: from dragon (unknown [223.68.79.243]) by smtp1 (Coremail) with SMTP id ClUQrADX_0ZMwwtm6q+iAQ--.45423S3; Tue, 02 Apr 2024 16:35:25 +0800 (CST) Date: Tue, 2 Apr 2024 16:35:24 +0800 From: Shawn Guo To: Xu Yang Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, peter.chen@kernel.org, jun.li@nxp.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 03/11] arm64: dts: imx8ulp-evk: enable usb nodes and add ptn5150 nodes Message-ID: References: <20240321081439.541799-1-xu.yang_2@nxp.com> <20240321081439.541799-3-xu.yang_2@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240321081439.541799-3-xu.yang_2@nxp.com> X-CM-TRANSID: ClUQrADX_0ZMwwtm6q+iAQ--.45423S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxGw47AFyktw1fuFWfJr13Jwb_yoW5XFWkpr 9rGrsxXw17WF47KF98JrnxKr93Jan3Gr97uw12g340kr1Du347Jr10grn5Wrs8ur43Xw4a yFsYgrW2grnF9wUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jseOLUUUUU= X-Originating-IP: [223.68.79.243] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiDQ20ZVszXX09xgAAsi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_013540_287533_6BE836F5 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 21, 2024 at 04:14:31PM +0800, Xu Yang wrote: > Enable 2 USB nodes and add 2 PTN5150 nodes on i.MX8ULP evk board. > > Signed-off-by: Xu Yang > > --- > Changes in v2: > - fix format as suggusted by Fabio > - add PTN5150 nodes > Changes in v3: > - no changes > Changes in v4: > - no changes > Changes in v5: > - no changes > Changes in v6: > - no changes > Changes in v7: > - no changes > Changes in v8: > - no changes > Changes in v9: > - no changes > Changes in v10: > - no changes > --- > arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts > index 69dd8e31027c..bf418af31039 100644 > --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts > @@ -133,6 +133,64 @@ pcal6408: gpio@21 { > gpio-controller; > #gpio-cells = <2>; > }; > + > + ptn5150_1: typec@1d { Could you sort devices in unit-address? > + compatible = "nxp,ptn5150"; > + reg = <0x1d>; > + int-gpios = <&gpiof 3 IRQ_TYPE_EDGE_FALLING>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_typec1>; > + status = "disabled"; > + }; > + > + ptn5150_2: typec@3d { > + compatible = "nxp,ptn5150"; > + reg = <0x3d>; > + int-gpios = <&gpiof 5 IRQ_TYPE_EDGE_FALLING>; > + pinctrl-names = "default"; Broken indent? Shawn > + pinctrl-0 = <&pinctrl_typec2>; > + status = "disabled"; > + }; > +}; > + > +&usbotg1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb1>; > + dr_mode = "otg"; > + hnp-disable; > + srp-disable; > + adp-disable; > + over-current-active-low; > + status = "okay"; > +}; > + > +&usbphy1 { > + fsl,tx-d-cal = <110>; > + status = "okay"; > +}; > + > +&usbmisc1 { > + status = "okay"; > +}; > + > +&usbotg2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb2>; > + dr_mode = "otg"; > + hnp-disable; > + srp-disable; > + adp-disable; > + over-current-active-low; > + status = "okay"; > +}; > + > +&usbphy2 { > + fsl,tx-d-cal = <110>; > + status = "okay"; > +}; > + > +&usbmisc2 { > + status = "okay"; > }; > > &usdhc0 { > @@ -224,6 +282,32 @@ MX8ULP_PAD_PTE13__LPI2C7_SDA 0x20 > >; > }; > > + pinctrl_typec1: typec1grp { > + fsl,pins = < > + MX8ULP_PAD_PTF3__PTF3 0x3 > + >; > + }; > + > + pinctrl_typec2: typec2grp { > + fsl,pins = < > + MX8ULP_PAD_PTF5__PTF5 0x3 > + >; > + }; > + > + pinctrl_usb1: usb1grp { > + fsl,pins = < > + MX8ULP_PAD_PTF2__USB0_ID 0x10003 > + MX8ULP_PAD_PTF4__USB0_OC 0x10003 > + >; > + }; > + > + pinctrl_usb2: usb2grp { > + fsl,pins = < > + MX8ULP_PAD_PTD23__USB1_ID 0x10003 > + MX8ULP_PAD_PTF6__USB1_OC 0x10003 > + >; > + }; > + > pinctrl_usdhc0: usdhc0grp { > fsl,pins = < > MX8ULP_PAD_PTD1__SDHC0_CMD 0x3 > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel