linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx7s-warp: Fix OV2680 supply names
@ 2024-03-23 12:53 Fabio Estevam
  2024-04-02 10:58 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2024-03-23 12:53 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, rmfrfs, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Fix the OV2680 supply names according to ovti,ov2680.yaml.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
index ba7231b364bb..c26888b7af3f 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
@@ -201,9 +201,9 @@ ov2680: camera@36 {
 		clocks = <&osc>;
 		clock-names = "xvclk";
 		reset-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
-		DOVDD-supply = <&sw2_reg>;
-		DVDD-supply = <&sw2_reg>;
-		AVDD-supply = <&reg_peri_3p15v>;
+		dovdd-supply = <&sw2_reg>;
+		dvdd-supply = <&sw2_reg>;
+		avdd-supply = <&reg_peri_3p15v>;
 
 		port {
 			ov2680_to_mipi: endpoint {
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx7s-warp: Fix OV2680 supply names
  2024-03-23 12:53 [PATCH] ARM: dts: imx7s-warp: Fix OV2680 supply names Fabio Estevam
@ 2024-04-02 10:58 ` Shawn Guo
  2024-04-02 11:11   ` Fabio Estevam
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2024-04-02 10:58 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: shawnguo, linux-arm-kernel, rmfrfs, Fabio Estevam

On Sat, Mar 23, 2024 at 09:53:27AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Fix the OV2680 supply names according to ovti,ov2680.yaml.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Do we want to have a Fixes tag for it?

Shawn

> ---
>  arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
> index ba7231b364bb..c26888b7af3f 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
> @@ -201,9 +201,9 @@ ov2680: camera@36 {
>  		clocks = <&osc>;
>  		clock-names = "xvclk";
>  		reset-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
> -		DOVDD-supply = <&sw2_reg>;
> -		DVDD-supply = <&sw2_reg>;
> -		AVDD-supply = <&reg_peri_3p15v>;
> +		dovdd-supply = <&sw2_reg>;
> +		dvdd-supply = <&sw2_reg>;
> +		avdd-supply = <&reg_peri_3p15v>;
>  
>  		port {
>  			ov2680_to_mipi: endpoint {
> -- 
> 2.34.1
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx7s-warp: Fix OV2680 supply names
  2024-04-02 10:58 ` Shawn Guo
@ 2024-04-02 11:11   ` Fabio Estevam
  0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-04-02 11:11 UTC (permalink / raw)
  To: Shawn Guo; +Cc: shawnguo, linux-arm-kernel, rmfrfs, Fabio Estevam

Hi Shawn,

On Tue, Apr 2, 2024 at 7:58 AM Shawn Guo <shawnguo2@yeah.net> wrote:
>
> On Sat, Mar 23, 2024 at 09:53:27AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > Fix the OV2680 supply names according to ovti,ov2680.yaml.
> >
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
>
> Do we want to have a Fixes tag for it?

Please discard this patch.

I noticed that the driver uses DOVDD, DVDD, and AVDD as supply names.

The regulators uses on imx7s-warp are marked as 'regulator-always-on'
so we don't see the issue in practice.

I will update the bindings instead.

Thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-02 12:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-23 12:53 [PATCH] ARM: dts: imx7s-warp: Fix OV2680 supply names Fabio Estevam
2024-04-02 10:58 ` Shawn Guo
2024-04-02 11:11   ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).