From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B67DC6FD1F for ; Tue, 2 Apr 2024 10:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rsm/aceObE1domq9meZxdf+6iu+6XpwEDIxi1l17tSs=; b=Z573/e4Tms2Wj+ 8pAkA6Yve4+el392HVA9nf1LZ60Ya5lo4AXaTYti9yvIZj1yRBd9JdKPDwHS/PtTJUCP1VBMysRIL 6e7kPUNBYXFnyIsXbEw4pqW5rG8cciEtqmZRE50qY/Rgy1zLJyAZ8rxEGwB0Ms5TymC6ecOsjFU9+ fvBg6V0yHYPP4A7XM0FV8whASS6wArf6QQQzoNI5407nXzMDZ3WlDadRESDeX2mzjQOr6bEuxcDNQ 6eI5ciMEUHADzVQSGsZJ4BMeMbim9dK8qZNwSGkmjj1SXxewpj95AuGXY4KrIaXstyP7v2iqwmbh3 lkJ+i5baqBII+VVJg/GQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrboU-0000000AkcG-1NRX; Tue, 02 Apr 2024 10:56:22 +0000 Received: from mail-177131.yeah.net ([123.58.177.131]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrboQ-0000000AkbV-48De for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 10:56:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=HL6yYIAfmTq4orQz8KSraMu08Ey5PkjYaek7rExViLg=; b=VNu7cS6INVdcwM+6pNaYKAjz3A2GHUDmyqhZWbK0VIuHzo3qOD2TYP6ttmW+WW 5G48e74VnTMRoqYxj503QRPPyOYOO2x1V4SqFTj2ev6EzArNOowif4jDTu27L7hS Or5iqK9IVHUewtXmEY/uHA73Qu626ycrTUftGDkl05PNk= Received: from dragon (unknown [223.68.79.243]) by smtp1 (Coremail) with SMTP id ClUQrAD3HyBE5AtmXiWkAQ--.64379S3; Tue, 02 Apr 2024 18:56:05 +0800 (CST) Date: Tue, 2 Apr 2024 18:56:04 +0800 From: Shawn Guo To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dong Aisheng , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list Subject: Re: [PATCH 1/1] arm64: dts: imx8-ss-conn: fix usdhc wrong lpcg clock order Message-ID: References: <20240322164706.2626088-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240322164706.2626088-1-Frank.Li@nxp.com> X-CM-TRANSID: ClUQrAD3HyBE5AtmXiWkAQ--.64379S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF1rZr43Aw4DJryfAFWrKrg_yoWkKwb_Xw 18Xrn5KFZrurZayF95ArWxu3y8K3W7Ar1UJas2yr4xXF98G3yUCr1UJ3yrurn8WFnFqws8 AF4DJrWkJryS9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0kwIDUUUUU== X-Originating-IP: [223.68.79.243] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiDQe0ZVszXX2VXgAAsY X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_035619_480776_7E398E03 X-CRM114-Status: UNSURE ( 8.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 22, 2024 at 12:47:05PM -0400, Frank Li wrote: > The actual clock show wrong frequency: > > echo on >/sys/devices/platform/bus\@5b000000/5b010000.mmc/power/control > cat /sys/kernel/debug/mmc0/ios > > clock: 200000000 Hz > actual clock: 166000000 Hz > ^^^^^^^^^ > ..... > > According to > > sdhc0_lpcg: clock-controller@5b200000 { > compatible = "fsl,imx8qxp-lpcg"; > reg = <0x5b200000 0x10000>; > #clock-cells = <1>; > clocks = <&clk IMX_SC_R_SDHC_0 IMX_SC_PM_CLK_PER>, > <&conn_ipg_clk>, <&conn_axi_clk>; > clock-indices = , , > ; > clock-output-names = "sdhc0_lpcg_per_clk", > "sdhc0_lpcg_ipg_clk", > "sdhc0_lpcg_ahb_clk"; > power-domains = <&pd IMX_SC_R_SDHC_0>; > } > > "per_clk" should be IMX_LPCG_CLK_0 instead of IMX_LPCG_CLK_5. > > After correct clocks order: > > echo on >/sys/devices/platform/bus\@5b000000/5b010000.mmc/power/control > cat /sys/kernel/debug/mmc0/ios > > clock: 200000000 Hz > actual clock: 198000000 Hz > ^^^^^^^^ > ... > > Fixes: 16c4ea7501b1 ("arm64: dts: imx8: switch to new lpcg clock binding") > Signed-off-by: Frank Li Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel