From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1BEDC4345F for ; Wed, 17 Apr 2024 16:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qrTm2cJAVygeuioPwSijAZRO0sLXm0d2mqTEGB84+v0=; b=f8I3jcqZGQ4qsF bb4rP3uKj2wru9MVc+DdcTwlii3gfYqUIcnSG03Fjcczu2WIKf22UuYGBtXsq8yyJhnx2TFd+gCD0 QpOoOvRqmJJbgcIh833AXTq4itCZXkc0HfHqDSzaGwYzG9nYl3AJgmD6N/ncgE8LF4YM4QlYhXeV/ Xl1UYAgin41imqh7P4qseoqznXejgBnISpWxrtl7hfeUezdUYtPFnN0nehFB2ZvIEug2kLMKPgmS4 rY1hpPq8ygloGaLSJW3GI/CEiqlXMEtb8syQEBVV+XntY7DorYLRKkYzXPcxJ03uoCqoSav3UtTHf Gop59UCvWgpn+dm1TOiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7mU-0000000GjZ4-20OV; Wed, 17 Apr 2024 16:05:06 +0000 Received: from mail-mw2nam10on20601.outbound.protection.outlook.com ([2a01:111:f403:2412::601] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7mO-0000000GjXf-33S3 for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 16:05:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JH6Ij7uwfPmHf3viH7FY/wPll/J4Ud7q2RFkeJnLYyIKhkcF1luFiFHdgZrnQ2vUy4lFYZefif3U34PsXc3TtvUHWxNoC4IUh32cWnugT/Ug9NoHkIi/Zl6TNKeTyN/GVnfMDVliu936evWfaIMczpsS/c2TB4KbQCJdtsh/O8/xbFn9T1IOJAP9DKABXZlLJdBeB00gNP3WwFysiUD9jx4Cdx6/K9kvV/ybCHyt7zb9pcGxFThwmGZ96VpMvGLrl0RsVl7Mjzd7UAf/LdMrFdTjBQZbfh94P/oUqi4MosoqvFNGvP4NrfBPwb61m1qkBnMSk/YNRym4k09sUtKzaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MXkbvfxw18aZGwx8uo1EkVljC8dDRPeFp4ddLk8wGz4=; b=ApFiW4Zyc/ibhGEizXDrVwi59RGqJ/rc2vOb5uTkqEArs7hls5m5cpikiA4+n6gGJjteYDp5y2oWurbd6wMNpFhbOZ+WB+U/d41dnifeW+pQQSeWTkVUd2RQiphKU630F+MolVOhnEv0Yf5/cNmoXKF6Z2lU+WRdxMDN0XYmzQOTpZ88waLSs1l72K+AvOHvGXh2UYnV7DyAc6Hv3tEqn0hESlC1BKOJ5gjZveHYTd1eKCZiVUuLlydhWXozyTO2ca6gqdWCbxjK0wEL5/lakaPo0oXzp9Z1yRM7Kfl4j1J5vQKLupgh8A9xOTxL3h4OAOHnZQl9F9C7/Erw66P6vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MXkbvfxw18aZGwx8uo1EkVljC8dDRPeFp4ddLk8wGz4=; b=TA+d8DIIshFBBg9gnY8MSo0tfrriF4CjoScNBEz3j35bj0qeMmC9SNScvQ+C2jxw1ROsAQQGR7T0T0sXcgNEjxlCTQulgovkNMhcSqXFFB/smg7c6xGw+9+lcl1GmVdIZNwufG0j7GNTGOYltQNnJG/mr99xMjotXX+N5uHlmq1o1BtjjJwympH03zuB9OdV3AG0MvZ+vdJWZpU5Xe+usNeTq3pFvmprsyzzNwYjy62mkKpAxzCX/JZKmm9pQdS7beg8uU7kFcBC2BeScTTp7aKBnJKr+5ZkdPDzAuT+zqfdysTUDR126x/PEovc538D8xlg9NG2r5bId0iLCBJT0A== Received: from MN2PR15CA0018.namprd15.prod.outlook.com (2603:10b6:208:1b4::31) by DS0PR12MB6535.namprd12.prod.outlook.com (2603:10b6:8:c0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Wed, 17 Apr 2024 16:04:51 +0000 Received: from BL02EPF00021F6E.namprd02.prod.outlook.com (2603:10b6:208:1b4:cafe::79) by MN2PR15CA0018.outlook.office365.com (2603:10b6:208:1b4::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.34 via Frontend Transport; Wed, 17 Apr 2024 16:04:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F6E.mail.protection.outlook.com (10.167.249.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Wed, 17 Apr 2024 16:04:50 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 17 Apr 2024 09:04:23 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 17 Apr 2024 09:04:23 -0700 Received: from Asurada-Nvidia (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Wed, 17 Apr 2024 09:04:22 -0700 Date: Wed, 17 Apr 2024 09:04:21 -0700 From: Nicolin Chen To: Shameerali Kolothum Thodi CC: "will@kernel.org" , "robin.murphy@arm.com" , "joro@8bytes.org" , "jgg@nvidia.com" , "thierry.reding@gmail.com" , "vdumpa@nvidia.com" , "jonathanh@nvidia.com" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v5 6/6] iommu/tegra241-cmdqv: Limit CMDs for guest owned VINTF Message-ID: References: <1d68c21591fa4f8497aea0e6a0afda8b@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1d68c21591fa4f8497aea0e6a0afda8b@huawei.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6E:EE_|DS0PR12MB6535:EE_ X-MS-Office365-Filtering-Correlation-Id: 91a7f3a0-95fd-4652-42e3-08dc5ef81cd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AzPgA1r1CYfY0yeRUL1ica1QtT1F2hjVvXeHnmLMZtEzGtbS64nA2plLne0b?= =?us-ascii?Q?/OGHPGNzQ4Z1Z/T/vbyF8MO/Ttnqnu2WPR21u37lWGO7gwUO7GcI0Bs4U+NW?= =?us-ascii?Q?LE5zF1v9hSjUkxk8r+rsf0RmpJGZVVjU69Rqw+hQdvEhIjpsOBr3MYMrcsNz?= =?us-ascii?Q?go9lzbZdgB84A0IW70Abaqy7xPka8NJHbrdkqCAsuIdwJ3JazaQDp9waJ24b?= =?us-ascii?Q?yWVxDEHvvua/UTWNXmDDHlSyFQ/W9AQ9au4n5KMYhhxmTOKdKoEvol3ckoTP?= =?us-ascii?Q?wOZD6Jn+8HQsvi+aVztHJN5U3rGkzwWW+Ob1ePCHOeaivgYMWPb4kcH5sqcN?= =?us-ascii?Q?419V4lAMTkhG+uRrbRALA1Hi54W8QCt+uvm/3ePXhYzmS8zqGJPXPgQtOWL/?= =?us-ascii?Q?+aZ/Gf0UbjzpLq7B7Ks/nHZp5HTNSFqS47ycnov96dN57vwkM/rhn2j/vbwF?= =?us-ascii?Q?1hwBKugai++qzz3UzacEpkHEy3bg9e3lQyhVI1/9mAg/IStEzQ4/veN++nHe?= =?us-ascii?Q?o9sHAzYMmtQH1pgoWNDZ9pZCvMSMDl03bNaQdMwRfKdU1OcCebvFVGv0tXBs?= =?us-ascii?Q?xrgFZxMeHfsWWIoJbNESg2EMGJP8yCOoPQz3c4MCh/LglC0VjzXCwV0tD7Aw?= =?us-ascii?Q?BddpxZpWAIk+9vzQDdbZBzDDbSSSskxeNr23tTKGq5LKMVNqOFSPBVGZ2ECp?= =?us-ascii?Q?dpVUK+qEDqiihOTU/NyeBeLEhixnJDSa267Vzt2WF4FnVDlTw3+9PZwdM/ct?= =?us-ascii?Q?hXD1TazqdY5Sb/Hz8WQuEW2nfXay1C5RZb7tfx9qRbVMCPIxRBhyCsc6tKnx?= =?us-ascii?Q?QefyGFrHuOiHrvfTSMCEDj+LYzB3VRTbpz4txYjg2c+8UaScVNM854miRK6C?= =?us-ascii?Q?36M/Q4qeyGbkKXAecgzGBU+yGzCWs9AGEPPCj5neXrw/PAG9Xn1e86h9dknA?= =?us-ascii?Q?GRmH9j4Rp926Fwkt7H/kzunZao4Tb0X+0bwAuVKdCDSR6wutXU0BYt0jY+T0?= =?us-ascii?Q?YSphpfV+mQHjfSKsFLSh0XIEEq8EaLNJLXFxrQYsApWjzcnvB4EJzzeRaoCn?= =?us-ascii?Q?AD+8RDyNVPoc+W0i7tvoWNhIIu7KdS9pY5Dd9Y6XGgEBft/0Cd54EHdzBXRR?= =?us-ascii?Q?T+2o2Lf4tAM2o7oTpgR3XDnmwb0QC5+JsZ4ZoWWKIQI3QswFYk6Av5Ju3FsX?= =?us-ascii?Q?C1G7Bhivnm62ot9p4QTFQH8s843NYOr2GWUGVHodZLKBdy/tzEnU3zY69azO?= =?us-ascii?Q?r5hftNADSMpqzO4vxLdpahTgu6S1aC9CdLCWSb6OnBRtehphIBXEz2EqoCNy?= =?us-ascii?Q?+EUVx8CpC9EKUgo0IrVLPuyayNeEcmZ4Cq/BpU+9RUhaqXc/WfobZHyiz6ry?= =?us-ascii?Q?0Uc1XHM=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230031)(82310400014)(376005)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 16:04:50.6350 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91a7f3a0-95fd-4652-42e3-08dc5ef81cd7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6535 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_090500_794366_8CECFEEE X-CRM114-Status: GOOD ( 18.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 17, 2024 at 03:12:57PM +0000, Shameerali Kolothum Thodi wrote: > > -----Original Message----- > > From: Nicolin Chen > > Sent: Saturday, April 13, 2024 4:44 AM > > To: will@kernel.org; robin.murphy@arm.com > > Cc: joro@8bytes.org; jgg@nvidia.com; thierry.reding@gmail.com; > > vdumpa@nvidia.com; jonathanh@nvidia.com; linux-kernel@vger.kernel.org; > > iommu@lists.linux.dev; linux-arm-kernel@lists.infradead.org; linux- > > tegra@vger.kernel.org > > Subject: [PATCH v5 6/6] iommu/tegra241-cmdqv: Limit CMDs for guest owned > > VINTF > > > > When VCMDQs are assigned to a VINTF owned by a guest (HYP_OWN bit unset), > > only TLB and ATC invalidation commands are supported by the VCMDQ HW. So, > > add a new helper to scan the input cmds to make sure every single command > > is supported when selecting a queue. > > > > Note that the guest VM shouldn't have HYP_OWN bit being set regardless of > > guest kernel driver writing it or not, i.e. the hypervisor running in the > > host OS should wire this bit to zero when trapping a write access to this > > VINTF_CONFIG register from a guest kernel. > > Just curious, suppose there is a malicious guest with a compromised kernel > which bypasses the HYP_OWN bit check and issues other commands, does > the hardware has the capability to detect it and not make the host unstable > in any way? Only that specific VINTF/VCMDQ would stop and error an IRQ. Even a device command (ATC_INV) would be strictly checked against the Stream ID table that's set at the host level. Thanks Nicolin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel