From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54972C4345F for ; Mon, 15 Apr 2024 14:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c0Q7tOIVTSUP3KtJb+FESUU1DOQks0qCsmNx0XQLztE=; b=SXk89wvO48Ubp3 9I7QePl4mOVtqukOUcDvZZf52a48Zb28LiGuIlz2NIKtuuSUq6uykebo0TmpkBwvVFgvzxaanabOy k4nm06iK/7s6pzow36LeOqOERZw5tVnM7GHNRQ9DHZLXClwGz1Plva+cxfRLwc7xdaup6BmOn3pbv WRtmNAiHzFRvJ0cRiz6Y6BtWYWCGWC6LNq4PPXoFcvXTYVgZntCo8/vn5YSxHv4QsizqBtXQghi/p icG0KF52S4zd82IbIGPYKuYEckhqW3MZ3f+lvWj7YXJN6pQXpHTO4vCw4e7j7QdXTXO76xez/RH0M iJitA3HcKhrSFssW7nCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwN6Q-00000008dx7-3Qkw; Mon, 15 Apr 2024 14:14:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwN6L-00000008dwX-3AIi for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 14:14:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 649992F4; Mon, 15 Apr 2024 07:14:54 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0CDF53F738; Mon, 15 Apr 2024 07:14:23 -0700 (PDT) Date: Mon, 15 Apr 2024 15:14:21 +0100 From: Cristian Marussi To: kernel test robot Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, oe-kbuild-all@lists.linux.dev, sudeep.holla@arm.com, jassisinghbrar@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jonathan.cameron@huawei.com Subject: Re: [PATCH v4 2/2] mailbox: arm_mhuv3: Add driver Message-ID: References: <20240412192801.554464-3-cristian.marussi@arm.com> <202404152144.RtJxmEsQ-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202404152144.RtJxmEsQ-lkp@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_071430_007115_AA8C2F20 X-CRM114-Status: GOOD ( 23.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2024 at 09:56:52PM +0800, kernel test robot wrote: > Hi Cristian, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on robh/for-next] > [also build test ERROR on soc/for-next linus/master v6.9-rc4 next-20240415] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Cristian-Marussi/dt-bindings-mailbox-arm-mhuv3-Add-bindings/20240415-094106 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > patch link: https://lore.kernel.org/r/20240412192801.554464-3-cristian.marussi%40arm.com > patch subject: [PATCH v4 2/2] mailbox: arm_mhuv3: Add driver > config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240415/202404152144.RtJxmEsQ-lkp@intel.com/config) > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240415/202404152144.RtJxmEsQ-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202404152144.RtJxmEsQ-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > drivers/mailbox/arm_mhuv3.c: In function 'mhuv3_mbx_comb_interrupt': > >> drivers/mailbox/arm_mhuv3.c:922:17: error: cleanup argument not a function > 922 | void *data __free(kfree) = NULL; > | ^~~~ Right, I suppose is missing slab.h to define kfree now that it is using cleanup.h. I'll fix in V5, after some more possible feedback comes in... Thanks, Cristian > > > vim +922 drivers/mailbox/arm_mhuv3.c > > 910 > 911 static irqreturn_t mhuv3_mbx_comb_interrupt(int irq, void *arg) > 912 { > 913 unsigned int i, found = 0; > 914 struct mhuv3 *mhu = arg; > 915 struct mbox_chan *chan; > 916 struct device *dev; > 917 int ret = IRQ_NONE; > 918 > 919 dev = mhu->mbox.dev; > 920 for (i = 0; i < NUM_EXT; i++) { > 921 struct mhuv3_mbox_chan_priv *priv; > > 922 void *data __free(kfree) = NULL; > 923 > 924 if (!mhu->ext[i]) > 925 continue; > 926 > 927 /* Process any extension which could be source of the IRQ */ > 928 chan = mhu->ext[i]->chan_from_comb_irq_get(mhu); > 929 if (IS_ERR(chan)) > 930 continue; > 931 > 932 found++; > 933 /* From here on we need to call rx_complete even on error */ > 934 priv = chan->con_priv; > 935 if (!chan->cl) { > 936 dev_warn(dev, "RX Data on UNBOUND channel (%u)\n", > 937 priv->ch_idx); > 938 goto rx_ack; > 939 } > 940 > 941 /* Read optional in-band LE data first. */ > 942 if (priv->ops->read_data) { > 943 data = priv->ops->read_data(mhu, chan); > 944 if (IS_ERR(data)) { > 945 dev_err(dev, > 946 "Failed to read in-band data. err:%ld\n", > 947 PTR_ERR(no_free_ptr(data))); > 948 goto rx_ack; > 949 } > 950 } > 951 > 952 mbox_chan_received_data(chan, data); > 953 ret = IRQ_HANDLED; > 954 > 955 /* > 956 * Acknowledge transfer after any possible optional > 957 * out-of-band data has also been retrieved via > 958 * mbox_chan_received_data(). > 959 */ > 960 rx_ack: > 961 if (priv->ops->rx_complete) > 962 priv->ops->rx_complete(mhu, chan); > 963 } > 964 > 965 if (found == 0) > 966 dev_warn_once(dev, "Failed to find channel for the RX interrupt\n"); > 967 > 968 return ret; > 969 } > 970 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel