From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A665C4345F for ; Tue, 16 Apr 2024 09:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eMh7VafopH487uGHQg8iOhijs0iWvtniaUeISJ6knWQ=; b=YN2VbN/4b0o8Bf 2jf2fwURrgsZ7J8o9DeBd6TTGe0Xd/B3FrmWT+6Q5J5d0Mlr2Bn6Bpmhr/+bBXnu8LZ43Ag5np39B HRYsD8HyP+ffFiK4AojwFlIz+M1le/Ez9ksEeRUmy2Nb6VZ1wTqN9XFDca8XC9VEpagubg1+okBtA t/0hWPIBK/UXKrhdhX3ZgLjs1jNlrKgof0TVM3Q29yfY2HYiHDLUwWFZS0kYR+bpB8nt0VhR7wrZE MIrgbJlGkG0kN/3N0CTLjFyU+O5llR6h/5aFNYSO+iSOXEBLvkjdsFalmLrGDAYBgWVj9ZJ/re5fW DfHHo6XuswrUfFFBfMuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwetJ-0000000BZQd-1CSp; Tue, 16 Apr 2024 09:14:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwetG-0000000BZQ7-3bNj for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2024 09:14:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D6D5339; Tue, 16 Apr 2024 02:14:36 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37B373F792; Tue, 16 Apr 2024 02:14:07 -0700 (PDT) Date: Tue, 16 Apr 2024 10:14:04 +0100 From: Sudeep Holla To: "Peng Fan (OSS)" Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH] firmware: arm_scmi: power_control: support suspend command Message-ID: References: <20240415101141.1591112-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240415101141.1591112-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_021410_963756_C729C723 X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2024 at 06:11:41PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Support System suspend notification. Using a work struct to call > pm_suspend. There is no way to pass suspend level to pm_suspend, > so use MEM as of now. > While the change itself is simple and no-controversial, I am bit worried about: 1. The choice of S2R(MEM) by default - not sure if different system prefer different things. The userspace can configure whatever default behaviour expected as S2R IIUC, so should be OK. I need to check though. 2. The userspace needs to keep the wakeup source enabled always which I need to check if it is feasible on all the platforms. If wakeups are not configured properly and suspend is triggered, the system can never resume back. We may need to mention above points at-least as part of commit log. I would wait for some feedback from SCMI users. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel