From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC8ACCD11C2 for ; Fri, 5 Apr 2024 14:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TF+XYwg4nrk48hUckrZ17USUve1g4xc2ZicoP/aRk7s=; b=vM8Kz8MPeEh+0y Wu+A9+ViEurK8tuWsrlIpIS1zYKz1iuAQDD2MAXMx+V1TuzXKgLV6+x5e9Pj5mV3Q4Wke+mtDjJA+ GFvJGTd+e+xLcjFcGWlku2SrrATLld3fo7AVkGtAZBsILXYn5Q2sJh9b3g4oL2kQq+QEUhZacUlkq 64Repxwaye04QXkWr+qKH4BD9Pr96BeueH3dsb94mod/yFc9H3gXczYRNxrYE8rESWZXn5ne4qTDx R33pfCqBnabVyhezGBaB9uCr4bRMCyqzxtVV/pVkCqiegScOPNCl4a7K3djIlC3XUmZvMnYvXo5W3 3oQsRJN5Q6o/KeAKX52g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rskUx-00000007RYe-3K38; Fri, 05 Apr 2024 14:24:55 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rskUv-00000007RY3-0o7G; Fri, 05 Apr 2024 14:24:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5D57ACE337D; Fri, 5 Apr 2024 14:24:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A85AAC433C7; Fri, 5 Apr 2024 14:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712327090; bh=9u276kZaHIRoTA4fadL2lfzY0PJaTWAhflWuDXQc7KI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eltXqxIseJTpiuRAJ13spAdHEBB1EkmRpmBqdjP6Uehu/d9KdmHKmpaLerp6rcb1b ytDBJQ9mj8iYPDlAFMU+rbHbI7B2A8Dr21YQV5p+SLT9bq/BLo1HPCnJfXavCO/sUD 6OTWC0kWWTQefiM8pVw61K31PavRnvXPa4a70nAJN7WnIQKT+hl3ylfcO4+L5O9/FT 01vmrmu0p3OPsUPjB0zEVjw7EglL8QZBLzv97TXIquUwe29e9IJw8PdTBlDh7jqG0B YEj5U8jtyTF0LwOlnHvMtkjYZnV0BpVaMaTgGCz7MrGdazCCg4SuYfSnMLyrUHnzed boUmhxbFl0yxg== Date: Fri, 5 Apr 2024 19:54:46 +0530 From: Vinod Koul To: Maxime Ripard Cc: Alexander Stein , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Maarten Lankhorst , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sandor Yu , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com, Dmitry Baryshkov Subject: Re: [PATCH v15 2/8] phy: Add HDMI configuration options Message-ID: References: <20240306101625.795732-1-alexander.stein@ew.tq-group.com> <20240306101625.795732-3-alexander.stein@ew.tq-group.com> <20240306-inquisitive-funny-bull-017550@houat> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240306-inquisitive-funny-bull-017550@houat> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_072453_600985_05300A10 X-CRM114-Status: GOOD ( 24.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06-03-24, 15:48, Maxime Ripard wrote: > Hi Alexander, > > On Wed, Mar 06, 2024 at 11:16:19AM +0100, Alexander Stein wrote: > > From: Sandor Yu > > > > Allow HDMI PHYs to be configured through the generic > > functions through a custom structure added to the generic union. > > > > The parameters added here are based on HDMI PHY > > implementation practices. The current set of parameters > > should cover the potential users. > > > > Signed-off-by: Sandor Yu > > Reviewed-by: Dmitry Baryshkov > > Acked-by: Vinod Koul > > --- > > include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++ > > include/linux/phy/phy.h | 7 ++++++- > > 2 files changed, 30 insertions(+), 1 deletion(-) > > create mode 100644 include/linux/phy/phy-hdmi.h > > > > diff --git a/include/linux/phy/phy-hdmi.h b/include/linux/phy/phy-hdmi.h > > new file mode 100644 > > index 0000000000000..b7de88e9090f0 > > --- /dev/null > > +++ b/include/linux/phy/phy-hdmi.h > > @@ -0,0 +1,24 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright 2022 NXP > > + */ > > + > > +#ifndef __PHY_HDMI_H_ > > +#define __PHY_HDMI_H_ > > + > > +#include > > +/** > > + * struct phy_configure_opts_hdmi - HDMI configuration set > > + * @pixel_clk_rate: Pixel clock of video modes in KHz. > > + * @bpc: Maximum bits per color channel. > > + * @color_space: Colorspace in enum hdmi_colorspace. > > + * > > + * This structure is used to represent the configuration state of a HDMI phy. > > + */ > > +struct phy_configure_opts_hdmi { > > + unsigned int pixel_clk_rate; > > + unsigned int bpc; > > + enum hdmi_colorspace color_space; > > +}; > > Does the PHY actually care about the pixel clock rate, color space and > formats, or does it only care about the character rate? Nope it should not -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel