From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09C1DCD128A for ; Sat, 6 Apr 2024 07:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V4RnE0181LZMxA5lpE6elVhzQolTzwtiW0cs4GJdrU0=; b=IO/riBksJPj7We yV6s51D5u8JTVN7Z7am87FqrJjow7FkVcuZjdcy5EbPL0BKLx/c6yp8vzKB0q9xaYyRK7A8UUbAfa pURF5MBADpw20XDeGWyO/ZYR9HZ7PuYHITniHvPGCoi0QlTYhq9T79FDtPxiv+yUyexZbaatAFF1s TKmIp9ix6h85T/q+YStuikNTEW7XDlPZPCM83aBZR7qrMoX7IREkhHFoGJ/zQpGgVhtyjncIIV21D QmBsgo121AILo5QzwLxb7T9NIu1REG+pY+hVafsNryqnclxJzTHOc2opI0atOLMMwKAQX0/yLcxK+ IVw1OzVZO+K5GiQkCAzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt0Je-00000009riF-2C62; Sat, 06 Apr 2024 07:18:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt0Jb-00000009rhp-0PHU; Sat, 06 Apr 2024 07:18:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 13210603F1; Sat, 6 Apr 2024 07:18:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9DA8C433C7; Sat, 6 Apr 2024 07:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712387893; bh=dS8bADZziQoLtHlnkHj0dQ2paJIGjWmIuNewalgbWUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ea6S6N6KseF8FYU91uMYJN7GD6yzmV7gab0MK5qCOM9EoxQmArIK+Qf4SmrVk7wWd w4XXWVDPPOYHHZv3evO6BMbfX4VxnqR46iifX3EPm2YW1Dotyn0Z+UrRWpPLayVoIj WKMckBsbZZVR2Azg9mLn9kc6wee9HAP7/p7lvdSggO5kzf8s8yplkVQXxU6qyMQclo hSdF9W6liKlu+0CsLtUDcVuJqsrZxKyA6LHu7IsCpPTRaYEe8NzCHJhG7GB+S3w8Ye ptA0UggHfPqrixdz4A5ghcTFtERIWFgc6L2T1QHsXRcikxX+L11f46KBcCk7g+So27 mCktSUaE1/xGQ== Date: Sat, 6 Apr 2024 12:48:09 +0530 From: Vinod Koul To: Marcel Ziswiler Cc: linux-phy@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Richard Zhu , Lucas Stach , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Marcel Ziswiler , Fabio Estevam , Heiko Stuebner , Kishon Vijay Abraham I , Rob Herring , Sascha Hauer , Sergio Paracuellos , Shawn Guo , Tim Harvey , Yang Li , imx@lists.linux.dev Subject: Re: [PATCH v2] phy: freescale: imx8m-pcie: fix pcie link-up instability Message-ID: References: <20240327071946.8869-1-marcel@ziswiler.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240327071946.8869-1-marcel@ziswiler.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_001815_223977_379B6A17 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27-03-24, 08:19, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > On the i.MX 8M Mini, the AUX_PLL_REFCLK_SEL has to be left at its reset > default of AUX_IN (PLL clock). > > Background Information: > In our automated testing setup, we use Delock Mini-PCIe SATA cards [1]. > While this setup has proven very stable overall we noticed upstream on > the i.MX 8M Mini fails quite regularly (about 50/50) to bring up the > PCIe link while with NXP's downstream BSP 5.15.71_2.2.2 it always works. > As that old downstream stuff was quite different, I first also tried > NXP's latest downstream BSP 6.1.55_2.2.0 which from a PCIe point of view > is fairly vanilla, however, also there the PCIe link-up was not stable. > Comparing and debugging I noticed that upstream explicitly configures > the AUX_PLL_REFCLK_SEL to I_PLL_REFCLK_FROM_SYSPLL while working > downstream [2] leaving it at reset defaults of AUX_IN (PLL clock). > Unfortunately, the TRM does not mention any further details about this > register (both for the i.MX 8M Mini as well as the Plus). > NXP confirmed their validation codes for the i.MX8MM PCIe doesn't > configure cmn_reg063 (offset: 0x18C). > BTW: On the i.MX 8M Plus we have not seen any issues with PCIe with the > exact same setup which is why I left it unchanged. This does not apply on phy/fixes, pls rebase -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel