From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E2AFCD128A for ; Sat, 6 Apr 2024 06:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d4b2vEwJ5cYBfBW5mRuNepRfSSEm+8FRtN9MgsXFLhw=; b=e4q9b9wkzP2Qf8 0lk/8Z1J3Lvw0SllRTJtXX68N29DSFAKTF1xp7h8wKf26arb1pPgDkL2JWsdMOLZ6xoHe6ZCLdf/1 NhEvpuI/8agkO1UbvW2LsgHWm92GjG/B1IYVTK0n97gphvgt5N1grGRz0ZCvZOBlhngB1TP3B9n0j JN9G3O/e8CTS8+q+A8z14LgFK/b/6tGR25oGIdsN8KSl4mGcqD1I3K8pViAQnEgnTIM1jFrGfBZCO 8DX0CCnBDY9xxHrv7pPzQDb+M07xUhCF4Nih0vGH+j4iA+GfPvYghnvCkrkMs5NVjOvMxmRM35H5a SNUOX4BZ7s6OKnpzyKOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rszXh-00000009neK-0GCF; Sat, 06 Apr 2024 06:28:45 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rszXd-00000009nd0-3Xrr; Sat, 06 Apr 2024 06:28:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 84D7FCE1378; Sat, 6 Apr 2024 06:28:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B22BC433C7; Sat, 6 Apr 2024 06:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712384915; bh=7/bYiwPy5DVoN65zNqAT7YHPjjFt5UCoXl4SUW2wvaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BLOSuIiosYM2nz9esvvTihiOhjk7oOlq2vR96fPttQj3cdcavXpNGAA4omLq//N1L gNAziXwSF/do3XOsi7gWj0+XY6894daboMcv+5HiBDR7S/ZqNcFxbh05M/n+4I6yHe 0t2GI+yOrw1Uc8VBrR7JoCYgEqK4pFUhQsfdSw71rqaVCpk7nAjDlc7mOthe2cvhh2 Dnb47WUTjX2ECTj/DdmQ639d7csySmHHWTOLcIuYauwThtLNhvDlK4bQhYf/4GQ+Kh JIry2zTzR+voLYowydTe9cwdaWbzSetLaGaU/Lbp7Yqf6JOjIe3ik3QThE6KU/lm6V o5CxOvGDyHBhg== Date: Sat, 6 Apr 2024 11:58:31 +0530 From: Vinod Koul To: Marcel Ziswiler Cc: linux-phy@lists.infradead.org, linux-imx@nxp.com, Lucas Stach , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Richard Zhu , linux-kernel@vger.kernel.org, Marcel Ziswiler , Fabio Estevam , Heiko Stuebner , Kishon Vijay Abraham I , Marc Kleine-Budde , Rob Herring , Sascha Hauer , Shawn Guo , Tim Harvey , Yang Li , imx@lists.linux.dev Subject: Re: [PATCH v1 1/1] phy: freescale: imx8m-pcie: fix pcie link-up instability Message-ID: References: <20240322130646.1016630-1-marcel@ziswiler.com> <20240322130646.1016630-2-marcel@ziswiler.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240322130646.1016630-2-marcel@ziswiler.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_232842_081820_2467B41C X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-03-24, 14:06, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Leaving AUX_PLL_REFCLK_SEL at its reset default of AUX_IN (PLL clock) > proves to be more stable on the i.MX 8M Mini. > > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver") > Please dont keep an empty line b/w Fixes and s-o-b line... > Signed-off-by: Marcel Ziswiler > --- > > drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c > index b700f52b7b67..11fcb1867118 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c > +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c > @@ -110,8 +110,10 @@ static int imx8_pcie_phy_power_on(struct phy *phy) > /* Source clock from SoC internal PLL */ > writel(ANA_PLL_CLK_OUT_TO_EXT_IO_SEL, > imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG062); > - writel(AUX_PLL_REFCLK_SEL_SYS_PLL, > - imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG063); > + if (imx8_phy->drvdata->variant != IMX8MM) { > + writel(AUX_PLL_REFCLK_SEL_SYS_PLL, > + imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG063); > + } > val = ANA_AUX_RX_TX_SEL_TX | ANA_AUX_TX_TERM; > writel(val | ANA_AUX_RX_TERM_GND_EN, > imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG064); > -- > 2.44.0 > > > -- > linux-phy mailing list > linux-phy@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/linux-phy -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel