From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF09CCD128A for ; Mon, 8 Apr 2024 06:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uByz1OD2UByrnpOkTt8d2cQz0NX/rGp41NrukNmMXjk=; b=vG4B+0XSCJJWrU wgnzfbdWYdn0KQM6p2NWki1LwvOa5+K0Q5M8Ae50rmRl16Yc/tuO9WB5COpBO9lVW/baotJQBXG2N 3JGAV9yqUyO4XoEn+8CE//HsrSrnj0BEyHwLORx/Aa5kJPeGG8GtRFk/by4sG9R33oJ1VgIguk9Uy 4GAS4bLRD2/FrKJNWL5V/vHRs4uwMs6f1bFQ/40vRrcK1ugY09fzoegHjHr6Gb0xtG1KUC1fZRCH7 HB0eeOWtKCsMKiP/gkEwodFXCRA77T7wsKV3jv6pvpTqhwdZssfcTVeZ55wgE4fnM7KZm2m4MF/Gs Ef57LX2daxOtUmR0bCLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rti7u-0000000ESzt-26vL; Mon, 08 Apr 2024 06:05:06 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rti7o-0000000ESxm-22td for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2024 06:05:02 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-56e56ee8d5cso789646a12.2 for ; Sun, 07 Apr 2024 23:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712556297; x=1713161097; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HgB1JIhvuY/BO7MAAZPSEqht3ry2nTR4m4F5uYSapxc=; b=BJJl/4xEHh3fNV/B6Yi61sv8bqJ4nol/lLd5Gf/LlOW3/6mQ/flAj2HCl+RhBrTdhj 5roVVw6QoWxuWvimu1UE/Ncn3q01ZVDKA0NG3CC3win86a/D9WnOWmheXrrQHBB/idcS /R+3uB8zESqQqyfJzmIGA+LP4QhmH7jWCE3M9L0R9KbDjN+/+hLGbGg5HBDFrM+0H9Wi IwJAdP4RGVFiVrY7jLy0z+nD8rjj/RUOLTXi0c0BajZOv6yxtxL/dBtl4FUC8CbxwtuV ez8d9q+8tA0di8EyRS6H78+VBfodqGSiqK99WfUn8XmJhW8EZXMx/9HEeRFSvbEpM4Mo UmDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712556297; x=1713161097; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HgB1JIhvuY/BO7MAAZPSEqht3ry2nTR4m4F5uYSapxc=; b=LKqZZnuVM0l6ejSACQjnMuCPIZVMepWvpfvmYjve0E7ewHhlqXZDYem1DD4epMDLFh NxmaAE1S4ftrB3bjytFR2sBDJOWaeBR/eNeiYOltsbAVvnsU6c9DkEdeeC+1J7ggfmvi MiWySXcFgSmtCkJAmJzxMi/aKQqB9CP20F1jNkkdf+b6lNHRK2a7NrJ8x3L1Q4RfvtUl 7iUxQyj5dj7Y5x95XsZCBmw8x4Rl3DMwilZWyn6YBjNkYfjtACgGC6ZWUmt4TY2ZCSju ULbyQ4bI6VR9qwxJN2f/IzR4cjxvTb7e3PdRUhaPyh08eJkxyyCAtElGG3jIV02+5fcK BwUw== X-Forwarded-Encrypted: i=1; AJvYcCXzTYsJJOEOIm3n6ygy7lK36ikcNR3FEz7qJNnJt7Fp0cnPRvCYXWdSsOxC2HeQQA1+60on8FQvOfv+Qj7CAawInkiIaz0kb08i2Kllk6v0ScWmeAY= X-Gm-Message-State: AOJu0YwUq2IbxRqjV6yo19HzAoJ0uoWTddK6oQYW8qj44mmQB+31BHmo 1z0vYokSJ63NOjyA4kcBHgXhxekiu/OfN1pIx2pt4q9E3WpYs1ftzQPF5U74Jy0= X-Google-Smtp-Source: AGHT+IFDXy3tWRm2lGYd0E3HusgZ33A7ZYQowDKLk1RHjwU5BYJRl0sgFa686Sl3jgUpELE1zMqbzQ== X-Received: by 2002:a50:871c:0:b0:56e:2e9b:1341 with SMTP id i28-20020a50871c000000b0056e2e9b1341mr5971901edb.38.1712556297079; Sun, 07 Apr 2024 23:04:57 -0700 (PDT) Received: from linaro.org ([79.114.172.194]) by smtp.gmail.com with ESMTPSA id di19-20020a056402319300b0056b7ed75a46sm3764632edb.27.2024.04.07.23.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 23:04:56 -0700 (PDT) Date: Mon, 8 Apr 2024 09:04:55 +0300 From: Abel Vesa To: Bjorn Andersson , Krzysztof Kozlowski Cc: Stephen Boyd , Matthias Brugger , Konrad Dybcio , Dmitry Baryshkov , Neil Armstrong , AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srini Kandagatla , Johan Hovold , David Collins , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v9 1/7] dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema Message-ID: References: <20240407-spmi-multi-master-support-v9-0-fa151c1391f3@linaro.org> <20240407-spmi-multi-master-support-v9-1-fa151c1391f3@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240407_230500_581434_B6A5D1CA X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-04-07 19:07:03, Bjorn Andersson wrote: > On Sun, Apr 07, 2024 at 07:23:21PM +0300, Abel Vesa wrote: > > Add dedicated schema for X1E80100 PMIC ARB (v7) as it allows multiple > > buses by declaring them as child nodes. > > > > But is this really a "dedicated schema for X1E80100"? Isn't it "the > schema for all multi-bus controllers"? > > I.e. isn't this a "dedicated schema for all platforms starting with > SM8450"? Suggestion was from Krzysztof to add platform specific comaptible (and therefore schema). Since the first platform that will support in upstream proper multi bus is the x1e80100, the schema needs to bear the same name as the compatible. When support for multi bus will be added to the other platforms (including the SM8450), they will use the fallback compatible of the x1e80100 and will be documented in this newly added schema. We did the same thing with some PHYs drivers, IIRC. > > Can you please use the commit message to document the actual reason why > you choose to create a dedicated schema for this? Is it simply to avoid > having to schema with either pmics or multiple buses as children? I can re-send the patchset with such a phrase in commit message. One of the early versions of this patchset was actually submitting a generic compatible for multi bus, but I remember that there was a request for following the platform dedicated approach. Krzysztof, can you please provide here the argument for why that is preferred? > > Regards, > Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel