From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B50A6CD128A for ; Mon, 8 Apr 2024 12:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jOVDaSG/qwIhxxaMAPHTtGac8/a8w8rlGt1UtihQpGM=; b=jMkQ5mQTkX1Cbk 2TCXqTPMpEGuMlYB9VsJ9DFa26sMmjF5XTy0N1L9SlWmGKMOePpVKZ7xM19ZzADADQrLYYaRjzHfe eYZuredLumgpNGm76dR/OYjiCQR1OydQEH2FiCE1S8XqNtgc2xCDBl1zwavXv16kiAgYtBLC/oQr/ s2ck9jHnXIAIdeQSQopDQRSaKncyyfkQikTdKiwzRjd3hHVakeKLeuy1Wtnf2HPg75PHB8Xa0An12 ifY4leiFTzBwSC8DUgDWwUryRzETyrlAttMspnQBdNY8yuzLr49rpYpXtVXnMmUusiq5AElwQxJow SG7yI6WNYIcV9ASDHAnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtobA-0000000FcPP-3Psc; Mon, 08 Apr 2024 12:59:44 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtob7-0000000FcNP-3xzN; Mon, 08 Apr 2024 12:59:43 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rtoas-0004Ly-2b; Mon, 08 Apr 2024 12:59:26 +0000 Date: Mon, 8 Apr 2024 13:59:24 +0100 From: Daniel Golle To: Arnd Bergmann Cc: Matthias Brugger , AngeloGioacchino Del Regno , William-tw Lin , Arnd Bergmann , Ulf Hansson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] soc: mediatek: mtk-socinfo: select CONFIG_SOC_BUS Message-ID: References: <20240408125506.1594257-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240408125506.1594257-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_055942_038259_F70A7CE4 X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Apr 08, 2024 at 02:55:00PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > This is needed to avoid a link failure: > > ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined! > ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined! > I've tried to take care of this in the exact same way a long time ago. Don't ask me why it didn't find it's way into stable yet https://patchwork.kernel.org/project/linux-mediatek/patch/cc8f7f7da5bdccce514a320e0ae7468659cf7346.1707327680.git.daniel@makrotopia.org/ Cheers Daniel > Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information") > Signed-off-by: Arnd Bergmann > --- > drivers/soc/mediatek/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index 50c664b65f4d..1b7afb19ccd6 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -72,6 +72,7 @@ config MTK_SOCINFO > tristate "MediaTek SoC Information" > default y > depends on NVMEM_MTK_EFUSE > + select SOC_BUS > help > The MediaTek SoC Information (mtk-socinfo) driver provides > information about the SoC to the userspace including the > -- > 2.39.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel